[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.c

[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 --- Comment #27 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master

[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 --- Comment #26 from Tomás Cohen Arazi --- Created attachment 120290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120290&action=edit Bug 27797: (QA follow-up) Pickup locations can be overridden too This patch ad

[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 --- Comment #25 from Tomás Cohen Arazi --- Created attachment 120289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120289&action=edit Bug 27797: (QA follow-up) Make tests more robust This patch makes the tests mo

[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 --- Comment #24 from Tomás Cohen Arazi --- Created attachment 120288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120288&action=edit Bug 27797: (follow-up): Remove stray x-koha-override definition Signed-off-by:

[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 --- Comment #23 from Tomás Cohen Arazi --- Created attachment 120287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120287&action=edit Bug 27797: (QA follow-up) Additional tests and operator change I added a few t

[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 --- Comment #22 from Tomás Cohen Arazi --- Created attachment 120286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120286&action=edit Bug 27797: Make POST /holds use the stashed koha.overrides Bug 26181 introduce

[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 --- Comment #21 from Tomás Cohen Arazi --- Created attachment 120285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120285&action=edit Bug 27797: Unit tests Signed-off-by: Martin Renvoize Signed-off-by: Nick Cle

[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 Tomás Cohen Arazi changed: What|Removed |Added Attachment #117930|0 |1 is obsolete|

[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 Tomás Cohen Arazi changed: What|Removed |Added Attachment #117929|0 |1 is obsolete|

[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 Tomás Cohen Arazi changed: What|Removed |Added Attachment #117763|0 |1 is obsolete|

[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 Tomás Cohen Arazi changed: What|Removed |Added Attachment #117762|0 |1 is obsolete|

[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 Tomás Cohen Arazi changed: What|Removed |Added Attachment #117761|0 |1 is obsolete|

[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --

[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 Tomás Cohen Arazi changed: What|Removed |Added Attachment #117920|0 |1 is obsolete|

[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #

[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 --- Comment #19 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #17) > Then maybe it should be part of Can*BeReserved return. We faced this with the API and pickup locations: we really need a way to notify the c

[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 --- Comment #18 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #17) > Then maybe it should be part of Can*BeReserved return. > > (yes it's out of the scope, I am just thinking loud here) (In reply to Jonathan

[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 --- Comment #17 from Jonathan Druart --- Then maybe it should be part of Can*BeReserved return. (yes it's out of the scope, I am just thinking loud here) -- You are receiving this mail because: You are watching all bug changes. _

[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 --- Comment #16 from Jonathan Druart --- (In reply to Jonathan Druart from comment #15) > Why don't we actually enforce AllowHoldPolicyOverride in AddReserve? Hum, forget that. It would mean we will have to call CanBeReserve* from

[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 --- Comment #15 from Jonathan Druart --- Why don't we actually enforce AllowHoldPolicyOverride in AddReserve? -- You are receiving this mail because: You are watching all bug changes. __

[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 Tomás Cohen Arazi changed: What|Removed |Added QA Contact||n...@bywatersolutions.co

[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 Tomás Cohen Arazi changed: What|Removed |Added Blocks||27898 Referenced Bugs:

[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Signed Off --- Comment

[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 --- Comment #13 from Tomás Cohen Arazi --- Created attachment 117930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117930&action=edit Bug 27797: (QA follow-up) Pickup locations can be overridden too This patch ad

[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 --- Comment #12 from Tomás Cohen Arazi --- Created attachment 117929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117929&action=edit Bug 27797: (QA follow-up) Make tests more robust This patch makes the tests mo

[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 --- Comment #11 from Tomás Cohen Arazi --- Created attachment 117920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117920&action=edit Bug 27797: (follow-up): Remove stray x-koha-override definition Signed-off-by:

[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 --- Comment #10 from Nick Clemens --- Created attachment 117763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117763&action=edit Bug 27797: (QA follow-up) Additional tests and operator change I added a few tests

[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 Nick Clemens changed: What|Removed |Added Attachment #117541|0 |1 is obsolete|

[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 Nick Clemens changed: What|Removed |Added Attachment #117540|0 |1 is obsolete|

[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiv

[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 Martin Renvoize changed: What|Removed |Added CC||k...@bywatersolutions.com,

[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #7

[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 Martin Renvoize changed: What|Removed |Added Attachment #117499|0 |1 is obsolete|

[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 Martin Renvoize changed: What|Removed |Added Attachment #117498|0 |1 is obsolete|

[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 --- Comment #4 from Tomás Cohen Arazi --- If we agree on this patches, I suggest this should be backported down to 20.05 so anyone relying on the feature/behavior change it introduced, doesn't need to change their code when they upgr

[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 117499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117499&action=edit Bug 27797: Make POST /holds use the stashed koha.overrides Bug 26181 introduced

[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 117498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117498&action=edit Bug 27797: Unit tests -- You are receiving this mail because: You are watching

[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You a

[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 --- Comment #1 from Tomás Cohen Arazi --- Ok, on doing this, I discovered the versions of the JSON::Validator we use don't handle array type of headers, so I will need to make the header a string instead of an array with collectionFo

[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com