[Koha-bugs] [Bug 27927] longoverdue cronjob renews items before marking lost when both RenewAccruingItemWhenPaid and WhenLostForgiveFine are enabled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27927 Andrew Isherwood changed: What|Removed |Added CC|bugzi...@warmlight.co.uk| -- You are receiving t

[Koha-bugs] [Bug 27927] longoverdue cronjob renews items before marking lost when both RenewAccruingItemWhenPaid and WhenLostForgiveFine are enabled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27927 Victor Grousset/tuxayo changed: What|Removed |Added Status|Pushed to oldstable |RESOLVED

[Koha-bugs] [Bug 27927] longoverdue cronjob renews items before marking lost when both RenewAccruingItemWhenPaid and WhenLostForgiveFine are enabled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27927 Bug 27927 depends on bug 25508, which changed state. Bug 25508 Summary: Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508

[Koha-bugs] [Bug 27927] longoverdue cronjob renews items before marking lost when both RenewAccruingItemWhenPaid and WhenLostForgiveFine are enabled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27927 Andrew Fuerste-Henry changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable

[Koha-bugs] [Bug 27927] longoverdue cronjob renews items before marking lost when both RenewAccruingItemWhenPaid and WhenLostForgiveFine are enabled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27927 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.c

[Koha-bugs] [Bug 27927] longoverdue cronjob renews items before marking lost when both RenewAccruingItemWhenPaid and WhenLostForgiveFine are enabled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27927 --- Comment #16 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 27927] longoverdue cronjob renews items before marking lost when both RenewAccruingItemWhenPaid and WhenLostForgiveFine are enabled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27927 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master

[Koha-bugs] [Bug 27927] longoverdue cronjob renews items before marking lost when both RenewAccruingItemWhenPaid and WhenLostForgiveFine are enabled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27927 Nick Clemens changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |n...@bywatersolutions.com

[Koha-bugs] [Bug 27927] longoverdue cronjob renews items before marking lost when both RenewAccruingItemWhenPaid and WhenLostForgiveFine are enabled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27927 Nick Clemens changed: What|Removed |Added Attachment #119236|0 |1 is obsolete|

[Koha-bugs] [Bug 27927] longoverdue cronjob renews items before marking lost when both RenewAccruingItemWhenPaid and WhenLostForgiveFine are enabled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27927 Nick Clemens changed: What|Removed |Added Attachment #119235|0 |1 is obsolete|

[Koha-bugs] [Bug 27927] longoverdue cronjob renews items before marking lost when both RenewAccruingItemWhenPaid and WhenLostForgiveFine are enabled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27927 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiv

[Koha-bugs] [Bug 27927] longoverdue cronjob renews items before marking lost when both RenewAccruingItemWhenPaid and WhenLostForgiveFine are enabled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27927 --- Comment #13 from Martin Renvoize --- Aha, thanks Andrew.. I hadn't thought about changing FinesMode having been changed in the background... certainly a bug, the tests should lock the preference to ensure they pass regardless. -

[Koha-bugs] [Bug 27927] longoverdue cronjob renews items before marking lost when both RenewAccruingItemWhenPaid and WhenLostForgiveFine are enabled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27927 --- Comment #12 from Andrew Fuerste-Henry --- Filed bug 28097 for that test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@

[Koha-bugs] [Bug 27927] longoverdue cronjob renews items before marking lost when both RenewAccruingItemWhenPaid and WhenLostForgiveFine are enabled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27927 --- Comment #11 from Andrew Fuerste-Henry --- Signed off because I get that same test failure with FinesMode on without these patches. Filing a new bug for that. -- You are receiving this mail because: You are watching all bug chan

[Koha-bugs] [Bug 27927] longoverdue cronjob renews items before marking lost when both RenewAccruingItemWhenPaid and WhenLostForgiveFine are enabled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27927 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #119194|0 |1 is obsolete

[Koha-bugs] [Bug 27927] longoverdue cronjob renews items before marking lost when both RenewAccruingItemWhenPaid and WhenLostForgiveFine are enabled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27927 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #119193|0 |1 is obsolete

[Koha-bugs] [Bug 27927] longoverdue cronjob renews items before marking lost when both RenewAccruingItemWhenPaid and WhenLostForgiveFine are enabled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27927 Andrew Fuerste-Henry changed: What|Removed |Added Status|Failed QA |Signed Off -- You a

[Koha-bugs] [Bug 27927] longoverdue cronjob renews items before marking lost when both RenewAccruingItemWhenPaid and WhenLostForgiveFine are enabled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27927 --- Comment #8 from Andrew Fuerste-Henry --- Going back through this, the test passes if FinesMode is set to Don't Calculate, but fails if FinesMode is set to Calculate and Charge. -- You are receiving this mail because: You are wa

[Koha-bugs] [Bug 27927] longoverdue cronjob renews items before marking lost when both RenewAccruingItemWhenPaid and WhenLostForgiveFine are enabled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27927 --- Comment #7 from Martin Renvoize --- I'm really struggling to get this test to fail.. how are you running it? -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 27927] longoverdue cronjob renews items before marking lost when both RenewAccruingItemWhenPaid and WhenLostForgiveFine are enabled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27927 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Commen

[Koha-bugs] [Bug 27927] longoverdue cronjob renews items before marking lost when both RenewAccruingItemWhenPaid and WhenLostForgiveFine are enabled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27927 Martin Renvoize changed: What|Removed |Added Blocks|27636 | Referenced Bugs: https

[Koha-bugs] [Bug 27927] longoverdue cronjob renews items before marking lost when both RenewAccruingItemWhenPaid and WhenLostForgiveFine are enabled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27927 Martin Renvoize changed: What|Removed |Added Blocks||24300 Referenced Bugs:

[Koha-bugs] [Bug 27927] longoverdue cronjob renews items before marking lost when both RenewAccruingItemWhenPaid and WhenLostForgiveFine are enabled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27927 Martin Renvoize changed: What|Removed |Added CC||and...@bywatersolutions.co

[Koha-bugs] [Bug 27927] longoverdue cronjob renews items before marking lost when both RenewAccruingItemWhenPaid and WhenLostForgiveFine are enabled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27927 Martin Renvoize changed: What|Removed |Added Attachment #118781|0 |1 is obsolete|

[Koha-bugs] [Bug 27927] longoverdue cronjob renews items before marking lost when both RenewAccruingItemWhenPaid and WhenLostForgiveFine are enabled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27927 --- Comment #4 from Martin Renvoize --- Created attachment 119193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119193&action=edit Bug 27927: Add Unit Tests Add a unit test to check that 'FORGIVEN' credits do not

[Koha-bugs] [Bug 27927] longoverdue cronjob renews items before marking lost when both RenewAccruingItemWhenPaid and WhenLostForgiveFine are enabled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27927 Martin Renvoize changed: What|Removed |Added Blocks|14825 |27636 Referenced Bugs:

[Koha-bugs] [Bug 27927] longoverdue cronjob renews items before marking lost when both RenewAccruingItemWhenPaid and WhenLostForgiveFine are enabled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27927 Martin Renvoize changed: What|Removed |Added Depends on|23051 |25508 Referenced Bugs:

[Koha-bugs] [Bug 27927] longoverdue cronjob renews items before marking lost when both RenewAccruingItemWhenPaid and WhenLostForgiveFine are enabled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27927 Martin Renvoize changed: What|Removed |Added Attachment #118766|0 |1 is obsolete|

[Koha-bugs] [Bug 27927] longoverdue cronjob renews items before marking lost when both RenewAccruingItemWhenPaid and WhenLostForgiveFine are enabled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27927 Martin Renvoize changed: What|Removed |Added Blocks||14825 Referenced Bugs:

[Koha-bugs] [Bug 27927] longoverdue cronjob renews items before marking lost when both RenewAccruingItemWhenPaid and WhenLostForgiveFine are enabled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27927 --- Comment #2 from Martin Renvoize --- This will need some tests writing, but I wanted to get the patch up here and start proceeding with testing. I've currently only prevented the renewal for 'FORGIVEN' credit types, I wonder if w

[Koha-bugs] [Bug 27927] longoverdue cronjob renews items before marking lost when both RenewAccruingItemWhenPaid and WhenLostForgiveFine are enabled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27927 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff A

[Koha-bugs] [Bug 27927] longoverdue cronjob renews items before marking lost when both RenewAccruingItemWhenPaid and WhenLostForgiveFine are enabled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27927 --- Comment #1 from Martin Renvoize --- Created attachment 118766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118766&action=edit Bug 27927: Prevent renewal on lost forgive The `RenewAccruingItemWhenPaid` prefer

[Koha-bugs] [Bug 27927] longoverdue cronjob renews items before marking lost when both RenewAccruingItemWhenPaid and WhenLostForgiveFine are enabled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27927 Martin Renvoize changed: What|Removed |Added CC||andrew.isherwood@ptfs-euro

[Koha-bugs] [Bug 27927] longoverdue cronjob renews items before marking lost when both RenewAccruingItemWhenPaid and WhenLostForgiveFine are enabled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27927 Nick Clemens changed: What|Removed |Added CC||geo...@nekls.org Dep