https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Caroline Cyr La Rose changed:
What|Removed |Added
Documentation||Caroline Cyr La Rose
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Tomás Cohen Arazi changed:
What|Removed |Added
Keywords|release-notes-needed|
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Tomás Cohen Arazi changed:
What|Removed |Added
Text to go in the||This feature adds a way
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Kyle M Hall changed:
What|Removed |Added
CC||k...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Bug 27947 depends on bug 27945, which changed state.
Bug 27945 Summary: Limit the number of active article requests per patron
category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
What|Removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
--- Comment #68 from Jonathan Druart ---
Pushed to master for 21.11, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Jonathan Druart changed:
What|Removed |Added
Version(s)||21.11.00
released
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
--- Comment #67 from Tomás Cohen Arazi ---
Created attachment 125740
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125740=edit
Bug 27947: (QA follow-up) Fix shipped notice
Signed-off-by: Tomas Cohen Arazi
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
--- Comment #66 from Tomás Cohen Arazi ---
Created attachment 125739
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125739=edit
Bug 27947: (QA follow-up) Make parameters a hashref
This patch makes the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
--- Comment #65 from Jonathan Druart ---
I think there is something wrong with the notice.
From the DBrev:
28 $dbh->do(q{
29 UPDATE letter SET content=REPLACE(content,
'<>', '<>')
30 WHERE module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
--- Comment #64 from Jonathan Druart ---
1. Not blocker, but:
-my ( $self, $notes ) = @_;
+my ( $self, $cancellation_reason, $notes ) = @_;
You should have used a hashref, especially because we have Koha::Hold->cancel
that
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Martin Renvoize changed:
What|Removed |Added
Blocks|29083 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Tomás Cohen Arazi changed:
What|Removed |Added
Blocks||29082
Referenced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Tomás Cohen Arazi changed:
What|Removed |Added
Blocks||29083
Referenced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
--- Comment #63 from Tomás Cohen Arazi ---
Created attachment 125174
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125174=edit
Bug 27947: (QA follow-up) Clarify permissions
Privileged routes need permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
--- Comment #62 from Tomás Cohen Arazi ---
Created attachment 125173
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125173=edit
Bug 27947: (QA follow-up) Update test to highlight issue
This addition to the tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
--- Comment #61 from Tomás Cohen Arazi ---
Created attachment 125172
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125172=edit
Bug 27947: (QA follow-up) Remove incorrect permission check
The API was checking for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
--- Comment #60 from Tomás Cohen Arazi ---
Created attachment 125171
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125171=edit
Bug 27947: Add regression tests for routes
Signed-off-by: Tomas Cohen Arazi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
--- Comment #59 from Tomás Cohen Arazi ---
Created attachment 125170
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125170=edit
Bug 27947: (QA follow-up) Refactor routes
This patch refactors the route specs a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
--- Comment #58 from Tomás Cohen Arazi ---
Created attachment 125169
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125169=edit
Bug 27947: (follow-up) Add OPAC cancellation as new reason too
Something that
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
--- Comment #57 from Tomás Cohen Arazi ---
Created attachment 125168
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125168=edit
Bug 27947: (follow-up) Improve atomic update
We do not need to replace the whole
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
--- Comment #56 from Tomás Cohen Arazi ---
Created attachment 125167
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125167=edit
Bug 27947: Add cancellation reason to article request
This bug adds a cancellation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
--- Comment #55 from Tomás Cohen Arazi ---
Created attachment 125166
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125166=edit
Bug 27947: [DO NOT PUSH] update ArticleRequest schema
Signed-off-by: Marcel de Rooy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
--- Comment #54 from Tomás Cohen Arazi ---
Created attachment 125165
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125165=edit
Bug 27947: Add authorised values list in article requests cancellation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #125047|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #125046|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #125045|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #125044|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #125043|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #125042|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #125041|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #125040|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #125039|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #125038|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
--- Comment #53 from Tomás Cohen Arazi ---
Last rebase after dependency changes.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Tomás Cohen Arazi changed:
What|Removed |Added
Depends on||27945
Referenced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Jonathan Druart changed:
What|Removed |Added
Keywords||release-notes-needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Martin Renvoize changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Martin Renvoize changed:
What|Removed |Added
Status|Signed Off |Passed QA
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Martin Renvoize changed:
What|Removed |Added
Attachment #125016|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Martin Renvoize changed:
What|Removed |Added
Attachment #125010|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Martin Renvoize changed:
What|Removed |Added
Attachment #125009|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Martin Renvoize changed:
What|Removed |Added
Attachment #125008|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Martin Renvoize changed:
What|Removed |Added
Attachment #125007|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Martin Renvoize changed:
What|Removed |Added
Attachment #125006|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Martin Renvoize changed:
What|Removed |Added
Attachment #125005|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Martin Renvoize changed:
What|Removed |Added
Attachment #125004|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Martin Renvoize changed:
What|Removed |Added
Attachment #125003|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Martin Renvoize changed:
What|Removed |Added
Attachment #125002|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
--- Comment #41 from Tomás Cohen Arazi ---
(In reply to Martin Renvoize from comment #39)
> Sorry guys.. little more needed here.
>
> My first followup drops the 'reserveforothers' permission requirement as I
> don't think that
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
--- Comment #40 from Tomás Cohen Arazi ---
Created attachment 125016
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125016=edit
Bug 27947: (QA follow-up) Clarify permissions
Privileged routes need permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Martin Renvoize changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
--- Comment #38 from Martin Renvoize ---
Created attachment 125010
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125010=edit
Bug 27947: (QA follow-up) Update test to highlight issue
This addition to the tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
--- Comment #37 from Martin Renvoize ---
Created attachment 125009
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125009=edit
Bug 27947: (QA follow-up) Remove incorrect permission check
The API was checking for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Martin Renvoize changed:
What|Removed |Added
Attachment #124999|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Martin Renvoize changed:
What|Removed |Added
Attachment #124998|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Martin Renvoize changed:
What|Removed |Added
Attachment #124997|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Martin Renvoize changed:
What|Removed |Added
Attachment #124996|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Martin Renvoize changed:
What|Removed |Added
Attachment #124995|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Martin Renvoize changed:
What|Removed |Added
Attachment #124994|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Martin Renvoize changed:
What|Removed |Added
Attachment #124993|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
--- Comment #29 from Tomás Cohen Arazi ---
Created attachment 124999
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124999=edit
Bug 27947: Add regression tests for routes
Signed-off-by: Tomas Cohen Arazi
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
--- Comment #28 from Tomás Cohen Arazi ---
Created attachment 124998
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124998=edit
Bug 27947: (QA follow-up) Refactor routes
This patch refactors the route specs a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
--- Comment #27 from Tomás Cohen Arazi ---
Created attachment 124997
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124997=edit
Bug 27947: (follow-up) Add OPAC cancellation as new reason too
Something that
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
--- Comment #26 from Tomás Cohen Arazi ---
Created attachment 124996
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124996=edit
Bug 27947: (follow-up) Improve atomic update
We do not need to replace the whole
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
--- Comment #25 from Tomás Cohen Arazi ---
Created attachment 124995
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124995=edit
Bug 27947: Add cancellation reason to article request
This bug adds a cancellation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
--- Comment #24 from Tomás Cohen Arazi ---
Created attachment 124994
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124994=edit
Bug 27947: [DO NOT PUSH] update ArticleRequest schema
Signed-off-by: Marcel de Rooy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
--- Comment #23 from Tomás Cohen Arazi ---
Created attachment 124993
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124993=edit
Bug 27947: Add authorised values list in article requests cancellation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #124956|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #124955|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #124954|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #124953|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #124952|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Tomás Cohen Arazi changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
--- Comment #22 from Tomás Cohen Arazi ---
(In reply to Marcel de Rooy from comment #9)
> > > [5] Why do you add cancel_article_request to Koha/REST/V1/Patrons.pm ?
> > > Apart
> > > from checking existence of the patron id, what
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Signed Off |ASSIGNED
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Marcel de Rooy changed:
What|Removed |Added
CC||n...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
--- Comment #20 from Marcel de Rooy ---
Looks good to me.
Added two follow-ups to refine notice update in db rev and to add OPAC
cancellation as a new reason.
One thing remains (point 5 from comment7):
DELETE
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
--- Comment #19 from Marcel de Rooy ---
Created attachment 124956
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124956=edit
Bug 27947: (follow-up) Add OPAC cancellation as new reason too
Something that currently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
--- Comment #18 from Marcel de Rooy ---
Created attachment 124955
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124955=edit
Bug 27947: (follow-up) Improve atomic update
We do not need to replace the whole notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Marcel de Rooy changed:
What|Removed |Added
Attachment #124851|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Marcel de Rooy changed:
What|Removed |Added
Attachment #124850|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Marcel de Rooy changed:
What|Removed |Added
Attachment #124849|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Marcel de Rooy changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Marcel de Rooy changed:
What|Removed |Added
Summary|Add cancellation reasons to |Add default cancellation
87 matches
Mail list logo
