[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Katrin Fischer changed: What|Removed |Added Text to go in the|This enhancement lets you |This enhancement lets you

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 --- Comment #37 from Jonathan Druart --- Follow-up pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 --- Comment #36 from Jonathan Druart --- Created attachment 122795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122795=edit Bug 27948: Fix file mode From commit b7acefa116c9ae1e738b5c53f30cf0d6c11d8784 Bug

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 --- Comment #35 from Jonathan Druart --- opac/opac-request-article.pl changed file mode from 100755 to 100644 Hum?? -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 --- Comment #34 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Jonathan Druart changed: What|Removed |Added Version(s)||21.11.00 released

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 --- Comment #33 from Jonathan Druart --- Created attachment 122774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122774=edit Bug 27948: Remove unused branchcode var -- You are receiving this mail because: You

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 --- Comment #32 from Marcel de Rooy --- Created attachment 122771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122771=edit Bug 27948: (QA follow-up) Remove NewsChannels reference We only need to remove the

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Marcel de Rooy changed: What|Removed |Added Status|Patch doesn't apply |Passed QA -- You are

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 --- Comment #30 from Marcel de Rooy --- (In reply to Agustín Moyano from comment #29) > I see.. maybe we could make a "KohaNews.getOne" helper with the same > paremeters, but get the most relevant news.. if you get one that matches

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 --- Comment #29 from Agustín Moyano --- (In reply to Marcel de Rooy from comment #28) > Agustin: When you have an All branches and a branch specific one, they are > both listed directly following each other. An OPAC user would not

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 --- Comment #28 from Marcel de Rooy --- Agustin: When you have an All branches and a branch specific one, they are both listed directly following each other. An OPAC user would not know that they actually are two separate messages.

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Marcel de Rooy changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 --- Comment #26 from Marcel de Rooy --- Created attachment 122526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122526=edit Bug 27948: (QA follow-up) Correct empty branchcode Let us just fix it here and leave

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 --- Comment #25 from Marcel de Rooy --- Actually, seeing a minor bug: +[% SET disclaimer = KohaNews.get( location => "ArticleRequestsDisclaimerText", lang => lang, library => branchcode ) %] Just as I did, you expected branchcode

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 --- Comment #24 from Marcel de Rooy --- Created attachment 122525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122525=edit Bug 27948: (QA follow-up) Remove unused $disclaimer code Signed-off-by: Marcel de Rooy

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Marcel de Rooy changed: What|Removed |Added Attachment #122520|0 |1 is obsolete|

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Marcel de Rooy changed: What|Removed |Added Attachment #122519|0 |1 is obsolete|

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 --- Comment #21 from Agustín Moyano --- Created attachment 122520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122520=edit Bug 27948: (follow-up) Use Koha.news and PROCESS koha_news_block to bring disclaimer --

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Agustín Moyano changed: What|Removed |Added Attachment #122134|0 |1 is obsolete|

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Agustín Moyano changed: What|Removed |Added Status|Failed QA |Signed Off -- You are

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 --- Comment #19 from Agustín Moyano --- (In reply to Katrin Fischer from comment #18) > > Given how Koha now operates, I think we could well do without the fallback > > for now. If you did not define the disclaimer in a language

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 --- Comment #18 from Katrin Fischer --- > Given how Koha now operates, I think we could well do without the fallback > for now. If you did not define the disclaimer in a language that you do > offer, you dont have a disclaimer. >

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 --- Comment #17 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #16) > Please note the fallback in NewsChannels too: > > (opac_news.lang = '' OR opac_news.lang = ?) But it is not very useful here ;) I agree with

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 --- Comment #16 from Marcel de Rooy --- Please note the fallback in NewsChannels too: (opac_news.lang = '' OR opac_news.lang = ?) -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 --- Comment #15 from Katrin Fischer --- Hi Augustin, I think we should not hardcode a fallback to English and it would be not correct with the other behaviour in Koha, like the templating system. Actually I think the fallback is

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 --- Comment #14 from Agustín Moyano --- (In reply to Marcel de Rooy from comment #10) > Why not use a construction like: > > [% PROCESS koha_news_block news => KohaNews.get({ location => > 'ArticleRequestsDisclaimerText', lang =>

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 --- Comment #13 from Agustín Moyano --- (In reply to Marcel de Rooy from comment #9) > Could not compile /usr/share/koha/opac/opac-request-article.pl: Bareword > "action" not allowed while "strict subs" in use at >

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Agustín Moyano changed: What|Removed |Added Attachment #122132|0 |1 is obsolete|

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Agustín Moyano changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Agustín Moyano changed: What|Removed |Added Attachment #122053|0 |1 is obsolete|

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Failed QA -- You are

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 --- Comment #10 from Marcel de Rooy --- Why not use a construction like: [% PROCESS koha_news_block news => KohaNews.get({ location => 'ArticleRequestsDisclaimerText', lang => lang, library => branchcode, blocktitle => 0 }) %]

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 --- Comment #9 from Marcel de Rooy --- Could not compile /usr/share/koha/opac/opac-request-article.pl: Bareword "action" not allowed while "strict subs" in use at /usr/share/koha/opac/opac-request-article.pl line 49. How did you

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED -- You are

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Katrin Fischer changed: What|Removed |Added Text to go in the|This enhancement lets you |This enhancement lets you

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Agustín Moyano changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Agustín Moyano changed: What|Removed |Added Attachment #121505|0 |1 is obsolete|

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Agustín Moyano changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #7

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Katrin Fischer changed: What|Removed |Added Text to go in the|This enhancement lets you |This enhancement lets you

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 David Nind changed: What|Removed |Added Text to go in the||This enhancement lets you

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 David Nind changed: What|Removed |Added Attachment #121441|0 |1 is obsolete|

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 David Nind changed: What|Removed |Added Attachment #121440|0 |1 is obsolete|

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 David Nind changed: What|Removed |Added Attachment #121439|0 |1 is obsolete|

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 --- Comment #2 from Agustín Moyano --- Created attachment 121440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121440=edit Bug 27948: Add ArticleRequestsDisclaimerText syspref -- You are receiving this mail

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 --- Comment #3 from Agustín Moyano --- Created attachment 121441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121441=edit Bug 27948: Add disclaimer to article request If ArticleRequestsDisclaimerText syspref is

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 --- Comment #1 from Agustín Moyano --- Created attachment 121439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121439=edit Bug 27948: Add atomic update -- You are receiving this mail because: You are watching

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Agustín Moyano changed: What|Removed |Added Patch complexity|--- |Small patch

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com

[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Nick Clemens changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl