[Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013 Victor Grousset/tuxayo changed: What|Removed |Added Resolution|--- |FIXED

[Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013 Andrew Fuerste-Henry changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable

[Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013 Bug 28013 depends on bug 28078, which changed state. Bug 28078 Summary: Add option to ignore hold counts when checking CanItemBeReserved https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28078 What|Removed

[Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013 Fridolin Somers changed: What|Removed |Added Version(s)|21.05.00|21.05.00,20.11.06

[Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013 --- Comment #25 from Joonas Kylmälä --- *** Bug 26659 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bu

[Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013 --- Comment #24 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013 Jonathan Druart changed: What|Removed |Added Version(s)||21.05.00 released

[Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013 --- Comment #23 from Joonas Kylmälä --- Passing QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org

[Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013 --- Comment #22 from Joonas Kylmälä --- Created attachment 119261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119261&action=edit Bug 28013: (follow-up) Reset the patron loop To test: 1 - Apply all other patches

[Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013 --- Comment #21 from Joonas Kylmälä --- Created attachment 119260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119260&action=edit Bug 28013: Unit tests Cover the case of multiple patrons and multiple items that

[Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013 --- Comment #20 from Joonas Kylmälä --- Created attachment 119259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119259&action=edit Bug 28013: (follow-up) Correct and update call to CanItemBeReserved The current c

[Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013 --- Comment #19 from Joonas Kylmälä --- Created attachment 119258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119258&action=edit Bug 28013: (QA follow-up) Remove unused variable Signed-off-by: Joonas Kylmälä

[Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013 Joonas Kylmälä changed: What|Removed |Added Status|Signed Off |Passed QA Stat

[Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013 --- Comment #15 from Joonas Kylmälä --- Nick, I reviewed the bug 28078 again and your fix there seems great. I think we can keep the patches here like this, I will QA the whole thing after the minor bug I spotted in bug 28078 is fixe

[Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013 --- Comment #14 from Joonas Kylmälä --- (In reply to Nick Clemens from comment #13) > (In reply to Joonas Kylmälä from comment #12) > > Nick, is it possible to drop the dependency to bug 28078? I mean if we don't > > take it would th

[Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013 --- Comment #13 from Nick Clemens --- (In reply to Joonas Kylmälä from comment #12) > Nick, is it possible to drop the dependency to bug 28078? I mean if we don't > take it would the behaviour change with your refactoring here or sta

[Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013 --- Comment #12 from Joonas Kylmälä --- Nick, is it possible to drop the dependency to bug 28078? I mean if we don't take it would the behaviour change with your refactoring here or stay same? Please see my comments in bug 28078, it

[Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013 --- Comment #11 from Nick Clemens --- (In reply to Jonathan Druart from comment #7) > I don't manage to convince myself it's correct. > There is an edge case, looking at the code: > > The patron iterator is set before the ITEM loop.

[Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013 --- Comment #10 from Nick Clemens --- Created attachment 119127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119127&action=edit Bug 28013: (follow-up) Reset the patron loop To test: 1 - Apply all other patches a

[Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013 --- Comment #9 from Nick Clemens --- Created attachment 119126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119126&action=edit Bug 28013: Unit tests Cover the case of multiple patrons and multiple items that can

[Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013 --- Comment #8 from Nick Clemens --- Created attachment 119125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119125&action=edit Bug 28013: (follow-up) Correct and update call to CanItemBeReserved The current call

[Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013 Nick Clemens changed: What|Removed |Added Status|In Discussion |Signed Off -- You are recei

[Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013 Nick Clemens changed: What|Removed |Added Depends on||28078 Referenced Bugs: htt

[Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-

[Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013 Joonas Kylmälä changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #6 f

[Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013 Joonas Kylmälä changed: What|Removed |Added Status|Passed QA |Signed Off --- Comment #5

[Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013 --- Comment #4 from Joonas Kylmälä --- Created attachment 118951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118951&action=edit Bug 28013: (QA follow-up) Remove unused variable Signed-off-by: Joonas Kylmälä -

[Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013 Joonas Kylmälä changed: What|Removed |Added Attachment #118928|0 |1 is obsolete|

[Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013 Joonas Kylmälä changed: What|Removed |Added Status|Signed Off |Passed QA -- You are rece

[Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@helsinki.fi

[Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013 Amit Gupta changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receivi

[Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013 Amit Gupta changed: What|Removed |Added Attachment #118592|0 |1 is obsolete|

[Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013 Andrew Nugged changed: What|Removed |Added CC||nug...@gmail.com,

[Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013 Owen Leonard changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com

[Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community

[Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013 --- Comment #1 from Nick Clemens --- Created attachment 118592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118592&action=edit Bug 28013: Performance improvements to CanBookBeRenewed In the case of 'AllowRenewal

[Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are re