[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 Jonathan Druart changed: What|Removed |Added Resolution|--- |FIXED

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2022-04-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 --- Comment #36 from David Cook --- Should the status of this one be updated? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Version(s)|21.05.00,20.11.07,20.05.13

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 --- Comment #35 from wainuiwitikap...@catalyst.net.nz --- Backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 Mason James changed: What|Removed |Added Resolution|FIXED |---

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 Mason James changed: What|Removed |Added CC||m...@kohaaloha.com ---

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-06-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Resolution|--- |FIXED

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-06-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 --- Comment #33 from wainuiwitikap...@catalyst.net.nz --- Not backported to 19.11.x Please see Victor's comment above. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-06-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 --- Comment #32 from Victor Grousset/tuxayo --- It doesn't change how Koha works. It fixes the tests on Debian 11 but for 19.11.x, the CI doesn't use Debian 11 so it won't do anything. -- You are receiving this mail because: You

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added CC|

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-06-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 Victor Grousset/tuxayo changed: What|Removed |Added Status|Pushed to oldstable |Pushed to

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-06-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 Victor Grousset/tuxayo changed: What|Removed |Added Status|Pushed to stable|Pushed to

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 Fridolin Somers changed: What|Removed |Added Version(s)|21.05.00,20.11.06 |21.05.00,20.11.07

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 --- Comment #29 from Fridolin Somers --- Sorry the commit was not in 20.11.06. I've added it so it will be in 20.11.07 -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-05-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 Jonathan Druart changed: What|Removed |Added Keywords|rel_21_05_candidate | -- You are receiving

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 Fridolin Somers changed: What|Removed |Added CC|

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-05-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 --- Comment #27 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-05-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-05-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 Jonathan Druart changed: What|Removed |Added Keywords|release-notes-needed| -- You are receiving

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-05-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 --- Comment #26 from Victor Grousset/tuxayo --- Thanks Alvaro for the additional check and setting up a local Koha for the occasion, welcome to Koha :) -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-05-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 Alvaro Cornejo changed: What|Removed |Added Attachment #120911|0 |1 is obsolete|

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 --- Comment #24 from David Cook --- (In reply to Martin Renvoize from comment #23) > I've had a go at the text for release notes.. hopefully, it's clear enough. Looks good to me -- You are receiving this mail because: You are

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 --- Comment #23 from Martin Renvoize --- I've had a go at the text for release notes.. hopefully, it's clear enough. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 Martin Renvoize changed: What|Removed |Added Text to go in the||The code library Koha

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 --- Comment #22 from Martin Renvoize --- All works as expected and after agreed discussions we've picked the 'Alternate' option. Thanks for all the work guys. Passing QA -- You are receiving this mail because: You are watching

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 Martin Renvoize changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 Martin Renvoize changed: What|Removed |Added Attachment #120350|0 |1 is obsolete|

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 Martin Renvoize changed: What|Removed |Added Attachment #120851|0 |1 is obsolete|

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 --- Comment #20 from David Cook --- (In reply to David Cook from comment #19) > (In reply to Jonathan Druart from comment #15) > > I am in favour of dropping it, with a warning in the release notes. > > Works for me. Upon review,

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 --- Comment #19 from David Cook --- (In reply to Jonathan Druart from comment #15) > I am in favour of dropping it, with a warning in the release notes. Works for me. -- You are receiving this mail because: You are watching all

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 --- Comment #18 from Victor Grousset/tuxayo --- notes: tried with a without the patch to confirm the issue and fix fix in the patch on the number of expected tests -- You are receiving this mail because: You are watching all bug

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 --- Comment #17 from Victor Grousset/tuxayo --- Works :) code looks good, QA script ok Count my QA stamp in, I'll try to find someone to sign-off -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #120818|0 |1 is

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 Jonathan Druart changed: What|Removed |Added Keywords||release-notes-needed ---

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 --- Comment #14 from David Cook --- I've provided an alternate patch for dropping support for the abbreviated format. I'll leave it up to QA and the RM to decide if they want to support the abbreviated format or not. It doesn't

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 --- Comment #13 from David Cook --- Created attachment 120818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120818=edit Bug 28200: [Alternate] Remove unit test using abbreviated format This patch removes the

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-05-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 --- Comment #12 from David Cook --- Maybe this is a good one for a warning in about.pl. I think a bad value in koha-conf.xml will make your Koha fail to start up so you'd find that pretty fast. And a bad ILS-DI value could be

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-05-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 --- Comment #11 from David Cook --- (In reply to Martin Renvoize from comment #10) > I've not read enough of th background to understand why support was dropped > for security reasons in the upstream library? It feels like if

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-05-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 --- Comment #10 from Martin Renvoize --- I've not read enough of th background to understand why support was dropped for security reasons in the upstream library? It feels like if they've disabled it by default for a reason we

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-05-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 Jonathan Druart changed: What|Removed |Added Severity|normal |major

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 --- Comment #9 from David Cook --- If we are going to drop support for the abbreviated format, then we can update this bug to just change the unit test and maybe print a warning in the release notes or something. -- You are

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-05-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-05-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #120035|0 |1 is

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 Jonathan Druart changed: What|Removed |Added Keywords||rel_21_05_candidate --

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-04-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 --- Comment #6 from David Cook --- (In reply to Jonathan Druart from comment #3) > What about dropping support for abbreviated formats? It would be a breaking change for existing libraries. I have quite a few libraries using the

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 --- Comment #4 from Jonathan Druart --- If you disagree with the previous comment you can consider it signed off. kohadev-koha@kohadevbox:/kohadevbox/koha$ prove t/Koha/Middleware/RealIP.t t/Koha/Middleware/RealIP.t .. ok

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 David Cook changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 --- Comment #2 from David Cook --- Ok, I've tested this on koha-testing-docker stretch (libnet-netmask-perl 1.9022-1), and I can confirm that it hasn't broken anything. If someone can test that it fixes the problem on D11, that

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 --- Comment #1 from David Cook --- Created attachment 120035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120035=edit Bug 28200: Add workaround for Net::Netmask abbreviated values This patch adds the shortnet

[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2021-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff -- You are