https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
Fridolin Somers changed:
What|Removed |Added
Resolution|--- |FIXED
Status|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
Bug 28520 depends on bug 28382, which changed state.
Bug 28382 Summary: 'Reserve' should be passed through as transfer reason
appropriately in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28382
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
Jonathan Druart changed:
What|Removed |Added
Keywords|rel_21_05_candidate |
--
You are receiving th
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
Kyle M Hall changed:
What|Removed |Added
Status|Pushed to master|Pushed to stable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
--- Comment #46 from Jonathan Druart ---
Pushed to master for 21.11, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Pushed to master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |Passed QA
--- Comment #45
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
--- Comment #44 from Jonathan Druart ---
Created attachment 122007
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122007&action=edit
Bug 28520: Allow creating a transfer back automatically if a hold is canceled
dur
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
--- Comment #43 from Jonathan Druart ---
Created attachment 122006
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122006&action=edit
Bug 28520: Bring back TransferCancellation reason handling from reverted Bug
1236
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
Jonathan Druart changed:
What|Removed |Added
Attachment #121953|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
--- Comment #41 from Joonas Kylmälä ---
(In reply to Joonas Kylmälä from comment #40)
> (In reply to Martin Renvoize from comment #39)
> > In this case, I do wonder about removing them.. remember, methods can be
> > used by notices t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
--- Comment #40 from Joonas Kylmälä ---
(In reply to Martin Renvoize from comment #39)
> In this case, I do wonder about removing them.. remember, methods can be
> used by notices too.. so the 'from_library' may well have been helpfu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
--- Comment #39 from Martin Renvoize ---
Ack.. that's a pet hate of mine.. that we don't pass through existing
relationships so you have to create them each time if you want to use them (and
add tests too).
In this case, I do wonder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
--- Comment #38 from Joonas Kylmälä ---
(In reply to Jonathan Druart from comment #36)
> (In reply to Jonathan Druart from comment #35)
> > # Failed test 'No tests run for subtest "from_library relation tests"'
> > # at /kohadevb
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
--- Comment #37 from Joonas Kylmälä ---
Created attachment 121985
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121985&action=edit
Bug 28520: Remove tests for removed from_library function
The function was unused
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
--- Comment #36 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #35)
> # Failed test 'No tests run for subtest "from_library relation tests"'
> # at /kohadevbox/koha/t/db_dependent/Koha/Item/Transfer.t line 75.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Failed QA
--- Comment #35
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
Joonas Kylmälä changed:
What|Removed |Added
Status|Signed Off |Passed QA
Depends
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
--- Comment #33 from Joonas Kylmälä ---
Created attachment 121955
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121955&action=edit
Bug 28520: Allow creating a transfer back automatically if a hold is canceled
duri
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
--- Comment #32 from Joonas Kylmälä ---
Created attachment 121954
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121954&action=edit
Bug 28520: Bring back TransferCancellation reason handling from reverted Bug
12362
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
--- Comment #31 from Joonas Kylmälä ---
Created attachment 121953
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121953&action=edit
Bug 28520: Revert "Bug 12362: Reverse transfer upon cancellation"
This reverts co
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
--- Comment #30 from Joonas Kylmälä ---
Created attachment 121952
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121952&action=edit
Bug 28520: Revert "Bug 12362: Cancel transfer with hold cancelation"
This reverts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
Joonas Kylmälä changed:
What|Removed |Added
Attachment #121843|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
Joonas Kylmälä changed:
What|Removed |Added
Status|Patch doesn't apply |Signed Off
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.druart+koha@gmail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
Nick Clemens changed:
What|Removed |Added
Attachment #121722|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
Nick Clemens changed:
What|Removed |Added
Attachment #121721|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
Nick Clemens changed:
What|Removed |Added
Attachment #121720|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
Nick Clemens changed:
What|Removed |Added
Attachment #121719|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
Nick Clemens changed:
What|Removed |Added
Attachment #121718|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
Nick Clemens changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are receiv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
Joonas Kylmälä changed:
What|Removed |Added
Depends on||12362
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
--- Comment #9 from Martin Renvoize ---
But.. this will follow 'ReturnToHome/ReturnToHolding' rather than 'Reverse' the
original transfer.. I suppose that doesn't really matter.
--
You are receiving this mail because:
You are the a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
--- Comment #8 from Joonas Kylmälä ---
(In reply to Martin Renvoize from comment #6)
> Wont this also prompt for return when the reserve hasn't been cancelled?
No. I was supposed to write a better commit message but it got late, and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
--- Comment #7 from Martin Renvoize ---
Ah, I see.. we check for resfound later..
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
--- Comment #6 from Martin Renvoize ---
Wont this also prompt for return when the reserve hasn't been cancelled?
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
__
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
--- Comment #14 from Joonas Kylmälä ---
Created attachment 121712
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121712&action=edit
Bug 28520: Allow creating a transfer back automatically if a hold is canceled
duri
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
--- Comment #13 from Joonas Kylmälä ---
Created attachment 121711
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121711&action=edit
Bug 28520: Bring back TransferCancellation reason handling from reverted Bug
12362
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
--- Comment #12 from Joonas Kylmälä ---
Created attachment 121710
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121710&action=edit
Bug 28520: Revert "Bug 12362: Reverse transfer upon cancellation"
This reverts co
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
--- Comment #11 from Joonas Kylmälä ---
Created attachment 121709
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121709&action=edit
Bug 28520: Revert "Bug 12362: Cancel transfer with hold cancelation"
This reverts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
Joonas Kylmälä changed:
What|Removed |Added
Attachment #121686|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
Joonas Kylmälä changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
--- Comment #4 from Joonas Kylmälä ---
Created attachment 121691
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121691&action=edit
Bug 28520: Don't create a new transfer for a lost item
We need to pass 'replace' t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
--- Comment #3 from Joonas Kylmälä ---
Created attachment 121690
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121690&action=edit
Bug 28520: Allow creating a new transit request for item with cancelled
transfer
S
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
--- Comment #2 from Joonas Kylmälä ---
Created attachment 121689
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121689&action=edit
Bug 28520: Don't allow simply cancelling a transfer
If we just cancel a transfer i
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
Martin Renvoize changed:
What|Removed |Added
Blocks||22160
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
--- Comment #1 from Martin Renvoize ---
Created attachment 121686
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121686&action=edit
Bug 28520: Update detail to display cancelled in transit transfers
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
Martin Renvoize changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun |joonas.kylm...@helsinki.fi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
Martin Renvoize changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--- Comment #2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
Joonas Kylmälä changed:
What|Removed |Added
Keywords||rel_21_05_candidate
--
Yo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
--- Comment #15 from Joonas Kylmälä ---
(In reply to Martin Renvoize from comment #9)
> But.. this will follow 'ReturnToHome/ReturnToHolding' rather than 'Reverse'
> the original transfer.. I suppose that doesn't really matter.
That
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
Martin Renvoize changed:
What|Removed |Added
Attachment #121712|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
Martin Renvoize changed:
What|Removed |Added
Attachment #121711|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
Martin Renvoize changed:
What|Removed |Added
Attachment #121710|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
Martin Renvoize changed:
What|Removed |Added
Attachment #121709|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
Martin Renvoize changed:
What|Removed |Added
Attachment #121708|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
Martin Renvoize changed:
What|Removed |Added
Blocks|22160 |
Referenced Bugs:
https
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
Martin Renvoize changed:
What|Removed |Added
Blocks||28527
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
--- Comment #16 from Martin Renvoize ---
Adding 28382 as a dependency, else we won't catch the case where the transfer
was actioned by branchtransfers.
--
You are receiving this mail because:
You are the assignee for the bug.
You a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
Martin Renvoize changed:
What|Removed |Added
Depends on||28382
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520
Joonas Kylmälä changed:
What|Removed |Added
Attachment #121689|0 |1
is obsolete|
61 matches
Mail list logo