https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561
Marcel de Rooy changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561
Marcel de Rooy changed:
What|Removed |Added
Status|NEW |ASSIGNED
--
You are recei
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561
--- Comment #1 from Marcel de Rooy ---
This query in opac/opac-shelves.pl contains the crux:
my $contents = $shelf->get_contents->search(
{},
{
prefetch => [ { 'biblion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561
--- Comment #2 from Marcel de Rooy ---
The code in opac-shelves is far from optimal. The prefetch in the query selects
biblio, biblioitems and items. But in the loop starting at L308 we are calling
GetBiblioData, GetMarcBiblio, Bibli
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561
Marcel de Rooy changed:
What|Removed |Added
Patch complexity|--- |Small patch
St
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561
--- Comment #3 from Marcel de Rooy ---
Created attachment 121912
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121912&action=edit
Bug 28561: Resolve DBIx's Unable to collapse results-warning
[WARN] DBIx::Class::R
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561
--- Comment #4 from Marcel de Rooy ---
Created attachment 121913
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121913&action=edit
Bug 28561: Fix noisy warning about $direction too
Use of uninitialized value $dire
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561
--- Comment #5 from Marcel de Rooy ---
NOTE:
Although this patch significantly reduces the number of warnings on the
collapse. I still had some when I sorted on title too. It seems that it does
not occur on the other fields as author
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561
Marcel de Rooy changed:
What|Removed |Added
Status|Needs Signoff |In Discussion
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561
Marcel de Rooy changed:
What|Removed |Added
CC||jonathan.druart+koha@gmail.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561
--- Comment #7 from Jonathan Druart ---
Created attachment 122119
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122119&action=edit
[ALTERNATIVE PATCH] Bug 28561: Remove DBIC warning in opac-shelves
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561
--- Comment #8 from Jonathan Druart ---
We don't actually need to prefetch as we are only using the biblionumber.
Using join and distinct seems to remove the warning and produce the same
results.
--
You are receiving this mail beca
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561
Marcel de Rooy changed:
What|Removed |Added
Status|In Discussion |Signed Off
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561
--- Comment #9 from Marcel de Rooy ---
Created attachment 122215
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122215&action=edit
Bug 28561: Remove DBIC warning in opac-shelves
Signed-off-by: Marcel de Rooy
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561
Marcel de Rooy changed:
What|Removed |Added
Attachment #121912|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561
Marcel de Rooy changed:
What|Removed |Added
Attachment #122119|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561
--- Comment #10 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #8)
> We don't actually need to prefetch as we are only using the biblionumber.
> Using join and distinct seems to remove the warning and produce the s
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561
Nick Clemens changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are receiv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561
Nick Clemens changed:
What|Removed |Added
Attachment #121913|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561
Nick Clemens changed:
What|Removed |Added
Attachment #122215|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561
Nick Clemens changed:
What|Removed |Added
CC||n...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Pushed to master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561
--- Comment #13 from Jonathan Druart ---
Pushed to master for 21.11, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561
Kyle M Hall changed:
What|Removed |Added
Status|Pushed to master|Pushed to stable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561
Fridolin Somers changed:
What|Removed |Added
Status|Pushed to stable|Pushed to oldstable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561
Victor Grousset/tuxayo changed:
What|Removed |Added
Status|Pushed to oldstable |RESOLVED
R
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561
Jonathan Druart changed:
What|Removed |Added
Blocks||36914
Referenced Bugs:
28 matches
Mail list logo