[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Martin Renvoize changed: What|Removed |Added Text to go in the||This patch simplifies and

[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Jonathan Druart changed: What|Removed |Added Keywords|additional_work_needed | -- You are receiving

[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Bug 28572 depends on bug 28570, which changed state. Bug 28570 Summary: bor_issues_top.pl using a /tmp file to log debug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28570 What|Removed

[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Kyle M Hall changed: What|Removed |Added Resolution|--- |FIXED

[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Bug 28572 depends on bug 28591, which changed state. Bug 28591 Summary: debug passed to get_template_and_user but not used https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28591 What|Removed

[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Bug 28572 depends on bug 28590, which changed state. Bug 28590 Summary: get_shelves_userenv and set_shelves_userenv not used https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28590 What|Removed

[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #31 from Jonathan Druart --- c2fb056d7dc Bug 28572: Set missing __LOG_DIR__ variable in zebra_config.pl 3d1a92b6e1c Bug 28572: Fix Search.t 438cfbe1fc3 Bug 28572: Fix misc/admin/koha-preferences Pushed to master. --

[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Jonathan Druart changed: What|Removed |Added Attachment #122304|0 |1 is obsolete|

[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Tomás Cohen Arazi changed: What|Removed |Added Blocks||28615 Referenced

[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #29 from Tomás Cohen Arazi --- Created attachment 122304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122304=edit Bug 28572: Avoid useless warnings There are too many warnings about uninitialized

[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #28 from Tomás Cohen Arazi --- (In reply to Tomás Cohen Arazi from comment #27) > Ok, Search.t got too noisy. It is because of undefined stuffs. It can be > trivially fixed, but I also noticed that some warns that got

[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #27 from Tomás Cohen Arazi --- Ok, Search.t got too noisy. It is because of undefined stuffs. It can be trivially fixed, but I also noticed that some warns that got replaced by calls to the logger, got the if $DEBUG;

[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #26 from Tomás Cohen Arazi --- Created attachment 122303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122303=edit Bug 28572: Set missing __LOG_DIR__ variable in zebra_config.pl This patch makes

[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Jonathan Druart changed: What|Removed |Added Keywords|rel_21_11_candidate |additional_work_needed

[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #24 from Jonathan Druart --- Created attachment 122291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122291=edit Bug 28572: Fix Search.t -- You are receiving this mail because: You are watching all

[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #23 from Jonathan Druart --- Created attachment 122290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122290=edit Bug 28572: Fix misc/admin/koha-preferences -- You are receiving this mail because:

[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #22 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Jonathan Druart changed: What|Removed |Added Version(s)||21.11.00 released

[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #21 from Jonathan Druart --- Second patch will be squashed when pushed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au ---

[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Jonathan Druart changed: What|Removed |Added Blocks||28606 Referenced Bugs:

[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Marcel de Rooy changed: What|Removed |Added Attachment #122216|0 |1 is obsolete|

[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Marcel de Rooy changed: What|Removed |Added Attachment #122147|0 |1 is obsolete|

[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Signed Off -- You are

[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #17 from Jonathan Druart --- (In reply to Jonathan Druart from comment #15) > (In reply to Marcel de Rooy from comment #9) > > -BEGIN { > > -$DEBUG = ($ENV{DEBUG}) ? 1 : 0; > > -} > > > > We still have other cases

[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #16 from Jonathan Druart --- Created attachment 122216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122216=edit Bug 28572: Replace missing occurrence in misc/admin/koha-preferences -- You are

[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Jonathan Druart changed: What|Removed |Added Depends on||28590 --- Comment #15

[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #14 from Marcel de Rooy --- git grep "C4::Debug" misc/admin/koha-preferences:use C4::Debug; misc/admin/koha-preferences:print STDERR $message . "\n" if ( $C4::Debug::debug ); -- You are receiving this mail because:

[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #13 from Marcel de Rooy --- -BEGIN { -$DEBUG = ($ENV{DEBUG}) ? 1 : 0; -} We still have other cases of using $ENV{DEBUG} ? What about them? -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #12 from Marcel de Rooy --- More cases of the former too -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #11 from Marcel de Rooy --- -$debug and warn "Error ExportFramework $@\n"; +Koha::Logger->get->warn("Error ExportFramework $@"); Warn instead of debug ? -- You are receiving this mail

[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #10 from Marcel de Rooy --- sub get_shelves_userenv { my $active; unless ($active = $context->{userenv}->{$context->{activeuser}}) { $debug and warn "get_shelves_userenv cannot retrieve

[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #9

[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #8 from Martin Renvoize --- No regressions found.. I went through the patches inspecting what had been removed/replaced and I agree with all the decisions Jonathan made.. be great to get a second opinion from QA, but I

[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment

[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Martin Renvoize changed: What|Removed |Added Attachment #122118|0 |1 is obsolete|

[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Jonathan Druart changed: What|Removed |Added Keywords||rel_21_11_candidate --

[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #5 from Jonathan Druart --- Created attachment 122118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122118=edit Bug 28572: Remove C4::Debug We are using Koha::Logger when it makes sense to keep the

[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You

[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Jonathan Druart changed: What|Removed |Added Depends on||28591, 28570 Referenced

[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Jonathan Druart changed: What|Removed |Added Status|In Discussion |ASSIGNED -- You are

[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #4 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #0) > Should not we replace C4::Debug (and all "$debug && warn" statements) with > Koha::Logger->debug? +1 -- You are receiving this mail

[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #3 from Kyle M Hall --- (In reply to Jonathan Druart from comment #0) > Should not we replace C4::Debug (and all "$debug && warn" statements) with > Koha::Logger->debug? +1 -- You are receiving this mail because: You

[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #2 from Martin Renvoize --- +1, I love this idea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #1 from Marcel de Rooy --- Great idea. Probably we could miss a lot of such statements too. Remove instead of replace where appropriate? -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Jonathan Druart changed: What|Removed |Added CC|