[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in

2021-11-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 Victor Grousset/tuxayo changed: What|Removed |Added Resolution|--- |FIXED

[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in

2021-10-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 Jonathan Druart changed: What|Removed |Added Keywords|rel_21_05_candidate | -- You are receiving th

[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.c

[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in

2021-07-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com

[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in

2021-07-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 David Cook changed: What|Removed |Added Blocks||28735 -- You are receiving th

[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in

2021-07-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 --- Comment #28 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in

2021-07-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 Jonathan Druart changed: What|Removed |Added Version(s)||21.11.00 released

[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in

2021-07-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 --- Comment #27 from David Cook --- (In reply to David Cook from comment #26) > (In reply to David Cook from comment #21) > > There's another potential SCO regression I'll be looking into later today as > > well... need to confirm th

[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in

2021-07-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 --- Comment #26 from David Cook --- (In reply to David Cook from comment #21) > There's another potential SCO regression I'll be looking into later today as > well... need to confirm that it's a problem in master first though. The o

[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in

2021-07-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 David Cook changed: What|Removed |Added Attachment #122773|0 |1 is obsolete|

[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in

2021-07-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 David Cook changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receivin

[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in

2021-07-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 --- Comment #24 from David Cook --- testing 1 commit(s) (applied to 3748efc 'ab Bug 28731: (bug 17600 follow-up) I') Processing files before patches |>| 1 / 1 (100.00%) Processing files after patches |===

[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in

2021-07-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 --- Comment #23 from David Cook --- Test plan: 0. Don't apply patch yet 1. Go to http://localhost:8080/cgi-bin/koha/sco/sco-main.pl 2. Note that you are prompted with a regular Koha login screen 3. Apply patch 4. koha-plack --restar

[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in

2021-07-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 --- Comment #22 from David Cook --- Ok finally getting to this. It would've been good to have a test plan but I'll whip one up. -- You are receiving this mail because: You are watching all bug changes. _

[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in

2021-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 --- Comment #20 from David Cook --- I am planning to QA this. Ran out of time yesterday. Should be able to today. -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in

2021-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 --- Comment #21 from David Cook --- There's another potential SCO regression I'll be looking into later today as well... need to confirm that it's a problem in master first though. -- You are receiving this mail because: You are wa

[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in

2021-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 Jonathan Druart changed: What|Removed |Added QA Contact|m.de.r...@rijksmuseum.nl|dc...@prosentient.com.au

[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 Oliver Behnke changed: What|Removed |Added CC||oliver.beh...@aei.mpg.de --

[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in

2021-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Signed Off --- Comment #1

[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in

2021-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in

2021-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 Marcel de Rooy changed: What|Removed |Added Attachment #122617|0 |1 is obsolete|

[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in

2021-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch St

[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in

2021-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 Jonathan Druart changed: What|Removed |Added Assignee|dc...@prosentient.com.au|jonathan.druart+koha@gmail

[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in

2021-07-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 --- Comment #16 from David Cook --- At this point, since this is affecting production instances, I think just getting any fix in is probably better than "the best fix", so let's just go ahead with this one and not delay. -- You are

[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in

2021-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 Jonathan Druart changed: What|Removed |Added Keywords||rel_21_05_candidate --- C

[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in

2021-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 --- Comment #14 from David Cook --- (In reply to Marcel de Rooy from comment #13) > (In reply to David Cook from comment #11) > > (In reply to Marcel de Rooy from comment #10) > > > Are we here in a self checkout context? > > > > Y

[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in

2021-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 --- Comment #13 from Marcel de Rooy --- (In reply to David Cook from comment #11) > (In reply to Marcel de Rooy from comment #10) > > Are we here in a self checkout context? > > Yes. Hahaha. I was aware of that. But we need to che

[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in

2021-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 --- Comment #12 from David Cook --- Ah but that koha_login_context check *plus* Jonathan's checking the userid against the AutoSelfCheckID.. that would probably be good enough although AutoSelfCheckAllowed would probably be better co

[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in

2021-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 --- Comment #11 from David Cook --- (In reply to Marcel de Rooy from comment #10) > || ( C4::Context->preference('AutoSelfCheckID') > && $q_userid eq C4::Context->preference('AutoSelfCheckID') ) > > Feels to me that this wou

[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in

2021-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 --- Comment #10 from Marcel de Rooy --- || ( C4::Context->preference('AutoSelfCheckID') && $q_userid eq C4::Context->preference('AutoSelfCheckID') ) Feels to me that this would need some additional checks? Like AutoSelfCheck

[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in

2021-07-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 --- Comment #9 from David Cook --- (In reply to Jonathan Druart from comment #8) > This patch is just adding more confusion to C4::Auth and make it even more > fragile. Better alternative welcomed! I do have an idea, but it would re

[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in

2021-07-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 Jonathan Druart changed: What|Removed |Added Status|NEW |ASSIGNED Assign

[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in

2021-07-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 --- Comment #7 from Jonathan Druart --- Created attachment 122617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122617&action=edit Bug 28660: (bug 21325 follow-up) Fix auto self check -- You are receiving this m

[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in

2021-07-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -

[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in

2021-07-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 Jonathan Druart changed: What|Removed |Added Depends on||21325 Version|

[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in

2021-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 David Cook changed: What|Removed |Added Severity|critical|blocker -- You are receiving

[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in

2021-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 David Cook changed: What|Removed |Added Severity|minor |critical --- Comment #5 from D

[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in

2021-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 --- Comment #4 from David Cook --- (In reply to Jeremiah from comment #3) > I originally thought it was a support request too, however as I mentioned > above, I tested different versions of Koha on different systems and found > that

[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in

2021-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 --- Comment #3 from Jeremiah --- I originally thought it was a support request too, however as I mentioned above, I tested different versions of Koha on different systems and found that any Koha system running 21.05 were unable to us

[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in

2021-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- C

[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in

2021-07-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 --- Comment #1 from Jeremiah --- I have tested this same feature in multiple Koha servers that are running 21.05 and they are having the same issue. When testing this with Koha servers running 20.xx it works as described. -- You a

[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in

2021-07-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 Jeremiah changed: What|Removed |Added Severity|trivial |minor -- You are receiving this