https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
Marcel de Rooy changed:
What|Removed |Added
Resolution|--- |DUPLICATE
Stat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
--- Comment #45 from Jonathan Druart ---
*** Bug 29192 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-b
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
Jonathan Druart changed:
What|Removed |Added
Keywords|rel_21_11_candidate |
--- Comment #44 from Jon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
--- Comment #43 from Martin Renvoize ---
OK.. I think for this bug description.. we should either properly unbless
everything in the object or throw an exception for cases where unbless is
likely to pass back unexpected nested object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
--- Comment #42 from Jonathan Druart ---
Having a Koha::Object sent to logaction would let us flexibility if we want to
modify the behaviour later :)
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
--- Comment #41 from Martin Renvoize ---
OK, so logaction is called 203 times across the codebase whilst unblessed is
called 639. So inspecting logaction has that advantage... but I feel like
we're likely making mistakes/assumptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
--- Comment #40 from Martin Renvoize ---
(In reply to Marcel de Rooy from comment #39)
> (In reply to Jonathan Druart from comment #20)
> >
> > kidclamp> should we just address this per case? do we need a global
> > solution? i.e. w
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
--- Comment #39 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #20)
>
> kidclamp> should we just address this per case? do we need a global
> solution? i.e. we know if we touch an object variable we can introduce
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
--- Comment #38 from Marcel de Rooy ---
+$infos = $infos->get_from_storage
+ if ref($infos) !~ /HASH|ARRAY/ && $infos->isa('Koha::Object');
Hmm. Shouldnt we make the caller responsible for whatever he wants to log?
This fee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
--- Comment #36 from Jonathan Druart ---
(In reply to Martin Renvoize from comment #31)
> Created attachment 126902 [details] [review]
> Bug 28700: Throw exception on dirty columns for unblessed
>
> This patch updates the unblessed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
--- Comment #35 from Jonathan Druart ---
(In reply to Martin Renvoize from comment #34)
> Also.. when is logaction ever actually passed a Koha::Object as the $infos
> param... as far as I can tell the call to 'unblessed' is always ca
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
--- Comment #34 from Martin Renvoize ---
Also.. when is logaction ever actually passed a Koha::Object as the $infos
param... as far as I can tell the call to 'unblessed' is always called before
the call to logaction.. thus I'm not su
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
--- Comment #33 from Martin Renvoize ---
I should note.. my final patch there is an alternative to all that preceded
it.. the idea being that we throw an exception and thus force developers to
consider their unblessed uses and call g
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
--- Comment #32 from Jonathan Druart ---
If we are here to fix the log verbosity I would prefer to not modify
->unblessed behaviour.
If we are here to fix ->unblessed behaviour, then... why do we want to fix it?
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
--- Comment #31 from Martin Renvoize ---
Created attachment 126902
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126902&action=edit
Bug 28700: Throw exception on dirty columns for unblessed
This patch updates the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
--- Comment #30 from Martin Renvoize ---
OK, New thought... how about we look for dirty columns and throw an exception
if unblessed is called when any exist?
That way we're catching cases where such oddities may exist and telling th
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
--- Comment #29 from Martin Renvoize ---
I'm coming round to Tomas's thinking.. why not just use TO_JSON...
Let me justify that.. for stringification, TO_JSON already handles the majority
of cases.. we look at the column definitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
--- Comment #28 from Andrew Nugged ---
Jonathan:
yours (and my patch over it) solution is separated from Petro's one (so Petro
should re-do sending to logs refs/objects instead of concatenated strings),
but this solution works al
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
--- Comment #27 from Andrew Nugged ---
Btw, 2 Petro: I found with unblessed another "reference" happens when saving to
action_logs: "ref to SCALAR" comes when in timestamp there is =
\"current_timestamp" value (slash here means Perl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
--- Comment #26 from Andrew Nugged ---
Tomás: switching to JSON will save logs messages ("dumps") well.
JSON in 'action_logs' also ok for me,
Main "bug" (unexpected behavior) it won't solve but will solve LOGs crazy
growth.
I mea
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
--- Comment #25 from Tomás Cohen Arazi ---
What about using ->TO_JSON instead of ->unblessed? It is a bit smarter,
specially regarding dates.
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
--- Comment #24 from Nick Clemens ---
I still prefer making the code handle the necessary objects in each case.
If we must have a central solution I would side with Martin/Kyle and suggest
stringifying each value in the object.
In
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
--- Comment #23 from Jonathan Druart ---
We have bug 24190 that will be part of 21.11, and it will store acquisition
logs using json.
I think we MUST fix this one before 21.11.00 is released, or it will be a mess
in the logs dependin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
Andrew Nugged changed:
What|Removed |Added
Attachment #126082|1 |0
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
Andrew Nugged changed:
What|Removed |Added
Attachment #126082|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
--- Comment #21 from Andrew Nugged ---
(In reply to Jonathan Druart from comment #17)
> Created attachment 126082 [details] [review]
This is beside main discussion (I still not yet formed up my opinion on this),
but to fix last patc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
Jonathan Druart changed:
What|Removed |Added
Status|Needs Signoff |In Discussion
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
Peter Vashchuk changed:
What|Removed |Added
Attachment #122797|1 |0
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
Peter Vashchuk changed:
What|Removed |Added
Attachment #126181|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
Peter Vashchuk changed:
What|Removed |Added
Attachment #122797|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
Peter Vashchuk changed:
What|Removed |Added
Status|In Discussion |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
Jonathan Druart changed:
What|Removed |Added
Keywords||rel_21_11_candidate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |In Discussion
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
--- Comment #17 from Jonathan Druart ---
Created attachment 126082
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126082&action=edit
Bug 28700: Get from storage before log actions
To make sure we have logging the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
Jonathan Druart changed:
What|Removed |Added
See Also||https://bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
--- Comment #16 from Jonathan Druart ---
(In reply to Martin Renvoize from comment #15)
> Thus, my proposal would be
>
> for my $k (keys %res) {
> $res{$k} = "$res{$k}";
> }
What's the cost of that? What's the side-effects (casti
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
--- Comment #15 from Martin Renvoize ---
I think we are perhaps trying to solve two problems here when we should be
doing different things in different situations.
I don't think we should implicitly call get_from_storage/discard_cha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
Jonathan Druart changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
--- Comment #14 from Jonathan Druart ---
(In reply to Tomás Cohen Arazi from comment #12)
> (In reply to Jonathan Druart from comment #11)
> > Tomas, which means you agree with comment 5?
>
> Yes, but locally. Not implicitly in unbl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
--- Comment #13 from Jonathan Druart ---
(In reply to Tomás Cohen Arazi from comment #12)
> (In reply to Jonathan Druart from comment #11)
> > Tomas, which means you agree with comment 5?
>
> Yes, but locally. Not implicitly in unbl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
--- Comment #12 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #11)
> Tomas, which means you agree with comment 5?
Yes, but locally. Not implicitly in unblessed.
--
You are receiving this mail because:
You ar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
--- Comment #11 from Jonathan Druart ---
Tomas, which means you agree with comment 5?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
--- Comment #10 from Tomás Cohen Arazi ---
If we do
$self->attribute( dt_from_string );
the 'attribute' will obviously have a DateTime in it, as Koha::Object-derived
objects are just blessed hashrefs. We could be doing any weird
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
Tomás Cohen Arazi changed:
What|Removed |Added
CC||k...@bywatersolutions.co
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
Tomás Cohen Arazi changed:
What|Removed |Added
CC||tomasco...@gmail.com
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
--- Comment #9 from Jonathan Druart ---
(In reply to Andrew Nugged from comment #6)
> will it lead sometimes to +1 SQL request which is not so fast... but this
> method used intensively all around?
It will do a fetch, but it's what
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
--- Comment #8 from Jonathan Druart ---
(In reply to Andrew Nugged from comment #6)
> will it lead sometimes to +1 SQL request which is not so fast... but this
> method used intensively all around?
I will do a fetch, but it's what w
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
Jonathan Druart changed:
What|Removed |Added
CC||n...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
Jonathan Druart changed:
What|Removed |Added
See Also||https://bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
--- Comment #6 from Andrew Nugged ---
will it lead sometimes to +1 SQL request which is not so fast... but this
method used intensively all around?
--
You are receiving this mail because:
You are watching all bug changes.
_
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.druart+koha@gmail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
Martin Renvoize changed:
What|Removed |Added
CC||martin.renvoize@ptfs-europ
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
Peter Vashchuk changed:
What|Removed |Added
Attachment #122776|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
Peter Vashchuk changed:
What|Removed |Added
Attachment #122770|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
Peter Vashchuk changed:
What|Removed |Added
CC||stalkern...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
Andrew Nugged changed:
What|Removed |Added
CC||nug...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
--- Comment #1 from Peter Vashchuk ---
Created attachment 122770
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122770&action=edit
Bug 28700 - unblessed in Object.pm has blessed values in some cases
This "unblesse
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
Peter Vashchuk changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
You are
59 matches
Mail list logo
