https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734
Bug 28734 depends on bug 27268, which changed state.
Bug 27268 Summary: Move C4::Biblio::GetMarcNotes to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27268
What|Removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734
Nick Clemens changed:
What|Removed |Added
Blocks||29970
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734
Jonathan Druart changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734
Pablo AB changed:
What|Removed |Added
CC||pablo.bian...@gmail.com
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734
--- Comment #30 from Jonathan Druart ---
Follow-up pushed to master.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734
--- Comment #29 from Jonathan Druart ---
Created attachment 126052
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126052=edit
Bug 28734: Clear cache to prevent random failures
MSS is modified, we must clear the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734
Kyle M Hall changed:
What|Removed |Added
Resolution|--- |FIXED
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734
--- Comment #27 from Jonathan Druart ---
Pushed to master for 21.11, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734
Jonathan Druart changed:
What|Removed |Added
Version(s)||21.11.00
released
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734
--- Comment #26 from Aleisha Amohia ---
(In reply to Jonathan Druart from comment #24)
> I had to reintroduce the C4::Koha prefix for xml_escape. That's not expected
> but I failed to understand what's going on.
>
This was very
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734
Jonathan Druart changed:
What|Removed |Added
Attachment #125724|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734
--- Comment #24 from Jonathan Druart ---
I had to reintroduce the C4::Koha prefix for xml_escape. That's not expected
but I failed to understand what's going on.
(In reply to Joonas Kylmälä from comment #22)
> (In reply to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734
Jonathan Druart changed:
What|Removed |Added
Attachment #125660|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734
--- Comment #22 from Joonas Kylmälä ---
(In reply to Jonathan Druart from comment #17)
> 1.
> -use Koha::AuthorisedValueCategories;
> -use Koha::AuthorisedValues;
> +use Koha::AuthorisedValueCategory;
> +use Koha::AuthorisedValue;
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734
--- Comment #21 from Jonathan Druart ---
Patches will be squashed when pushed.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734
--- Comment #20 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #17)
> 2. I first got the tests fail:
Hum, cannot longer recreate that.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734
--- Comment #19 from Jonathan Druart ---
Created attachment 125687
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125687=edit
Bug 28734: Remove unadvertised changes
1. Using $frameworkcode instead of the default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734
--- Comment #18 from Jonathan Druart ---
About 3. actually GetAuthorisedValueDesc does not case about $framework (it
does not do anything with it). To prevent confusion we should not modify it.
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734
Jonathan Druart changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734
--- Comment #16 from Joonas Kylmälä ---
Looks good to me, passing QA. Aleisha, btw, please in the future don't add
unrelated changes to the same commit, ("xml_escape" -> "C4::Koha::xml_escape"),
it takes more reviewer's time when
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734
--- Comment #15 from Joonas Kylmälä ---
Created attachment 125663
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125663=edit
Bug 28734: (QA follow-up) Update documentation about function usage
We are now using
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734
--- Comment #14 from Joonas Kylmälä ---
Created attachment 125662
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125662=edit
Bug 28734: (QA follow-up) Fix test imports and readability
Signed-off-by: Joonas
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734
--- Comment #13 from Joonas Kylmälä ---
Created attachment 125661
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125661=edit
Bug 28734: (follow-up) Use transformMARCXML4XSLT and tests
Confirm the following tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734
Joonas Kylmälä changed:
What|Removed |Added
Attachment #125634|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734
Joonas Kylmälä changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734
Joonas Kylmälä changed:
What|Removed |Added
CC||joonas.kylm...@iki.fi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734
David Nind changed:
What|Removed |Added
Attachment #125575|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734
David Nind changed:
What|Removed |Added
Attachment #125574|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734
Aleisha Amohia changed:
What|Removed |Added
Summary|Koha::Biblio->get_marc_note
30 matches
Mail list logo
