[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Andrew Fuerste-Henry changed: What|Removed |Added Version(s)|22.05.00,21.11.03

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 --- Comment #49 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Fridolin Somers changed: What|Removed |Added Status|Passed QA |Pushed to master

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Martin Renvoize changed: What|Removed |Added Attachment #129916|0 |1 is obsolete|

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Martin Renvoize changed: What|Removed |Added Attachment #129915|0 |1 is obsolete|

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Jonathan Druart changed: What|Removed |Added Blocks|29660 | Referenced Bugs:

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 --- Comment #45 from Nick Clemens --- Created attachment 129916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129916=edit Bug 29043: Don't fetch items if when are not on the 'Place a hold on' form Signed-off-by:

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Nick Clemens changed: What|Removed |Added Attachment #129820|0 |1 is obsolete|

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 --- Comment #43 from Jonathan Druart --- Created attachment 129821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129821=edit Bug 29043: Don't fetch items if when are not on the 'Place a hold on' form -- You are

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Jonathan Druart changed: What|Removed |Added Attachment #129498|0 |1 is obsolete|

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Jonathan Druart changed: What|Removed |Added Blocks||29058 Referenced Bugs:

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Jonathan Druart changed: What|Removed |Added Assignee|n...@bywatersolutions.com

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 --- Comment #41 from Jonathan Druart --- @ reserve/request.pl:440 @ if ( ( $findborrower && $borrowernumber_hold || $findclub && $club_hold ) } }; +if ( $club_hold or $borrowernumber_hold ) {

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Jonathan Druart changed: What|Removed |Added Attachment #129530|0 |1 is obsolete|

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 --- Comment #39 from Jonathan Druart --- Created attachment 129530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129530=edit Bug 29043: Don't fetch items if when are not on the "Place a hold on" form -- You are

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 --- Comment #38 from Jonathan Druart --- Rebased and fixed a bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 --- Comment #37 from Jonathan Druart --- @ reserve/request.pl:199 @ $template->param( multi_hold => $multi_hold, ); +# If we are coming from the search result and only 1 is selected +$biblionumber ||= $biblionumbers[0] unless

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Jonathan Druart changed: What|Removed |Added Attachment #128971|0 |1 is obsolete|

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 --- Comment #35 from Jonathan Druart --- Nick, will this alternative patch answers your needs? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Jonathan Druart changed: What|Removed |Added Blocks||29660 Referenced Bugs:

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 --- Comment #34 from Jonathan Druart --- @ reserve/request.pl:201 @ $template->param( multi_hold => $multi_hold, ); +# If we are coming from the search result and only 1 is selected +$biblionumber ||= $biblionumbers[0] unless

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 --- Comment #32 from Jonathan Druart --- Created attachment 129200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129200=edit Bug 29043: [ALTERNATIVE PATCH] Don't fetch biblios info unless a patron is picked If

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 --- Comment #31 from Nick Clemens --- Created attachment 128973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128973=edit Bug 29043: Remaining bug is the incorrect title "Place a hold on No title" This version

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 --- Comment #30 from Nick Clemens --- Created attachment 128972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128972=edit Bug 29043: Prune dead code Remove sort_borrowerlist as it was not used Remove "time" for

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Nick Clemens changed: What|Removed |Added Attachment #128474|0 |1 is obsolete|

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply ---

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 --- Comment #27 from Nick Clemens --- Created attachment 128476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128476=edit Bug 29043: Remaining bug is the incorrect title "Place a hold on No title" This version

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 --- Comment #26 from Nick Clemens --- Created attachment 128475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128475=edit Bug 29043: Prune dead code Remove sort_borrowerlist as it was not used Remove "time" for

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Nick Clemens changed: What|Removed |Added Attachment #128421|0 |1 is obsolete|

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Samu Heiskanen changed: What|Removed |Added Attachment #128340|0 |1 is obsolete|

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Samu Heiskanen changed: What|Removed |Added Attachment #127732|0 |1 is obsolete|

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Samu Heiskanen changed: What|Removed |Added Attachment #127731|0 |1 is obsolete|

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 --- Comment #21 from Samu Heiskanen --- Ok, I'll do that. Thx Katrin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 --- Comment #20 from Katrin Fischer --- Hi Samu, do you want to sign-off on the first 2 patches in combination with yours? Then we could ask Nick to sign-off on yours and move to Signed off. -- You are receiving this mail because:

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 --- Comment #19 from Samu Heiskanen --- Sorry, I got a little carried away with this bug. But original assignee, Nick please continue from here. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Samu Heiskanen changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Samu Heiskanen changed: What|Removed |Added Attachment #128339|0 |1 is obsolete|

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Samu Heiskanen changed: What|Removed |Added Attachment #128338|0 |1 is obsolete|

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Samu Heiskanen changed: What|Removed |Added Attachment #128254|0 |1 is obsolete|

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Samu Heiskanen changed: What|Removed |Added Attachment #128336|0 |1 is obsolete|

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Samu Heiskanen changed: What|Removed |Added Attachment #128309|0 |1 is obsolete|

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 --- Comment #13 from Samu Heiskanen --- Created attachment 128309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128309=edit Bug 29043: Remaining bug is the incorrect title "Place a hold on No title" I tried to

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Lari Taskula changed: What|Removed |Added CC||lari.task...@hypernova.fi

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 --- Comment #11 from Samu Heiskanen --- Created attachment 128254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128254=edit Here's the fixed patch for testing. -- You are receiving this mail because: You are

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 --- Comment #10 from Samu Heiskanen --- If you move the line: 323my $biblio = Koha::Biblios->find( $biblionumber ); just before the foreach loop and add the line: biblio => $biblio, to: 738 # display infos 739

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #9

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Samu Heiskanen changed: What|Removed |Added CC|

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Katrin Fischer changed: What|Removed |Added Attachment #125060|0 |1 is obsolete|

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Fridolin Somers changed: What|Removed |Added CC|

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 --- Comment #6 from Nick Clemens --- Created attachment 127732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127732=edit Bug 29043: Prune dead code Remove sort_borrowerlist as it was not used Remove "time" for

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 --- Comment #5 from Nick Clemens --- Created attachment 127731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127731=edit Bug 29043: Don't load items unless a p[atron has been chosen on request.pl This patch

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Marcel de Rooy changed: What|Removed |Added Summary|Items are prcoessed but not |Items are processed but