https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062
Fridolin Somers changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062
Kyle M Hall changed:
What|Removed |Added
Version(s)|21.11.00|21.11.00,21.05.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062
--- Comment #16 from Jonathan Druart ---
Pushed to master for 21.11, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Pushed to master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062
--- Comment #15 from Jonathan Druart ---
(In reply to Nick Clemens from comment #14)
> Created attachment 125879 [details] [review]
> Bug 29062: Unit tests
Thanks!
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062
--- Comment #14 from Nick Clemens ---
Created attachment 125879
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125879=edit
Bug 29062: Unit tests
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062
Nick Clemens changed:
What|Removed |Added
Status|Failed QA |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062
--- Comment #13 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #12)
> Missing test coverage.
I was permissive here for the current lack of tests of SendCirculationAlert.
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062
--- Comment #11 from Marcel de Rooy ---
Created attachment 125809
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125809=edit
Bug 29062: (QA follow-up) Add comment
Wrapped it in a TODO ;)
Signed-off-by: Marcel de
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062
Marcel de Rooy changed:
What|Removed |Added
Attachment #125749|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062
Marcel de Rooy changed:
What|Removed |Added
Attachment #125154|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062
Marcel de Rooy changed:
What|Removed |Added
Patch complexity|--- |Small patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062
Nick Clemens changed:
What|Removed |Added
Attachment #125712|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062
Nick Clemens changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062
--- Comment #7 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #6)
> +$issues_id = $item->{itemnumber};
>
> I am having serious doubts about that change ;)
Especially the way it reads btw. Maybe find a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062
--- Comment #5 from Nick Clemens ---
(In reply to Marcel de Rooy from comment #3)
> This might be hard to find another occurrence.
> But look at this code in SendCirculationAlert
> This should no longer work.
Fixed
>
> How do you
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062
--- Comment #4 from Nick Clemens ---
Created attachment 125712
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125712=edit
Bug 29062: (follow-up) Adjust SendCirculationAlert
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062
Nick Clemens changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062
Lisette Scheer changed:
What|Removed |Added
CC||lisettesla...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062
Lucas Gass changed:
What|Removed |Added
Attachment #125129|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062
Lucas Gass changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062
Nick Clemens changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062
--- Comment #1 from Nick Clemens ---
Created attachment 125129
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125129=edit
Bug 29062: Use primary key issued_id to fetch old_issues for letters
The code currently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062
Nick Clemens changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062
Andrew Fuerste-Henry changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062
Lucas Gass changed:
What|Removed |Added
Depends on||12224
Referenced Bugs:
29 matches
Mail list logo
