https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066
Kyle M Hall changed:
What|Removed |Added
CC||k...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066
--- Comment #28 from Fridolin Somers ---
Pushed to master for 22.05, thanks to everybody involved 🦄
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066
Fridolin Somers changed:
What|Removed |Added
Status|Passed QA |Pushed to master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066
--- Comment #27 from Fridolin Somers ---
(In reply to Owen Leonard from comment #26)
> I'm not trying to derail the progress of this patch, but I thought this
> follow-up would be helpful.
Just perfect :D
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066
--- Comment #26 from Owen Leonard ---
I'm not trying to derail the progress of this patch, but I thought this
follow-up would be helpful.
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066
--- Comment #25 from Owen Leonard ---
Created attachment 132947
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132947&action=edit
Bug 29066: (follow-up) Use tooltip when SearchMyLibraryFirst in effect
This patch p
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066
--- Comment #24 from Katrin Fischer ---
Owen had showed a screenshot on IRC using the 'filter' icon, that I liked
better than the question mark, but not sure if he was going to provide a
follow-up.
--
You are receiving this mail be
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066
--- Comment #23 from Kyle M Hall ---
Created attachment 132855
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132855&action=edit
Bug 29066: (follow-up) add aria-label and aria-hidden on icons
Signed-off-by: Lucas
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066
Kyle M Hall changed:
What|Removed |Added
Attachment #132376|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066
Kyle M Hall changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066
--- Comment #21 from Katrin Fischer ---
I really love the change with the magnifying glass instead of "Go".
A little more hesitant about the tooltip for SearchMyLibraryFirst, but I like
that it will allow to hide the information if
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066
Katrin Fischer changed:
What|Removed |Added
Attachment #132375|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066
Katrin Fischer changed:
What|Removed |Added
Attachment #130114|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066
Katrin Fischer changed:
What|Removed |Added
Attachment #130115|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.druart+koha@gmail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066
Lucas Gass changed:
What|Removed |Added
Attachment #130032|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066
Lucas Gass changed:
What|Removed |Added
Attachment #130031|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066
Lucas Gass changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066
Fridolin Somers changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066
Fridolin Somers changed:
What|Removed |Added
Attachment #129519|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066
Lucas Gass changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
--
You ar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066
--- Comment #13 from Lucas Gass ---
Sorry to say, I cannot get this patchset to apply cleanly to master now. :(
--
You are receiving this mail because:
You are watching all bug changes.
_
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066
--- Comment #12 from Fridolin Somers ---
(In reply to Lucas Gass from comment #9)
> I think the follow-up is correct, the aria-label belongs on the button. Now
> I think the the icon needs the aria-hidden="true" attribute.
>
> In f
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066
--- Comment #11 from Fridolin Somers ---
Created attachment 130032
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130032&action=edit
Bug 29066: (follow-up) add aria-label and aria-hidden on icons
--
You are recei
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066
Fridolin Somers changed:
What|Removed |Added
Attachment #128927|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066
--- Comment #9 from Lucas Gass ---
I think the follow-up is correct, the aria-label belongs on the button. Now I
think the the icon needs the aria-hidden="true" attribute.
In fact the QA tool thinks so too:
FAIL koha-tmpl/opac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066
--- Comment #8 from Fridolin Somers ---
Created attachment 129519
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129519&action=edit
Bug 29066: (follow-up) add aria-label
--
You are receiving this mail because:
Yo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066
Fridolin Somers changed:
What|Removed |Added
Status|Signed Off |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066
--- Comment #7 from Fridolin Somers ---
(In reply to Lucas Gass from comment #6)
> I see the button does include a title attribute of 'Search' which is good
> but does that cover all accessibility cases? Should this not also include
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066
Lucas Gass changed:
What|Removed |Added
CC||lu...@bywatersolutions.com,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066
Samu Heiskanen changed:
What|Removed |Added
Attachment #125084|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066
Samu Heiskanen changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066
--- Comment #4 from Fridolin Somers ---
Created attachment 125181
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125181&action=edit
Screenshot librarypulldown
--
You are receiving this mail because:
You are watch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066
--- Comment #3 from Fridolin Somers ---
Created attachment 125180
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125180&action=edit
Screenshot mylibraryfirst
--
You are receiving this mail because:
You are watchi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066
--- Comment #2 from Fridolin Somers ---
Don't hesitate to ask for changes that are needed for accessibility.
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066
Fridolin Somers changed:
What|Removed |Added
See Also||https://bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066
--- Comment #1 from Fridolin Somers ---
Created attachment 125084
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125084&action=edit
Bug 29066: Remove text in OPAC search form and use Font Awesome icons
In modern f
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066
Fridolin Somers changed:
What|Removed |Added
Patch complexity|--- |Small patch
S
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066
Fridolin Somers changed:
What|Removed |Added
Assignee|oleon...@myacpl.org |fridolin.som...@biblibre.c
39 matches
Mail list logo
