https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110
Bug 29110 depends on bug 27949, which changed state.
Bug 27949 Summary: Batch printing of article request slips
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949
What|Removed |Added
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Failed QA |RESOLVED
Resolu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110
--- Comment #15 from Tomás Cohen Arazi ---
I don't think we need this for now. The only valuable addition is the schema
changes, adding relationships with better names, but it falls short as it is
not renaming the methods to access t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110
--- Comment #14 from Tomás Cohen Arazi ---
(In reply to Marcel de Rooy from comment #9)
> +# this is to avoid calling ->discard_changes to retrieve
> +# the default value from the DB
> +$self->status( Koha::Ar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110
--- Comment #13 from Tomás Cohen Arazi ---
(In reply to Marcel de Rooy from comment #8)
> Koha/Schema/Result/ArticleRequest.pm | 38 +-
That's weird. Probably didn't notice on git add.
> Strictly forbidden. Even for Tomas.
Sp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110
--- Comment #12 from Tomás Cohen Arazi ---
(In reply to Marcel de Rooy from comment #7)
> +$deleted_patron->delete; # Haha
It makes sense :-D I want a patron I'm sure doesn't exist on the DB :-D
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110
--- Comment #11 from Marcel de Rooy ---
Note that I also saw the problem David mentioned:
Error trace
Template process failed: undef error - DBIC result _type isn't of the _type
Item at /usr/share/koha/koha-tmpl/opac-tmpl/bootstra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110
--- Comment #10 from Marcel de Rooy ---
+$self->SUPER::store;
+$self->notify;
Not sure if this is an improvement. When you store something, you call notify?
This action begs for another code location imo.
--
You are receiv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110
--- Comment #9 from Marcel de Rooy ---
+# this is to avoid calling ->discard_changes to retrieve
+# the default value from the DB
+$self->status( Koha::ArticleRequest::Status::Requested )
+unless $
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110
Marcel de Rooy changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #8 f
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110
--- Comment #7 from Marcel de Rooy ---
+$deleted_patron->delete; # Haha
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--- Comme
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110
David Nind changed:
What|Removed |Added
Status|Signed Off |Failed QA
--
You are receivin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110
David Nind changed:
What|Removed |Added
CC||da...@davidnind.com
--- Commen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110
David Nind changed:
What|Removed |Added
Attachment #125257|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110
David Nind changed:
What|Removed |Added
Attachment #125256|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110
--- Comment #2 from Tomás Cohen Arazi ---
Created attachment 125257
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125257&action=edit
Bug 29110: Refactor Koha::ArticleRequest
This patchset is simple to test. It ad
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110
--- Comment #1 from Tomás Cohen Arazi ---
Created attachment 125256
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125256&action=edit
Bug 29110: Unit tests
--
You are receiving this mail because:
You are watching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110
Tomás Cohen Arazi changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110
Tomás Cohen Arazi changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110
Tomás Cohen Arazi changed:
What|Removed |Added
Depends on||27949
Statu
22 matches
Mail list logo
