https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
--- Comment #56 from Thibaud Guillot ---
ok great, thanks for the alert by the way
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koh
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
--- Comment #55 from Jonathan Druart ---
(In reply to Thibaud Guillot from comment #54)
> (In reply to Jonathan Druart from comment #53)
> > (In reply to Jonathan Druart from comment #52)
> > > Please have a look at bug 33445 that is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
--- Comment #54 from Thibaud Guillot ---
(In reply to Jonathan Druart from comment #53)
> (In reply to Jonathan Druart from comment #52)
> > Please have a look at bug 33445 that is suggesting to revert these patches!
>
> ping Thibau
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
--- Comment #53 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #52)
> Please have a look at bug 33445 that is suggesting to revert these patches!
ping Thibaud?
--
You are receiving this mail because:
You are wa
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
--- Comment #52 from Jonathan Druart ---
Please have a look at bug 33445 that is suggesting to revert these patches!
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
Phil Ringnalda changed:
What|Removed |Added
Blocks||33445
Referenced Bugs:
h
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
wainuiwitikap...@catalyst.net.nz changed:
What|Removed |Added
CC||wainuiwiti
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
Arthur Suzuki changed:
What|Removed |Added
Version(s)|23.05.00,22.11.03,22.05.10 |23.05.00,22.11.03,22.05.10,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
Lucas Gass changed:
What|Removed |Added
Version(s)|23.05.00,22.11.03 |23.05.00,22.11.03,22.05.10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
--- Comment #48 from Jacob O'Mara ---
Nice work, thanks everyone!
Pushed to 22.11.x for the next release.
--
You are receiving this mail because:
You are watching all bug changes.
___
Ko
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
Jacob O'Mara changed:
What|Removed |Added
Status|Pushed to master|Pushed to stable
Ver
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
--- Comment #47 from Tomás Cohen Arazi ---
Pushed to master for 23.05.
Nice work everyone, thanks!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
Tomás Cohen Arazi changed:
What|Removed |Added
Version(s)||23.05.00
release
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
--- Comment #46 from Thibaud Guillot ---
(In reply to Martin Renvoize from comment #45)
> This all works well and the QA script is happy.
>
> I would have loved to see some consistency in the implementation between the
> two buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
Martin Renvoize changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europ
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
Martin Renvoize changed:
What|Removed |Added
Blocks||32906
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
Martin Renvoize changed:
What|Removed |Added
CC||martin.renvoize@ptfs-europ
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
--- Comment #44 from Martin Renvoize ---
Created attachment 146381
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146381&action=edit
Bug 29173: (QA follow-up) Match pop-over sizes
As suggested by David Nind, this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
Martin Renvoize changed:
What|Removed |Added
Attachment #144983|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
--- Comment #42 from David Nind ---
It would be good if both pop up windows were the same size for the search. At
the moment the pop up window is slightly narrower for Edit > Edit record >
Replace record via Z39.40/SRU search. This c
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
David Nind changed:
What|Removed |Added
Attachment #144972|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
--- Comment #40 from David Nind ---
(In reply to Thibaud Guillot from comment #39)
> Thanks for your feedback :) and best wishes for 2023 by the way ;)
>
> I squash my last commit and I test it in kohadevbox, it seems ok to me, ca
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
--- Comment #39 from Thibaud Guillot ---
(In reply to David Nind from comment #37)
> Hi
>
> I'm getting this error when trying to apply the patch:
>
> root@kohadevbox:koha(bz29173)$ git bz apply 29173
>
> Bug 29173 - Button "repl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
Thibaud Guillot changed:
What|Removed |Added
Attachment #144867|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
Thibaud Guillot changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
--- Commen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
--- Comment #36 from Thibaud Guillot ---
I change the logical this time, in a "easier" way ? With a direct mapping with
data's fields and sufields..
I hope this work now for you :)
I also changed my test plan cause now I had the sa
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
Thibaud Guillot changed:
What|Removed |Added
Attachment #136440|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
Thibaud Guillot changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
Thibault Keromnès changed:
What|Removed |Added
CC||thibault.keromnes@univ-p
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
--- Comment #33 from David Nind ---
(In reply to Thibaud Guillot from comment #32)
> Maybe I miss the rebase, can you test it now and tell me if you have the
> same issue ?
I still have the same issue.
Testing using koha-testing-d
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
--- Comment #32 from Thibaud Guillot ---
(In reply to David Nind from comment #30)
> I'm getting this error after applying the patch:
>
> The method Koha::Authority->record is not covered by tests!
>
> Trace begun at /kohadevbox/ko
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
Thibaud Guillot changed:
What|Removed |Added
Attachment #136411|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
Thibaud Guillot changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #30 from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
Thibaud Guillot changed:
What|Removed |Added
Attachment #136410|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
Thibaud Guillot changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
Thibaud Guillot changed:
What|Removed |Added
Attachment #132443|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
Owen Leonard changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
Thibaud Guillot changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
Thibaud Guillot changed:
What|Removed |Added
Attachment #130192|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
--- Comment #26 from Jonathan Druart ---
Also the C4::AuthoritiesMarc import is not longer needed.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #25
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
--- Comment #24 from David Nind ---
(In reply to Thibaud Guillot from comment #23)
> Oh ok, I see what you mean, but maybe this dropdown list is about another
> issue or enhancement and not directly on this BZ. Its my opinion but I
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
--- Comment #23 from Thibaud Guillot ---
(In reply to David Nind from comment #19)
> Testing notes (using koha-testing-docker):
>
> - Tested using both a MARC21 and UNIMARC installation.
>
> - For a UNIMARC installation there is on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
--- Comment #22 from Thibaud Guillot ---
(In reply to Jonathan Druart from comment #20)
> (In reply to Jonathan Druart from comment #15)
> > (In reply to Katrin Fischer from comment #8)
> > > Also I wonder if we could avoid querying
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
--- Comment #21 from Thibaud Guillot ---
Created attachment 130422
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130422&action=edit
Bug 29173 : (follow-up) replace method to get the record from the authority
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
--- Comment #20 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #15)
> (In reply to Katrin Fischer from comment #8)
> > Also I wonder if we could avoid querying the record twice, but someone else
> > might be bette
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
--- Comment #19 from David Nind ---
Testing notes (using koha-testing-docker):
- Tested using both a MARC21 and UNIMARC installation.
- For a UNIMARC installation there is only one way to replace (both before and
after the patch is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
David Nind changed:
What|Removed |Added
Attachment #128756|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
David Nind changed:
What|Removed |Added
Attachment #128410|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
Thibaud Guillot changed:
What|Removed |Added
Attachment #128731|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.druart+koha@gmail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
Thibaud Guillot changed:
What|Removed |Added
Attachment #128410|1 |0
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
Thibaud Guillot changed:
What|Removed |Added
Attachment #128730|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
Thibaud Guillot changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
--- Comment #13 from Thibaud Guillot ---
Created attachment 128731
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128731&action=edit
Bug 29173: (follow-up) add marcflavour preference in conditions
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
Thibaud Guillot changed:
What|Removed |Added
Attachment #128410|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
Thibaud Guillot changed:
What|Removed |Added
Attachment #128728|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
--- Comment #11 from Thibaud Guillot ---
Created attachment 128728
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128728&action=edit
Bug 29173: Fixed pre-filling of the search form from the "Replace record with
ZR3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
--- Comment #10 from Katrin Fischer ---
> Hi Katrin,
>
> Thank you for looking at this bug.
>
> I must point out that I did nothing on this bug (exept filing it).
> Thibaud is the one who wrote the patch :)
I am sorry, misreading
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
--- Comment #9 from marion.dur...@biblibre.com ---
(In reply to Katrin Fischer from comment #8)
> Hi Marion,
>
> I believe this will work nicely for MARC21, but not work for UNIMARC as the
> fields are quite different.
>
> Why in M
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #8 f
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
--- Comment #7 from David Nind ---
> Okay, thanks for commit title, I'm new on this so I can made some mistakes :)
8-) The QA Team are very helpful in helping out new contributors!
Here are the guidelines for commits:
https://wiki.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
--- Comment #6 from Thibaud Guillot ---
(In reply to David Nind from comment #5)
> Comment on attachment 128378 [details] [review]
> Fixed pre-filling of the search form from the "Replace record with
> ZR39.50/SRU" (Authority page de
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
David Nind changed:
What|Removed |Added
Text to go in the||This fixes the behaviour of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
David Nind changed:
What|Removed |Added
CC||da...@davidnind.com
Attachment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
--- Comment #4 from David Nind ---
Created attachment 128410
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128410&action=edit
Bug 29173: Fixed pre-filling of the search form from the "Replace record with
ZR39.50/S
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
Thibaud Guillot changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
Thibaud Guillot changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun |thibaud.guil...@biblibre.c
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
--- Comment #3 from Thibaud Guillot ---
Created attachment 128378
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128378&action=edit
Fixed pre-filling of the search form from the "Replace record with ZR39.50/SRU"
(A
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
Fridolin Somers changed:
What|Removed |Added
Summary|Button "replace authority |Button "replace authority
75 matches
Mail list logo