[Koha-bugs] [Bug 29240] Flatpickr - error in the console when a date is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 Katrin Fischer changed: What|Removed |Added Blocks||30183 Referenced Bugs: h

[Koha-bugs] [Bug 29240] Flatpickr - error in the console when a date is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 Jonathan Druart changed: What|Removed |Added Keywords|rel_21_11_candidate | -- You are receiving th

[Koha-bugs] [Bug 29240] Flatpickr - error in the console when a date is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 Kyle M Hall changed: What|Removed |Added Resolution|--- |FIXED Status|Push

[Koha-bugs] [Bug 29240] Flatpickr - error in the console when a date is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 --- Comment #31 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 29240] Flatpickr - error in the console when a date is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master

[Koha-bugs] [Bug 29240] Flatpickr - error in the console when a date is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are rec

[Koha-bugs] [Bug 29240] Flatpickr - error in the console when a date is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-communit

[Koha-bugs] [Bug 29240] Flatpickr - error in the console when a date is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 --- Comment #29 from Jonathan Druart --- Created attachment 126495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126495&action=edit Bug 29240: Rename start_for with date_to Signed-off-by: Jonathan Druart -- Yo

[Koha-bugs] [Bug 29240] Flatpickr - error in the console when a date is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 --- Comment #28 from Jonathan Druart --- Created attachment 126494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126494&action=edit Bug 29240: (follow-up) Correct more instances This patch fixes linked date field

[Koha-bugs] [Bug 29240] Flatpickr - error in the console when a date is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 Jonathan Druart changed: What|Removed |Added Attachment #126341|0 |1 is obsolete|

[Koha-bugs] [Bug 29240] Flatpickr - error in the console when a date is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 --- Comment #26 from Owen Leonard --- I agree with the rename! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-co

[Koha-bugs] [Bug 29240] Flatpickr - error in the console when a date is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 --- Comment #25 from Martin Renvoize --- But I think I decided we should move the request.tt change to another bug for testing as I'm not 100% confident in it at last look -- You are receiving this mail because: You are watching al

[Koha-bugs] [Bug 29240] Flatpickr - error in the console when a date is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 --- Comment #24 from Martin Renvoize --- I agree with the rename :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.ko

[Koha-bugs] [Bug 29240] Flatpickr - error in the console when a date is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 --- Comment #23 from Jonathan Druart --- (In reply to Jonathan Druart from comment #22) > Created attachment 126472 [details] [review] > Bug 29240: Rename start_for with date_to Martin, Owen, if we agree on that I will PQA and push

[Koha-bugs] [Bug 29240] Flatpickr - error in the console when a date is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 --- Comment #22 from Jonathan Druart --- Created attachment 126472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126472&action=edit Bug 29240: Rename start_for with date_to -- You are receiving this mail because

[Koha-bugs] [Bug 29240] Flatpickr - error in the console when a date is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 --- Comment #21 from Martin Renvoize --- Humm, ignore that last comment.. digging further.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing

[Koha-bugs] [Bug 29240] Flatpickr - error in the console when a date is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #2

[Koha-bugs] [Bug 29240] Flatpickr - error in the console when a date is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 Martin Renvoize changed: What|Removed |Added Attachment #126309|0 |1 is obsolete|

[Koha-bugs] [Bug 29240] Flatpickr - error in the console when a date is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 Martin Renvoize changed: What|Removed |Added Attachment #126301|0 |1 is obsolete|

[Koha-bugs] [Bug 29240] Flatpickr - error in the console when a date is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 Martin Renvoize changed: What|Removed |Added Attachment #126295|0 |1 is obsolete|

[Koha-bugs] [Bug 29240] Flatpickr - error in the console when a date is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 --- Comment #16 from Jonathan Druart --- (In reply to Owen Leonard from comment #15) > I deliberately omitted any change to request.tt because the Flatpickr > instantiation was already being modified with an onChange event. I didn't

[Koha-bugs] [Bug 29240] Flatpickr - error in the console when a date is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 --- Comment #15 from Owen Leonard --- I deliberately omitted any change to request.tt because the Flatpickr instantiation was already being modified with an onChange event. I didn't see any advantage to changing it. -- You are rece

[Koha-bugs] [Bug 29240] Flatpickr - error in the console when a date is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 --- Comment #14 from Jonathan Druart --- (In reply to Jonathan Druart from comment #13) > Created attachment 126309 [details] [review] > Bug 29240: Fix request.tt > > I have a doubt here, I was going to make the JS part retrieve the

[Koha-bugs] [Bug 29240] Flatpickr - error in the console when a date is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 --- Comment #13 from Jonathan Druart --- Created attachment 126309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126309&action=edit Bug 29240: Fix request.tt I have a doubt here, I was going to make the JS part r

[Koha-bugs] [Bug 29240] Flatpickr - error in the console when a date is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 --- Comment #12 from Martin Renvoize --- I agree start_for is a bit weird.. but I struggled to come up with anything better.. I wanted to keep it fairly short but also clear.. totally open to suggestions. -- You are receiving this

[Koha-bugs] [Bug 29240] Flatpickr - error in the console when a date is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 --- Comment #11 from Jonathan Druart --- (In reply to Jonathan Druart from comment #10) > 2. data-start_for reads weird to me, why not data-date_from_id? (I will > amend the patches if we agree) It's the reverse, data-date_to_id. Ok

[Koha-bugs] [Bug 29240] Flatpickr - error in the console when a date is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 --- Comment #10 from Jonathan Druart --- Thanks! That's much better and will be way easier to maintain! 1. Those 2 are missing: koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt: validate_date( selectedDa

[Koha-bugs] [Bug 29240] Flatpickr - error in the console when a date is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europ

[Koha-bugs] [Bug 29240] Flatpickr - error in the console when a date is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 --- Comment #9 from Owen Leonard --- Created attachment 126301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126301&action=edit Bug 29240: (follow-up) Correct more instances This patch fixes linked date fields in

[Koha-bugs] [Bug 29240] Flatpickr - error in the console when a date is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 Owen Leonard changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are re

[Koha-bugs] [Bug 29240] Flatpickr - error in the console when a date is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 Owen Leonard changed: What|Removed |Added Attachment #126293|0 |1 is obsolete|

[Koha-bugs] [Bug 29240] Flatpickr - error in the console when a date is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 Owen Leonard changed: What|Removed |Added Attachment #126294|0 |1 is obsolete|

[Koha-bugs] [Bug 29240] Flatpickr - error in the console when a date is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 Owen Leonard changed: What|Removed |Added Attachment #126293|1 |0 is obsolete|

[Koha-bugs] [Bug 29240] Flatpickr - error in the console when a date is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 Owen Leonard changed: What|Removed |Added Blocks||29212 Referenced Bugs: htt

[Koha-bugs] [Bug 29240] Flatpickr - error in the console when a date is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 Owen Leonard changed: What|Removed |Added Attachment #126293|0 |1 is obsolete|

[Koha-bugs] [Bug 29240] Flatpickr - error in the console when a date is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexit

[Koha-bugs] [Bug 29240] Flatpickr - error in the console when a date is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 Martin Renvoize changed: What|Removed |Added Attachment #126286|0 |1 is obsolete|

[Koha-bugs] [Bug 29240] Flatpickr - error in the console when a date is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are

[Koha-bugs] [Bug 29240] Flatpickr - error in the console when a date is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 Martin Renvoize changed: What|Removed |Added Blocks|29239 | Referenced Bugs: https

[Koha-bugs] [Bug 29240] Flatpickr - error in the console when a date is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 Martin Renvoize changed: What|Removed |Added Attachment #126259|0 |1 is obsolete|

[Koha-bugs] [Bug 29240] Flatpickr - error in the console when a date is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europ

[Koha-bugs] [Bug 29240] Flatpickr - error in the console when a date is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 --- Comment #4 from Martin Renvoize --- Created attachment 126286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126286&action=edit Bug 29240: Centralise from/to handling This patch moves to using a data-start_for

[Koha-bugs] [Bug 29240] Flatpickr - error in the console when a date is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 --- Comment #3 from Jonathan Druart --- (In reply to Jonathan Druart from comment #2) > Maybe this is the way, I am not sure. > But for sure, we must remove the onClose duplication code. All the flackpikr > logic must be in calendar.

[Koha-bugs] [Bug 29240] Flatpickr - error in the console when a date is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 --- Comment #2 from Jonathan Druart --- Maybe this is the way, I am not sure. But for sure, we must remove the onClose duplication code. All the flackpikr logic must be in calendar.inc. We should start with centralizing the code. -

[Koha-bugs] [Bug 29240] Flatpickr - error in the console when a date is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 --- Comment #1 from Jonathan Druart --- Created attachment 126259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126259&action=edit Bug 29240: Remove error in console when date is incorrect -- You are receiving t

[Koha-bugs] [Bug 29240] Flatpickr - error in the console when a date is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 Andrew Nugged changed: What|Removed |Added CC||nug...@gmail.com -- You ar

[Koha-bugs] [Bug 29240] Flatpickr - error in the console when a date is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 Jonathan Druart changed: What|Removed |Added Blocks||29241 Referenced Bugs:

[Koha-bugs] [Bug 29240] Flatpickr - error in the console when a date is selected

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 Jonathan Druart changed: What|Removed |Added Keywords||rel_21_11_candidate -- Y