https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
--- Comment #1 from Nick Clemens ---
Created attachment 127610
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127610&action=edit
Bug 29474: Return too_soon before checking renewals
This patch allows us to avoid ch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
Joonas Kylmälä changed:
What|Removed |Added
CC||joonas.kylm...@iki.fi
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
--- Comment #3 from Joonas Kylmälä ---
(In reply to Joonas Kylmälä from comment #2)
> I think adding a comment like "cron wants 'too_soon' over 'on_reserve'"
This sentence was unfinished.. I meant adding this comment next to the co
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
Nick Clemens changed:
What|Removed |Added
Attachment #127610|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
--- Comment #5 from Nick Clemens ---
(In reply to Joonas Kylmälä from comment #2)
> If you remove the unless ... makes the code much simpler.
Done
> Please also move the cron return right after the call to
> > $auto_renew = _CanBo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
Nick Clemens changed:
What|Removed |Added
Attachment #127611|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
--- Comment #7 from Nick Clemens ---
(In reply to Nick Clemens from comment #5)
> > Please also move the cron return right after the call to
> > > $auto_renew = _CanBookBeAutoRenewed({
>
> I don't believe I can. That is inside "unl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
--- Comment #8 from Nick Clemens ---
Created attachment 127613
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127613&action=edit
Bug 29474: Check ItemsAnyAvailableAndNOtRestricted outside of loop
IsAvailableForIte
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
Nick Clemens changed:
What|Removed |Added
Status|NEW |Needs Signoff
--- Comment #9
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
Nick Clemens changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
Joonas Kylmälä changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
--- Comment #11 from Joonas Kylmälä ---
oh, I think I discovered a bug in the CanBookBeRenewed function. We are calling
> next unless IsAvailableForItemLevelRequest($item, $patron);
and we are not passing the ignore_hold_counts=>1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
--- Comment #12 from Joonas Kylmälä ---
In the first patch you added the comment:
# override_limit will override anything else except on_reserve or too_soon
This is actually not what the code does, but it should do this I think, it
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
--- Comment #13 from Joonas Kylmälä ---
(In reply to Joonas Kylmälä from comment #12)
> In the first patch you added the comment:
>
> # override_limit will override anything else except on_reserve or too_soon
>
> This is actually n
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
Joonas Kylmälä changed:
What|Removed |Added
Attachment #127612|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
--- Comment #15 from Joonas Kylmälä ---
Created attachment 127615
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127615&action=edit
Bug 29474: Fix incorrect comment
The too_soon is actually being overriden if $ove
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
--- Comment #16 from Joonas Kylmälä ---
Created attachment 127616
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127616&action=edit
Bug 29474: Decouple renewal checks of auto-renewed issues from non-autorenewed
Th
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
--- Comment #17 from Joonas Kylmälä ---
Created attachment 127617
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127617&action=edit
Bug 29474: Remove one layer of indendation by adding if check in the begginning
I
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
--- Comment #18 from Joonas Kylmälä ---
I fixed the incorrect comment about too_soon not being overriden and added
couple improvements to the code as well. I obsoleted also the patch from
comment #8 now as it was buggy (see comment #
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
Joonas Kylmälä changed:
What|Removed |Added
CC||nug...@gmail.com
--
You a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
--
Y
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
Nick Clemens changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
Nick Clemens changed:
What|Removed |Added
Attachment #127614|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
--- Comment #20 from Nick Clemens ---
Created attachment 127633
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127633&action=edit
Bug 29474: Decouple renewal checks of auto-renewed issues from non-autorenewed
The
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
--- Comment #21 from Nick Clemens ---
Created attachment 127634
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127634&action=edit
Bug 29474: Remove one layer of indendation by adding if check in the begginning
If
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
--- Comment #22 from Nick Clemens ---
Created attachment 127635
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127635&action=edit
Bug 29474: Pass rules/branchcode to subroutines, further simplify logic
If we are g
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
--- Comment #23 from Nick Clemens ---
(In reply to Joonas Kylmälä from comment #18)
> I fixed the incorrect comment about too_soon not being overriden and added
> couple improvements to the code as well.
Excellent! Thanks! I squash
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
Nick Clemens changed:
What|Removed |Added
Blocks||29483
Referenced Bugs:
htt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
--- Comment #24 from Kyle M Hall ---
Created attachment 127658
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127658&action=edit
Bug 29474: Small efficiency improvement
--
You are receiving this mail because:
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
Joonas Kylmälä changed:
What|Removed |Added
Depends on||29476
--- Comment #25 from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
Joonas Kylmälä changed:
What|Removed |Added
Blocks||29537
Referenced Bugs:
h
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
Joonas Kylmälä changed:
What|Removed |Added
Depends on|29476 |
--- Comment #26 from Joon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
Joonas Kylmälä changed:
What|Removed |Added
Attachment #127632|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
--- Comment #28 from Joonas Kylmälä ---
Created attachment 127904
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127904&action=edit
Bug 29474: Decouple renewal checks of auto-renewed issues from non-autorenewed
Th
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
--- Comment #29 from Joonas Kylmälä ---
Created attachment 127905
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127905&action=edit
Bug 29474: Remove one layer of indendation by adding if check in the begginning
I
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
--- Comment #30 from Joonas Kylmälä ---
Created attachment 127906
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127906&action=edit
Bug 29474: Pass rules/branchcode to subroutines, further simplify logic
If we are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
--- Comment #31 from Joonas Kylmälä ---
Created attachment 127907
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127907&action=edit
Bug 29474: Small efficiency improvement
Signed-off-by: Joonas Kylmälä
--
You a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
--- Comment #32 from Joonas Kylmälä ---
Added sign-off to all the patches that were not from me, Nick or Kyle, you
could sign-off the patches from me to get this to signed-off state :)
--
You are receiving this mail because:
You ar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
Nick Clemens changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are recei
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
Nick Clemens changed:
What|Removed |Added
Attachment #127903|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
--- Comment #34 from Nick Clemens ---
Created attachment 127950
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127950&action=edit
Bug 29474: Decouple renewal checks of auto-renewed issues from non-autorenewed
The
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
--- Comment #35 from Nick Clemens ---
Created attachment 127951
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127951&action=edit
Bug 29474: Remove one layer of indendation by adding if check in the begginning
If
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
--- Comment #36 from Nick Clemens ---
Created attachment 127952
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127952&action=edit
Bug 29474: Pass rules/branchcode to subroutines, further simplify logic
If we are g
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
--- Comment #37 from Nick Clemens ---
Created attachment 127953
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127953&action=edit
Bug 29474: Small efficiency improvement
Signed-off-by: Joonas Kylmälä
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.druart+koha@gmail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
--- Comment #39 from Jonathan Druart ---
Forget the second part, it's in the dependency tree already!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
--- Comment #40 from Nick Clemens ---
(In reply to Jonathan Druart from comment #38)
> Nick, I was wondering this morning (bug 29474 comment 9) if
> _CanBookBeAutoRenewed shouldn't actually call GetSoonestRenewDate.
Can you elaborat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
--- Comment #41 from Jonathan Druart ---
(In reply to Nick Clemens from comment #40)
> (In reply to Jonathan Druart from comment #38)
> > Nick, I was wondering this morning (bug 29474 comment 9) if
> > _CanBookBeAutoRenewed shouldn't
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
--- Comment #42 from Jonathan Druart ---
I agree with most of the changes, but I don't think it's a good idea to pass
the issuing rules and the "soonest date". It's just hiding problem with the
code, which shouldn't be resolved that
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
--- Comment #43 from Jonathan Druart ---
And... thinking loud, sorry for the noise if it does not make sense.
There is a _CanBookBeAutoRenewed sub but we are still doing "auto renewal"
related checks in CanBookBeRenewed. It should b
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
--- Comment #44 from Nick Clemens ---
(In reply to Jonathan Druart from comment #42)
> I agree with most of the changes, but I don't think it's a good idea to pass
> the issuing rules and the "soonest date". It's just hiding problem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
--- Comment #45 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #42)
> For instance if we are facing perf issues with the fetch of the circ rules,
> we should then cache them. Other areas would benefit from that ki
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
Jonathan Druart changed:
What|Removed |Added
See Also||https://bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
--- Comment #46 from Jonathan Druart ---
(In reply to Nick Clemens from comment #44)
> (In reply to Jonathan Druart from comment #42)
> > Ideally
> > Koha::AutoRenewalHold inherit from Koha::Hold
> > Koha::AutoRenewalHold->can_be
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
Nick Clemens changed:
What|Removed |Added
Attachment #127952|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
Nick Clemens changed:
What|Removed |Added
Attachment #127953|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
--- Comment #47 from Nick Clemens ---
(In reply to Jonathan Druart from comment #45)
> (In reply to Jonathan Druart from comment #42)
> > For instance if we are facing perf issues with the fetch of the circ rules,
> > we should then
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
Nick Clemens changed:
What|Removed |Added
Attachment #127952|1 |0
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
Nick Clemens changed:
What|Removed |Added
Attachment #127953|1 |0
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
Nick Clemens changed:
What|Removed |Added
Attachment #127952|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
Nick Clemens changed:
What|Removed |Added
Attachment #127953|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
Jonathan Druart changed:
What|Removed |Added
Attachment #127949|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
--- Comment #49 from Jonathan Druart ---
Created attachment 128555
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128555&action=edit
Bug 29474: Decouple renewal checks of auto-renewed issues from non-autorenewed
T
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
--- Comment #50 from Jonathan Druart ---
Created attachment 128556
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128556&action=edit
Bug 29474: Remove one layer of indendation by adding if check in the begginning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
Fridolin Somers changed:
What|Removed |Added
Version(s)||22.05.00
released
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
--- Comment #51 from Fridolin Somers ---
Pushed to master for 22.05, thanks to everybody involved 🦄
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
Kyle M Hall changed:
What|Removed |Added
Status|Pushed to master|Pushed to stable
Vers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
Andrew Fuerste-Henry changed:
What|Removed |Added
Status|Pushed to stable|RESOLVED
Res
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474
--- Comment #54 from Nick Clemens ---
*** Bug 22333 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
70 matches
Mail list logo