https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
--- Comment #37 from Marcel de Rooy ---
Saw this in 21.11:
[WARN] Preventing $template->lang='-undef-' to be overwritten by
template->{VARS}{lang}='-undef-' at /usr/share/koha/C4/Templates.pm line 118.
It comes from the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
Jonathan Druart changed:
What|Removed |Added
Blocks||30868
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
--- Comment #36 from Katrin Fischer ---
I believe this might be linked to bug 30315 on 20.11, but as we are close to
end of life there maybe a backport is too risky?
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
Katrin Fischer changed:
What|Removed |Added
Blocks||30315
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
Katrin Fischer changed:
What|Removed |Added
Blocks||25790
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
Katrin Fischer changed:
What|Removed |Added
Blocks|25790 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
Kyle M Hall changed:
What|Removed |Added
Version(s)|22.05.00|22.05.00,21.11.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
--- Comment #34 from Fridolin Somers ---
Pushed to master for 22.05, thanks to everybody involved 濾
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
Fridolin Somers changed:
What|Removed |Added
Status|Passed QA |Pushed to master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
--- Comment #33 from Jonathan Druart ---
Created attachment 131515
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131515=edit
Bug 29684: (QA follow-up) add lost borrower_data. prefix in memberentrygen.tt
for: -
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
--- Comment #32 from Jonathan Druart ---
Created attachment 131514
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131514=edit
Bug 29684: (QA follow-up) paycollect.pl don't needs borrower_data at all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
--- Comment #31 from Jonathan Druart ---
Created attachment 131513
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131513=edit
Bug 29684: (QA follow-up) Remove 2 extra 'borrower_data.' prefixes
Signed-off-by:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
--- Comment #30 from Jonathan Druart ---
Created attachment 131512
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131512=edit
Bug 29684: add honeypot to catch other warnings in the future
Signed-off-by: David
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
--- Comment #29 from Jonathan Druart ---
Created attachment 131511
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131511=edit
Bug 29684: Fix warn about js/locale_data.js (paycollect.pl)
To reproduce
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
Jonathan Druart changed:
What|Removed |Added
Attachment #130210|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
Jonathan Druart changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
--- Comment #27 from Andrew Nugged ---
umph! It's a complicated thing - we have interleaved usage of "patron." for
some elements (for a reason?) in memberentrygen.tt,
I at least re-checked once more all variables, might miss even,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
--- Comment #26 from Andrew Nugged ---
Created attachment 130477
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130477=edit
Bug 29684: (QA follow-up) add lost borrower_data. prefix in memberentrygen.tt
for: -
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
Andrew Nugged changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
Andrew Nugged changed:
What|Removed |Added
Status|Passed QA |Failed QA
--- Comment #25
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
Jonathan Druart changed:
What|Removed |Added
Attachment #130417|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
--- Comment #23 from Andrew Nugged ---
I found that it looks that $borrower in /members/paycollect.pl:
my $borrower = $patron->unblessed;
used only once even in old code:
$template->param(%$borrower);
and there all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
--- Comment #22 from Andrew Nugged ---
Created attachment 130417
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130417=edit
Bug 29684: (QA follow-up) paycollect.pl don't needs borrower_data at all
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
--- Comment #21 from Andrew Nugged ---
Good catch!
I also want to participate and add my part:
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
--- Comment #20 from Andrew Nugged ---
Created attachment 130413
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130413=edit
Bug 29684: (QA follow-up) Remove 2 extra 'borrower_data.' prefixes
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
--- Comment #19 from Katrin Fischer ---
(In reply to Fridolin Somers from comment #18)
> Hi,
> - Relationship:
> + borrower_data.Relationship:
>
> Sure about this change (twice) ?
> It is a text.
Good catch Frido :)
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
Fridolin Somers changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
--- Comment #17 from Tomás Cohen Arazi ---
Created attachment 130212
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130212=edit
Bug 29684: add honeypot to catch other warnings in the future
Signed-off-by: David
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
--- Comment #16 from Tomás Cohen Arazi ---
Created attachment 130211
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130211=edit
Bug 29684: Fix warn about js/locale_data.js (paycollect.pl)
To reproduce
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
--- Comment #15 from Tomás Cohen Arazi ---
Created attachment 130210
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130210=edit
Bug 29684: Fix warn about js/locale_data.js (memberentry.pl)
To reproduce
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #130186|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #130185|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #130184|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
Tomás Cohen Arazi changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
David Nind changed:
What|Removed |Added
Attachment #129536|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
--- Comment #13 from David Nind ---
Created attachment 130185
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130185=edit
Bug 29684: fix warn about not found file js/locale_data.js
To reproduce (paycollect.pl):
1)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
David Nind changed:
What|Removed |Added
Attachment #129532|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
Jonathan Druart changed:
What|Removed |Added
Severity|normal |major
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
--- Comment #11 from Peter Vashchuk ---
Created attachment 129536
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129536=edit
Bug 29684: add honeypot to catch other warnings in the future
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
--- Comment #10 from Peter Vashchuk ---
Created attachment 129534
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129534=edit
Bug 29684: fix warn about not found file js/locale_data.js
To reproduce
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
Peter Vashchuk changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
Peter Vashchuk changed:
What|Removed |Added
Status|Needs Signoff |ASSIGNED
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
Peter Vashchuk changed:
What|Removed |Added
Attachment #128675|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
Peter Vashchuk changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
--- Comment #8 from Andrew Nugged ---
Great note from Katrin,
I agree that the best solution is to replace:
in members/paycollect.pl:
$template->param(%$borrower);
with something like:
$template->param(borrower_data =>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
Jonathan Druart changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
--- Comment #6 from Marcel de Rooy ---
(In reply to Katrin Fischer from comment #5)
> Is this not more a clash of variables where we should rename one?
>
> There is also the preferred language for notices stored in borrowers.lang
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #5
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #128571|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
--- Comment #3 from Peter Vashchuk ---
Created attachment 128571
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128571=edit
Bug 29684: fix warn about not found file js/locale_data.js
Value of 'lang' unexpectedly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
Peter Vashchuk changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
--- Comment #2 from Marcel de Rooy ---
(In reply to Andrew Nugged from comment #1)
> Petro has fix, will publish it.
Great !
> I still can't find direct reproduction for
> "ArticleRequestsDisclaimerText_en":
> (somewhere related
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
--- Comment #1 from Andrew Nugged ---
it's reproducible on some pages:
members/memberentry.pl
members/paycollect.pl
for example, edit some user:
/cgi-bin/koha/members/memberentry.pl?op=modify=1=1
This happens because
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
Andrew Nugged changed:
What|Removed |Added
CC||nug...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
Marcel de Rooy changed:
What|Removed |Added
Blocks||25790
Referenced Bugs:
59 matches
Mail list logo