https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
Andrew Fuerste-Henry changed:
What|Removed |Added
CC||and...@bywatersolutio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
Kyle M Hall changed:
What|Removed |Added
Version(s)|22.05.00|22.05.00,21.11.03
rele
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
Nick Clemens changed:
What|Removed |Added
Blocks||30009
Referenced Bugs:
htt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
Nick Clemens changed:
What|Removed |Added
Blocks||30008
Referenced Bugs:
htt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
Jonathan Druart changed:
What|Removed |Added
CC||n...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
--- Comment #56 from Fridolin Somers ---
Pushed to master for 22.05, thanks to everybody involved 🦄
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
Fridolin Somers changed:
What|Removed |Added
Version(s)||22.05.00
released
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
Martin Renvoize changed:
What|Removed |Added
Status|Signed Off |Passed QA
--- Comment #55
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
Martin Renvoize changed:
What|Removed |Added
Attachment #129543|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
Martin Renvoize changed:
What|Removed |Added
Attachment #129542|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
--- Comment #52 from Fridolin Somers ---
I signoff.
Test successful with koha-testing-docker.
Fixed number of tests in selenium test file, from 7 to 8.
Copied test plan from old patch to new main patch.
Fixed typo in main patch mes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
Fridolin Somers changed:
What|Removed |Added
Attachment #129382|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
Fridolin Somers changed:
What|Removed |Added
Attachment #129381|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
Fridolin Somers changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
--- Comment #49 from Fridolin Somers ---
Small typo in commit message :
"if MARCXLM in invalid"
=> MARCXML
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
--- Comment #48 from Jonathan Druart ---
Created attachment 129382
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129382&action=edit
Bug 29690: Prevent detail.pl to crash if MARCXLM in invalid
--
You are receivin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
Jonathan Druart changed:
What|Removed |Added
Attachment #129339|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
Jonathan Druart changed:
What|Removed |Added
Status|In Discussion |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
--- Comment #46 from Fridolin Somers ---
(In reply to Jonathan Druart from comment #45)
> (In reply to Jonathan Druart from comment #44)
> > Created attachment 129365 [details] [review] [review]
> > Bug 29690: [ALTERNATIVE PATCH] Pre
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
--- Comment #45 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #44)
> Created attachment 129365 [details] [review]
> Bug 29690: [ALTERNATIVE PATCH] Prevent detail.pl to crash if MARCXLM in
> invalid
Tomas, Martin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
--- Comment #44 from Jonathan Druart ---
Created attachment 129365
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129365&action=edit
Bug 29690: [ALTERNATIVE PATCH] Prevent detail.pl to crash if MARCXLM in invalid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
--- Comment #43 from Jonathan Druart ---
Minor but worth noting: the patches rename $marc with $record. It should
actually be $marc_record I think, $record is too generic.
--
You are receiving this mail because:
You are watching al
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |In Discussion
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
Tomás Cohen Arazi changed:
What|Removed |Added
QA Contact|tomasco...@gmail.com|testo...@bugs.koha-commu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
--- Comment #40 from Tomás Cohen Arazi ---
Created attachment 129345
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129345&action=edit
Bug 29690: Fix tests count
Signed-off-by: Tomas Cohen Arazi
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
--- Comment #39 from Tomás Cohen Arazi ---
Created attachment 129344
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129344&action=edit
Bug 29690: (follow-up) Add eval on metadata record fetch in get_marc_authors()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
--- Comment #38 from Tomás Cohen Arazi ---
Created attachment 129343
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129343&action=edit
Bug 29690: Add selenium test
Signed-off-by: Tomas Cohen Arazi
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
--- Comment #37 from Tomás Cohen Arazi ---
Created attachment 129342
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129342&action=edit
Bug 29690: Always warn if something is wrong with the metadata
Signed-off-by:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
--- Comment #36 from Tomás Cohen Arazi ---
Created attachment 129341
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129341&action=edit
Bug 29690: Unit test for get_components_query
Signed-off-by: David Nind
Signe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
--- Comment #35 from Tomás Cohen Arazi ---
Created attachment 129340
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129340&action=edit
Bug 29690: (follow-up) Catch other cases
This patch catches the rest of the ca
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
--- Comment #34 from Tomás Cohen Arazi ---
Created attachment 129339
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129339&action=edit
Bug 29690: Add eval on metadata record fetch in details.pl when invalid MARCXML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #128541|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #128533|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #128532|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #128531|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #128530|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #128578|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
Tomás Cohen Arazi changed:
What|Removed |Added
CC||tomasco...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
--- Comment #33 from Hayley Pelham ---
Hi Jonathan,
Thanks for letting me know.
I've gone through and followed this:
https://wiki.koha-community.org/wiki/Using_Selenium_with_Koha
And made sure to install that module now.
I can ge
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
Jonathan Druart changed:
What|Removed |Added
See Also||https://bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
--- Comment #32 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #31)
> However there is a bug as the tests should return green even if the module
> is not installed. But it's not related to these patches.
Opened b
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
Hayley Pelham changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #30 f
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
--- Comment #29 from Fridolin Somers ---
((In reply to Hayley Pelham from comment #28)
> Hello,
>
> What needs signing off here?
Last patch :
Bug 29690: (follow-up) Add eval on metadata record fetch in get_marc_authors()
I bet on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
Hayley Pelham changed:
What|Removed |Added
CC||hayleypel...@catalyst.net.n
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
Bug 29690 depends on bug 27266, which changed state.
Bug 27266 Summary: Move C4::Biblio::GetMarcAuthors to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266
What|Removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
Fridolin Somers changed:
What|Removed |Added
Severity|normal |major
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
--- Comment #27 from Fridolin Somers ---
(In reply to Fridolin Somers from comment #26)
> Created attachment 128578 [details] [review]
> Bug 29690: (follow-up) Add eval on metadata record fetch in
> get_marc_authors()
@Rmaints :
Whe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
--- Comment #26 from Fridolin Somers ---
Created attachment 128578
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128578&action=edit
Bug 29690: (follow-up) Add eval on metadata record fetch in get_marc_authors()
-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
Fridolin Somers changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
Fridolin Somers changed:
What|Removed |Added
Status|Signed Off |ASSIGNED
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
Fridolin Somers changed:
What|Removed |Added
Depends on||27266
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
--- Comment #25 from Fridolin Somers ---
(In reply to Jonathan Druart from comment #24)
> (In reply to Fridolin Somers from comment #22)
> > (In reply to Martin Renvoize from comment #9)
> > > Created attachment 128487 [details] [rev
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
Jonathan Druart changed:
What|Removed |Added
Blocks||29697
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
--- Comment #24 from Jonathan Druart ---
(In reply to Fridolin Somers from comment #22)
> (In reply to Martin Renvoize from comment #9)
> > Created attachment 128487 [details] [review] [review]
> > Bug 29690: Unit test for get_compon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
--- Comment #23 from Jonathan Druart ---
Created attachment 128541
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128541&action=edit
Bug 29690: Add selenium test
--
You are receiving this mail because:
You are wa
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
--- Comment #22 from Fridolin Somers ---
(In reply to Martin Renvoize from comment #9)
> Created attachment 128487 [details] [review]
> Bug 29690: Unit test for get_components_query
Thanks a lot.
We need to also impact other unit te
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
David Nind changed:
What|Removed |Added
Attachment #128497|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
David Nind changed:
What|Removed |Added
Attachment #128487|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
David Nind changed:
What|Removed |Added
Attachment #128486|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
David Nind changed:
What|Removed |Added
Attachment #128485|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
Jonathan Druart changed:
What|Removed |Added
Attachment #128488|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
--- Comment #16 from Martin Renvoize ---
Looks great to me Jonathan, thanks for taking it on :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mai
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
--- Comment #15 from Jonathan Druart ---
Would something like this patch work for you, Martin?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
--- Comment #14 from Jonathan Druart ---
Created attachment 128488
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128488&action=edit
Bug 29690: Always warn if something is wrong with the metadata
--
You are recei
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
--- Comment #13 from Martin Renvoize ---
It would appear not.. so yes, throwing a warning in would be beneficial.
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
--- Comment #12 from Martin Renvoize ---
(In reply to Jonathan Druart from comment #11)
> Should not we at least warn?
Probably a good call.. I hate silent failures... do we not already throw a
warning from the parent as part of the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
--- Comment #11 from Jonathan Druart ---
Should not we at least warn? There is nothing else more frustrating that
investigating a problem and find that it's coming from an exception that is
being ignored.
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
--- Comment #10 from Jonathan Druart ---
> 1) Create a biblio record with invalid MARCXML (see Bug 29690)
Referring to bug 23846?
--
You are receiving this mail because:
You are watching all bug changes.
__
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
--- Comment #9 from Martin Renvoize ---
Created attachment 128487
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128487&action=edit
Bug 29690: Unit test for get_components_query
--
You are receiving this mail bec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
--- Comment #8 from Fridolin Somers ---
(In reply to Martin Renvoize from comment #7)
> It looks to me like `opac/opac-ISBDdetail.pl` and `opac/opac-showmarc.pl`
> are also affected by this.. should we fix those here too.. and perhap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
--- Comment #7 from Martin Renvoize ---
It looks to me like `opac/opac-ISBDdetail.pl` and `opac/opac-showmarc.pl` are
also affected by this.. should we fix those here too.. and perhaps introduce a
QA script check for any `->metadata-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
Martin Renvoize changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
--- Comment #6 from Martin Renvoize ---
Created attachment 128486
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128486&action=edit
Bug 29690: (follow-up) Catch other cases
This patch catches the rest of the cases
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
Martin Renvoize changed:
What|Removed |Added
Attachment #128484|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
--- Comment #4 from Martin Renvoize ---
(In reply to Martin Renvoize from comment #3)
> Could we not move the eval up a level into the record accessor itself this
> catching all cases?
OK, we already do and throw an exception.. henc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
Martin Renvoize changed:
What|Removed |Added
CC||martin.renvoize@ptfs-europ
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
Fridolin Somers changed:
What|Removed |Added
See Also||https://bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
Fridolin Somers changed:
What|Removed |Added
CC||jonathan.druart+koha@gmail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
--- Comment #2 from Fridolin Somers ---
If we are OK with this implementation, I will amend unit tests (any help is
welcome)
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
--- Comment #1 from Fridolin Somers ---
Created attachment 128484
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128484&action=edit
Bug 29690: Add eval on metadata record fetch in details.pl when invalid MARCXML
B
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
Fridolin Somers changed:
What|Removed |Added
Patch complexity|--- |Trivial patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
Fridolin Somers changed:
What|Removed |Added
Keywords||regression
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
Fridolin Somers changed:
What|Removed |Added
Depends on||23846
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
Fridolin Somers changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assign
86 matches
Mail list logo
