https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759
Tomás Cohen Arazi changed:
What|Removed |Added
Summary|Revert credit when |Refund credit when
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759
Tomás Cohen Arazi changed:
What|Removed |Added
CC||katrin.fisc...@bsz-bw.de
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759
Kyle M Hall changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are receiv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759
Kyle M Hall changed:
What|Removed |Added
Attachment #128874|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759
--- Comment #4 from Kyle M Hall ---
Created attachment 129163
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129163&action=edit
Bug 29759: Make cancelling an AR refund
This patch makes the Koha::ArticleRequest->ca
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759
Martin Renvoize changed:
What|Removed |Added
Attachment #129162|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759
Martin Renvoize changed:
What|Removed |Added
Attachment #129163|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759
--- Comment #7 from Martin Renvoize ---
hmm.. I'm still not 100% sure of this.
Scenario 1
1. Article request placed, fee added
2. Article request cancelled, fee cancelled (currently appears as a refund)
Scenario 2
1. Article reques
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759
--- Comment #8 from Martin Renvoize ---
This gives us an opportunity to create something consistent for lost item
charge refunds too
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759
--- Comment #9 from Tomás Cohen Arazi ---
(In reply to Martin Renvoize from comment #7)
> hmm.. I'm still not 100% sure of this.
>
> Scenario 1
> 1. Article request placed, fee added
> 2. Article request cancelled, fee cancelled (cu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759
--- Comment #10 from Marcel de Rooy ---
+is( abs $patron->account->balance, $payed_amount, 'The patron has been
refunded the right value' );
Frowning by intuition. abs ?
--
You are receiving this mail because:
You are watching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |BLOCKED
--- Comment #11 fr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759
--- Comment #12 from Marcel de Rooy ---
Created attachment 129297
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129297&action=edit
Bug 29757: (QA follow-up) Remove abs from the test
Obviously abs has two sides, a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759
--- Comment #13 from Marcel de Rooy ---
Created attachment 129298
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129298&action=edit
Bug 29759: (QA follow-up) Remove abs from the test
Obviously abs has two sides, a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759
Marcel de Rooy changed:
What|Removed |Added
Attachment #129297|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759
--- Comment #15 from Marcel de Rooy ---
(In reply to Tomás Cohen Arazi from comment #9)
> (In reply to Martin Renvoize from comment #7)
> > hmm.. I'm still not 100% sure of this.
> >
> > Scenario 1
> > 1. Article request placed, fee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759
--- Comment #16 from Marcel de Rooy ---
Martin, what about scenario 4:
Fee charged 10
Paid 2
Paid 3
Cancelled
Now we cannot link to "the payment" because we have two payments. We can split
the credit because we want to link to all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759
--- Comment #17 from Marcel de Rooy ---
Bit out of scope, but anyway: When I have an AR fee, I pay an amount, and then
void the payment on Transactions, I can afterwards issue a refund on the voided
credit. Should that really be poss
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759
--- Comment #18 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #16)
> Martin, what about scenario 4:
>
> Fee charged 10
> Paid 2
> Paid 3
> Cancelled
>
> Now we cannot link to "the payment" because we have two pay
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759
--- Comment #19 from Marcel de Rooy ---
And as a final note:
If we could rework $accountline->cancel someday, we could perhaps move this
code out of the article requests domain.
$debit_accountline->cancel();
Cancel a charge. It wil
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759
Marcel de Rooy changed:
What|Removed |Added
Patch complexity|--- |Small patch
St
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759
Marcel de Rooy changed:
What|Removed |Added
Attachment #129181|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759
Marcel de Rooy changed:
What|Removed |Added
Attachment #129182|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759
Marcel de Rooy changed:
What|Removed |Added
Attachment #129298|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759
Marcel de Rooy changed:
What|Removed |Added
CC||fridolin.som...@biblibre.co
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759
Fridolin Somers changed:
What|Removed |Added
Status|Passed QA |Pushed to master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759
--- Comment #24 from Fridolin Somers ---
Pushed to master for 22.05, thanks to everybody involved 🦄
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759
--- Comment #25 from Fridolin Somers ---
Oupsy looks like it breaks the test suite, see :
https://jenkins.koha-community.org/job/Koha_Master_D10/519/
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.druart+koha@gmail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759
Jonathan Druart changed:
What|Removed |Added
Keywords||additional_work_needed
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759
--- Comment #27 from Tomás Cohen Arazi ---
Created attachment 130093
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130093&action=edit
Bug 29759: (follow-up) Fix TemplateToolkit.t
This patch makes the tests set de
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759
Jonathan Druart changed:
What|Removed |Added
Attachment #130093|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759
--- Comment #29 from Tomás Cohen Arazi ---
Created attachment 130095
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130095&action=edit
Bug 29759: (follow-up) Fix api/v1/article_requests.t
This patch makes the test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759
Jonathan Druart changed:
What|Removed |Added
Attachment #130095|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759
--- Comment #31 from Fridolin Somers ---
New patches pushed to master :
b62fcec5cc Bug 29759: (follow-up) Fix api/v1/article_requests.t
8c80db886a Bug 29759: (follow-up) Fix TemplateToolkit.t
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759
Bug 29759 depends on bug 27946, which changed state.
Bug 27946 Summary: Add a charge per article request to patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946
What|Removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759
Bug 29759 depends on bug 29757, which changed state.
Bug 29757 Summary: Add filter_by_non_reversible/reversible methods for offsets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29757
What|Removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759
Kyle M Hall changed:
What|Removed |Added
Status|Pushed to master|RESOLVED
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759
Fridolin Somers changed:
What|Removed |Added
Keywords|additional_work_needed |
--
You are receiving th
39 matches
Mail list logo
