[Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net

[Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 Bug 29806 depends on bug 29807, which changed state. Bug 29807 Summary: Branches template plugin doesn't handle empty lists correctly https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29807 What|Removed

[Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 Bug 29806 depends on bug 29804, which changed state. Bug 29804 Summary: Koha::Hold->is_pickup_location_valid explodes if empty list of pickup locations https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29804 What

[Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 Andrew Fuerste-Henry changed: What|Removed |Added Version(s)|22.05.00,21.11.03

[Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 Kyle M Hall changed: What|Removed |Added Version(s)|22.05.00|22.05.00,21.11.03

[Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 --- Comment #14 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 Fridolin Somers changed: What|Removed |Added Version(s)||22.05.00 released

[Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 Tomás Cohen Arazi changed: What|Removed |Added Blocks||29844 Referenced

[Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit

[Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 --- Comment #13 from Tomás Cohen Arazi --- Hi! Thanks for the follow-up. Strictly speaking, Koha::Biblios->pickup_locations IS list context aware so this wouldn't be needed. I skipped it because of that reason, but that was before I

[Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 --- Comment #12 from Jonathan Druart --- Created attachment 129186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129186=edit Bug 29806: (follow-up) Call ->as_list for ->pickup_locations on request.pl

[Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 Jonathan Druart changed: What|Removed |Added Attachment #129132|0 |1 is obsolete|

[Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 Jonathan Druart changed: What|Removed |Added Attachment #129131|0 |1 is obsolete|

[Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 Jonathan Druart changed: What|Removed |Added Attachment #129130|0 |1 is obsolete|

[Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 David Nind changed: What|Removed |Added Attachment #129060|0 |1 is obsolete|

[Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 David Nind changed: What|Removed |Added Attachment #129058|0 |1 is obsolete|

[Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 David Nind changed: What|Removed |Added Attachment #129059|0 |1 is obsolete|

[Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 Tomás Cohen Arazi changed: What|Removed |Added Text to go in the||The release

[Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 Tomás Cohen Arazi changed: What|Removed |Added CC|

[Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 129060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129060=edit Bug 29806: Fix POST /holds use of pickup_locations This patch makes

[Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 129059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129059=edit Bug 29806: Regression tests -- You are receiving this mail because: You are watching

[Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 129058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129058=edit Bug 29806: Call ->as_list for ->pickup_locations on request.pl -- You are receiving

[Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff

[Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 --- Comment #2 from Tomás Cohen Arazi --- Koha/Template/Plugin/Branches.pm solved on bug 29807. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 Tomás Cohen Arazi changed: What|Removed |Added Depends on||29807 Referenced

[Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 --- Comment #1 from Tomás Cohen Arazi --- I did a: $ git grep '\->pickup_locations' and my (manual) findings are: Koha/Biblio.pm: ok Koha/Biblios.pm: ok Koha/Item.pm: ok Koha/REST/V1/Biblios.pm: ok Koha/REST/V1/Holds.pm: boo

[Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 Tomás Cohen Arazi changed: What|Removed |Added See Also|