[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 Fridolin Somers changed: What|Removed |Added Keywords|additional_work_needed | -- You are receiving th

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 Kyle M Hall changed: What|Removed |Added Status|Pushed to master|RESOLVED Resolution|-

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #58 from Fridolin Somers --- Follow-ups pushed to master : > git log --oneline --no-decorate --grep=29857 be74dd2edf Bug 29857: (follow-up) Fix t/db_dependent/api/v1/transfer_limits.t 94220261f2 Bug 29857: (follow-up) F

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #57 from Fridolin Somers --- Created attachment 131291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131291&action=edit Bug 29857: (follow-up) Fix t/db_dependent/api/v1/transfer_limits.t -- You are r

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #56 from Fridolin Somers --- Created attachment 131290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131290&action=edit Bug 29857: (follow-up) Fix t/db_dependent/Koha/BackgroundJobs/BatchUpdateBiblio.t

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #55 from Fridolin Somers --- Created attachment 131289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131289&action=edit Bug 29857: (follow-up) Fix t/db_dependent/Koha/Club/Hold.t -- You are receiving

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #54 from Fridolin Somers --- Created attachment 131288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131288&action=edit Bug 29857: (follow-up) Fix t/db_dependent/Koha/Plugins/Plugins.t -- You are rec

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #53 from Fridolin Somers --- Created attachment 131287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131287&action=edit Bug 29857: (follow-up) Fix t/Koha/REST/Plugin/Query.t -- You are receiving this

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #52 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #51) > Just in case: I'm submitting the fixes one by one just in case I need to > leave and cannot complete the fixes. But this could just be pushed

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #51 from Tomás Cohen Arazi --- Just in case: I'm submitting the fixes one by one just in case I need to leave and cannot complete the fixes. But this could just be pushed on a single commit. -- You are receiving this ma

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #50 from Tomás Cohen Arazi --- Created attachment 131258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131258&action=edit Bug 29857: (follow-up) Fix t/db_dependent/Koha/Patron/Modifications.t Signed-o

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #49 from Tomás Cohen Arazi --- Created attachment 131256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131256&action=edit Bug 29857: (follow-up) Fix t/db_dependent/Auth.t Signed-off-by: Tomas Cohen Ar

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #48 from Tomás Cohen Arazi --- Created attachment 131244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131244&action=edit Bug 29857: (follow-up) Fix t/Koha/Email.t Signed-off-by: Tomas Cohen Arazi -

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #47 from Tomás Cohen Arazi --- Created attachment 131243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131243&action=edit Bug 29857: (follow-up) Fix t/Koha/Object/Message.t Signed-off-by: Tomas Cohen

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #46 from Tomás Cohen Arazi --- Created attachment 131242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131242&action=edit Bug 29857: (follow-up) Fix t/db_dependent/Koha/Biblio.t Signed-off-by: Tomas C

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #45 from Tomás Cohen Arazi --- Created attachment 131241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131241&action=edit Bug 29857: (follow-up) Fix t/Koha/Plugins/Tab.t Signed-off-by: Tomas Cohen Ara

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #44 from Tomás Cohen Arazi --- Created attachment 131240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131240&action=edit Bug 29857: (follow-up) Fix Barcode_transform_hooks.t Signed-off-by: Tomas Cohe

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 Fridolin Somers changed: What|Removed |Added Keywords||additional_work_needed --

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #43 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 Fridolin Somers changed: What|Removed |Added Status|Passed QA |Pushed to master

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.c

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #41 from Fridolin Somers --- Created attachment 131232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131232&action=edit Bug 29857: (QA follow-up) Fix unit test Object.t Unit test failling with : #

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #40

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 Martin Renvoize changed: What|Removed |Added QA Contact|m.de.r...@rijksmuseum.nl|martin.renvoize@ptfs-europ

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 Martin Renvoize changed: What|Removed |Added Attachment #130355|0 |1 is obsolete|

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 Martin Renvoize changed: What|Removed |Added Attachment #130015|0 |1 is obsolete|

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 Martin Renvoize changed: What|Removed |Added Attachment #130014|0 |1 is obsolete|

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 Martin Renvoize changed: What|Removed |Added Attachment #130009|0 |1 is obsolete|

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 Martin Renvoize changed: What|Removed |Added Attachment #130008|0 |1 is obsolete|

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 Martin Renvoize changed: What|Removed |Added Attachment #130007|0 |1 is obsolete|

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #33 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #25) > I don't understand why the "Virtualshelves exceptions" part is in > Koha::Exception::Generic. I filed bug 30057 and submitted patches. Test

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #32 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #22) > (In reply to Marcel de Rooy from comment #21) > > Created attachment 130156 [details] [review] [review] > > Bug 29857: (CONCEPT) Switch to sin

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #31 from Tomás Cohen Arazi --- Created attachment 130355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130355&action=edit Bug 29857: (QA follow-up) Add license Signed-off-by: Tomas Cohen Arazi -- Y

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 Tomás Cohen Arazi changed: What|Removed |Added Attachment #130158|0 |1 is obsolete|

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 Tomás Cohen Arazi changed: What|Removed |Added Attachment #130157|0 |1 is obsolete|

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 Tomás Cohen Arazi changed: What|Removed |Added Blocks||30057 Referenced Bugs:

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #30 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #25) > IMO we are going too far here. Please provide patches on follow-up bug > reports instead. Heh. I see this happen all the time :) As to singular

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #29 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #25) > IMO we are going too far here. Please provide patches on follow-up bug > reports instead. > > I don't understand why the "Virtualshelves except

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #28 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #27) > (In reply to Jonathan Druart from comment #26) > > (In reply to Marcel de Rooy from comment #19) > > > (In reply to Jonathan Druart from comment

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #27 from Jonathan Druart --- (In reply to Jonathan Druart from comment #26) > (In reply to Marcel de Rooy from comment #19) > > (In reply to Jonathan Druart from comment #0) > > > We must have a generic full_message metho

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #26 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #19) > (In reply to Jonathan Druart from comment #0) > > We must have a generic full_message method in the Koha::Exceptions base > > class to display a

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #25 from Jonathan Druart --- IMO we are going too far here. Please provide patches on follow-up bug reports instead. I don't understand why the "Virtualshelves exceptions" part is in Koha::Exception::Generic. -- You ar

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 Marcel de Rooy changed: What|Removed |Added Attachment #130156|0 |1 is obsolete|

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #23 from Marcel de Rooy --- Created attachment 130157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130157&action=edit Bug 29857: (QA follow-up) Add license -- You are receiving this mail because: Yo

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #22 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #21) > Created attachment 130156 [details] [review] > Bug 29857: (CONCEPT) Switch to singular, add a load method > > The load method calls the Class::E

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #21 from Marcel de Rooy --- Created attachment 130156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130156&action=edit Bug 29857: (CONCEPT) Switch to singular, add a load method The load method calls

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Signed Off --- Comment #20

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #19 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #0) > We must have a generic full_message method in the Koha::Exceptions base > class to display all the info we have about the exception. > The curren

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 Tomás Cohen Arazi changed: What|Removed |Added Blocks||30007 Referenced Bugs:

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #17 from Martin Renvoize --- Dude, this is a great set of follow-ups. Will work through them properly and test it tomorrow -- You are receiving this mail because: You are watching all bug changes. __

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 Tomás Cohen Arazi changed: What|Removed |Added Attachment #130013|0 |1 is obsolete|

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 Tomás Cohen Arazi changed: What|Removed |Added Attachment #130012|0 |1 is obsolete|

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #14 from Tomás Cohen Arazi --- I renamed the 'base' exception class to Koha::Exception as it is something I wanted to do for a long time already. Beware the package/file name doesn't need to match the exception name in Ex

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 Tomás Cohen Arazi changed: What|Removed |Added Attachment #130011|0 |1 is obsolete|

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 Tomás Cohen Arazi changed: What|Removed |Added Attachment #130010|0 |1 is obsolete|

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #11 from Tomás Cohen Arazi --- Created attachment 130011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130011&action=edit Bug 29857: Fix behavior This patch makes: - passed parameters be rendered alph

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #10 from Tomás Cohen Arazi --- Created attachment 130010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130010&action=edit Bug 29857: Unit tests Signed-off-by: Tomas Cohen Arazi -- You are receiving

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #9 from Tomás Cohen Arazi --- Created attachment 130009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130009&action=edit Bug 29857: Rename base class as Koha::Exception Signed-off-by: Tomas Cohen Araz

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #8 from Tomás Cohen Arazi --- Created attachment 130008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130008&action=edit Bug 29857: Provide a generic full_message method for our exceptions We pass use

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #7 from Tomás Cohen Arazi --- Created attachment 130007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130007&action=edit Bug 29857: Make the exception classes inherit from the base class We have a bas

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 Tomás Cohen Arazi changed: What|Removed |Added Attachment #129330|0 |1 is obsolete|

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 Tomás Cohen Arazi changed: What|Removed |Added Attachment #129329|0 |1 is obsolete|

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch comp

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 Tomás Cohen Arazi changed: What|Removed |Added CC||k...@bywatersolutions.co

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 Jonathan Druart changed: What|Removed |Added Status|In Discussion |Needs Signoff --- Comment

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #5 from Martin Renvoize --- What are the next steps here, discussion wise. I'm on board with the change myself and would happily sign off as is.. were there any particular points you wanted to raise/question Jonathan? --

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #4 from Martin Renvoize --- This seems a solid improvement to me.. honestly I've found our exceptions confusing to work with.. creating new ones and all the classes all over the place.. this works towards making them all

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 Jonathan Druart changed: What|Removed |Added CC||martin.renvoize@ptfs-europ

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #2 from Jonathan Druart --- Created attachment 129330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129330&action=edit Bug 29857: Provide a generic full_message method for our exceptions We pass usefu

[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #1 from Jonathan Druart --- Created attachment 129329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129329&action=edit Bug 29857: Make the exception classes inherit from the base class We have a base