[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Jonathan Druart changed: What|Removed |Added Blocks||32923 --- Comment #36

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 --- Comment #35 from Martin Renvoize --- I spotted this the other day too and was surprised to see it had come out of sync so quickly. Yes, we should update the guidelines and perhaps even add a QA script to prevent new

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Martin Renvoize changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Kyle M Hall changed: What|Removed |Added Resolution|--- |FIXED

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 --- Comment #33 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Fridolin Somers changed: What|Removed |Added Version(s)||22.05.00 released

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Marcel de Rooy changed: What|Removed |Added Attachment #134484|0 |1 is obsolete|

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Marcel de Rooy changed: What|Removed |Added Attachment #134483|0 |1 is obsolete|

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Marcel de Rooy changed: What|Removed |Added Attachment #134482|0 |1 is obsolete|

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Marcel de Rooy changed: What|Removed |Added Attachment #134481|0 |1 is obsolete|

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Marcel de Rooy changed: What|Removed |Added Attachment #134480|0 |1 is obsolete|

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Marcel de Rooy changed: What|Removed |Added Attachment #134479|0 |1 is obsolete|

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA Patch

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 --- Comment #25 from Martin Renvoize --- Created attachment 134484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134484=edit Bug 30536: Fix Query.t Unit Test The stash_embed method no longer validates the query

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 --- Comment #24 from Martin Renvoize --- Created attachment 134483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134483=edit Bug 30536: (QA follow-up) POD + Spec Consistency Well spotted, this patch fixes the

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Martin Renvoize changed: What|Removed |Added Attachment #10|0 |1 is obsolete|

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Martin Renvoize changed: What|Removed |Added Attachment #133329|0 |1 is obsolete|

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Martin Renvoize changed: What|Removed |Added Attachment #133328|0 |1 is obsolete|

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Martin Renvoize changed: What|Removed |Added Attachment #133327|0 |1 is obsolete|

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Failed QA --- Comment #19

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED QA

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Martin Renvoize changed: What|Removed |Added Severity|enhancement |normal -- You are

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Victor Grousset/tuxayo changed: What|Removed |Added Patch complexity|--- |Medium patch

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Martin Renvoize changed: What|Removed |Added Blocks||30385 Referenced Bugs:

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Bug 30536 depends on bug 29810, which changed state. Bug 29810 Summary: Add embed options documentation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 What|Removed |Added

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 --- Comment #17 from Tomás Cohen Arazi --- Created attachment 10 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10=edit Bug 30536: Update spec files This patch removes superflous x-koha-embed defintions

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 --- Comment #16 from Tomás Cohen Arazi --- Created attachment 133329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133329=edit Bug 30536: Remove validation overhead With the introduction of proper validation of

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 --- Comment #15 from Tomás Cohen Arazi --- Created attachment 133328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133328=edit Bug 30536: Refer to parameters enum This patch updates the stash_embed method to use

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 --- Comment #14 from Tomás Cohen Arazi --- Created attachment 133327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133327=edit Bug 30536: Unit tests This patch adds tests to make sure there's no behavior change

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Tomás Cohen Arazi changed: What|Removed |Added Attachment #133325|0 |1 is obsolete|

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Tomás Cohen Arazi changed: What|Removed |Added Attachment #133324|0 |1 is obsolete|

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Tomás Cohen Arazi changed: What|Removed |Added Attachment #133313|0 |1 is obsolete|

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff ---

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 --- Comment #12 from Martin Renvoize --- Created attachment 133325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133325=edit Bug 30536: Update spec files This patch removes superflous x-koha-embed defintions at

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Martin Renvoize changed: What|Removed |Added Attachment #133314|0 |1 is obsolete|

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Martin Renvoize changed: What|Removed |Added Attachment #133316|0 |1 is obsolete|

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Martin Renvoize changed: What|Removed |Added Attachment #133315|0 |1 is obsolete|

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 --- Comment #10 from Martin Renvoize --- Created attachment 133316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133316=edit Bug 30536: Use objects->find in SMTP Servers controller This patch removes the direct

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 --- Comment #9 from Martin Renvoize --- Created attachment 133315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133315=edit Bug 30536: Use objects->find in Cashups controller This patch removes the direct

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Martin Renvoize changed: What|Removed |Added Attachment #133309|0 |1 is obsolete|

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Martin Renvoize changed: What|Removed |Added Attachment #133303|0 |1 is obsolete|

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 --- Comment #6 from Martin Renvoize --- I'm still pottering here.. if we can move the call later, after validation has taken place, we can save ourselves both the validation and param extraction overhead. Not sure how far down the

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 --- Comment #5 from Martin Renvoize --- Created attachment 133309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133309=edit Bug 30536: Remove validation overhead With the introduction of proper validation of

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 --- Comment #4 from Martin Renvoize --- Attached a first draft for golfing.. I have a hunch we can now drop at least some of the local validation we're doing in this method as we now validate properly at the openapi plugin level?

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 --- Comment #3 from Martin Renvoize --- Created attachment 133303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133303=edit Bug 30536: Refer to parameters enum This patch updates the stash_embed method to use

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 --- Comment #2 from Martin Renvoize --- Description copied from bug 30542 - I jumped before I found this bug.. haha >Now that we're documenting, and properly validating, the x-koha-embed >parameter we can actually use this

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 --- Comment #1 from Martin Renvoize --- *** Bug 30542 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Tomás Cohen Arazi changed: What|Removed |Added CC|

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Tomás Cohen Arazi changed: What|Removed |Added CC|

[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Tomás Cohen Arazi changed: What|Removed |Added Depends on||29810 Referenced