[Koha-bugs] [Bug 30943] Make background job classes use helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 Matt Blenkinsop changed: What|Removed |Added Status|Pushed to master|RESOLVED Resoluti

[Koha-bugs] [Bug 30943] Make background job classes use helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 --- Comment #26 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 30943] Make background job classes use helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master

[Koha-bugs] [Bug 30943] Make background job classes use helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 --- Comment #25 from Kyle M Hall --- Created attachment 148080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148080&action=edit Bug 30943: Fix test Signed-off-by: Kyle M Hall -- You are receiving this mail bec

[Koha-bugs] [Bug 30943] Make background job classes use helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 --- Comment #24 from Kyle M Hall --- Created attachment 148079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148079&action=edit Bug 30943: Adjust CreateEHoldingsFromBiblios Signed-off-by: Kyle M Hall -- You ar

[Koha-bugs] [Bug 30943] Make background job classes use helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 Kyle M Hall changed: What|Removed |Added Attachment #147765|0 |1 is obsolete|

[Koha-bugs] [Bug 30943] Make background job classes use helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receivi

[Koha-bugs] [Bug 30943] Make background job classes use helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net

[Koha-bugs] [Bug 30943] Make background job classes use helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #145958|0 |1 is obsole

[Koha-bugs] [Bug 30943] Make background job classes use helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #145957|0 |1 is obsole

[Koha-bugs] [Bug 30943] Make background job classes use helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #144340|0 |1 is obsole

[Koha-bugs] [Bug 30943] Make background job classes use helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Patch doesn't apply -- Yo

[Koha-bugs] [Bug 30943] Make background job classes use helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 Bug 30943 depends on bug 32779, which changed state. Bug 32779 Summary: Import from list is broken https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32779 What|Removed |Added ---

[Koha-bugs] [Bug 30943] Make background job classes use helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 Jonathan Druart changed: What|Removed |Added Depends on||32779 Referenced Bugs:

[Koha-bugs] [Bug 30943] Make background job classes use helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 Jonathan Druart changed: What|Removed |Added Blocks||32781 Referenced Bugs:

[Koha-bugs] [Bug 30943] Make background job classes use helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 Jonathan Druart changed: What|Removed |Added Depends on|32779 | Referenced Bugs: https

[Koha-bugs] [Bug 30943] Make background job classes use helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 Jonathan Druart changed: What|Removed |Added Blocks|32781 | Referenced Bugs: https

[Koha-bugs] [Bug 30943] Make background job classes use helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 Jonathan Druart changed: What|Removed |Added Depends on||32779 --- Comment #18 fro

[Koha-bugs] [Bug 30943] Make background job classes use helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 --- Comment #17 from Jonathan Druart --- Created attachment 145958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145958&action=edit Bug 30943: Fix test -- You are receiving this mail because: You are watching al

[Koha-bugs] [Bug 30943] Make background job classes use helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 --- Comment #16 from Jonathan Druart --- Created attachment 145957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145957&action=edit Bug 30943: Adjust CreateEHoldingsFromBiblios -- You are receiving this mail bec

[Koha-bugs] [Bug 30943] Make background job classes use helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 Jonathan Druart changed: What|Removed |Added Blocks||32781 Referenced Bugs:

[Koha-bugs] [Bug 30943] Make background job classes use helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 --- Comment #15 from Jonathan Druart --- Also, as discussed earlier, I would suggest to rename (on a separate bug report) ->start and ->finish to ->mark_as_started and ->mark_as_finished (or anything similar) to remove the ambiguity.

[Koha-bugs] [Bug 30943] Make background job classes use helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 --- Comment #14 from Jonathan Druart --- I am all for this change, but I don't think it should be pushed before we stabilize this area a bit. There are bug fixes with higher priority. I would like to note 2 things here: 1. the tidy

[Koha-bugs] [Bug 30943] Make background job classes use helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 Marcel de Rooy changed: What|Removed |Added Status|In Discussion |Signed Off --- Comment #13

[Koha-bugs] [Bug 30943] Make background job classes use helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 --- Comment #12 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #11) > Please read the history on both bugs. On bug 32305, they discuss the Koha::BackgroundJob->process method, making it not initiate a background

[Koha-bugs] [Bug 30943] Make background job classes use helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 --- Comment #11 from Marcel de Rooy --- Please read the history on both bugs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bug

[Koha-bugs] [Bug 30943] Make background job classes use helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --

[Koha-bugs] [Bug 30943] Make background job classes use helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |In Discussion --- Comment

[Koha-bugs] [Bug 30943] Make background job classes use helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 --- Comment #8 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #7) > OK.. I think this patchset if solid as is if we push the process fix first > that checks for status... > > Having both process and start metho

[Koha-bugs] [Bug 30943] Make background job classes use helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 --- Comment #7 from Martin Renvoize --- OK.. I think this patchset if solid as is if we push the process fix first that checks for status... Having both process and start methods is slightly confusing at first ;P -- You are receiv

[Koha-bugs] [Bug 30943] Make background job classes use helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 --- Comment #6 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #5) > One example: if a task has already been started, and it is asked to start > again, should we proceed? Should we alert? See also bug 32305. --

[Koha-bugs] [Bug 30943] Make background job classes use helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 --- Comment #5 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #4) > > Should we be wrapping calls to start in a try/catch to just skip the job or > something instead..? Yes, absolutely. In theory, as written ri

[Koha-bugs] [Bug 30943] Make background job classes use helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #4

[Koha-bugs] [Bug 30943] Make background job classes use helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 Martin Renvoize changed: What|Removed |Added Attachment #140329|0 |1 is obsolete|

[Koha-bugs] [Bug 30943] Make background job classes use helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 Tomás Cohen Arazi changed: What|Removed |Added CC||jonathan.druart+koha@gma

[Koha-bugs] [Bug 30943] Make background job classes use helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 Tomás Cohen Arazi changed: What|Removed |Added Blocks||32370 Referenced Bugs:

[Koha-bugs] [Bug 30943] Make background job classes use helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You a

[Koha-bugs] [Bug 30943] Make background job classes use helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 140329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140329&action=edit Bug 30943: Simplify background jobs code using helpers This patch makes the cur

[Koha-bugs] [Bug 30943] Make background job classes use helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- Y

[Koha-bugs] [Bug 30943] Make background job classes use helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |ASSIGNED -- You are re

[Koha-bugs] [Bug 30943] Make background job classes use helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 Tomás Cohen Arazi changed: What|Removed |Added Depends on||31351 Referenced Bugs:

[Koha-bugs] [Bug 30943] Make background job classes use helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com