[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 --- Comment #36 from Jonathan Druart --- (In reply to Jonathan Druart from comment #30) > Passing QA, but I don't think we should start with no value (and a free > input text). > I think it would be better to have few values (to

[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 Katrin Fischer changed: What|Removed |Added Blocks||33004 Referenced Bugs:

[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 Caroline Cyr La Rose changed: What|Removed |Added Status|Needs documenting |RESOLVED

[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 Caroline Cyr La Rose changed: What|Removed |Added Blocks||33003 Referenced

[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 Katrin Fischer changed: What|Removed |Added Resolution|FIXED |---

[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 Lucas Gass changed: What|Removed |Added Resolution|--- |FIXED CC|

[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 --- Comment #34 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00

[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com

[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 --- Comment #32 from Nick Clemens --- Created attachment 139007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139007=edit Bug 31017: (follow-up) Add type field to api -- You are receiving this mail because: You

[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 --- Comment #31 from Jonathan Druart --- (In reply to Jonathan Druart from comment #30) > Letting author and RM decide. This could be done separately (but before > 21.11 ideally). Ha, apparently we are (already!) working for

[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 --- Comment #30 from Jonathan Druart --- Passing QA, but I don't think we should start with no value (and a free input text). I think it would be better to have few values (to show what could be possible values) that could even be

[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 --- Comment #29 from Jonathan Druart --- Created attachment 138967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138967=edit Bug 31017: DO NOT PUSH - Schema updates Signed-off-by: Jonathan Druart -- You are

[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 --- Comment #28 from Jonathan Druart --- Created attachment 138966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138966=edit Bug 31017: Update field name to 'type' Signed-off-by: Jonathan Druart -- You are

[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 --- Comment #27 from Jonathan Druart --- Created attachment 138965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138965=edit Bug 31017: Add new vendor_type field to edit screen and display This patch adds a new

[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 Jonathan Druart changed: What|Removed |Added Attachment #138942|0 |1 is obsolete|

[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 --- Comment #25 from Nick Clemens --- Created attachment 138945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138945=edit Bug 31017: DO NOT PUSH - Schema updates -- You are receiving this mail because: You are

[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 --- Comment #24 from Nick Clemens --- Created attachment 138944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138944=edit Bug 31017: Update field name to 'type' -- You are receiving this mail because: You are

[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 --- Comment #23 from Nick Clemens --- Created attachment 138943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138943=edit Bug 31017: Add new vendor_type field to edit screen and display This patch adds a new

[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 Nick Clemens changed: What|Removed |Added Attachment #138116|0 |1 is obsolete|

[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 --- Comment #21 from Jonathan Druart --- I've used 'type' a lot for ERM, and it always feel wrong/too generic. If you are happy with 'type', go for it :) -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 --- Comment #20 from Nick Clemens --- (In reply to Jonathan Druart from comment #16) > What would be real-life values? For the library requesting this it was values like: Copyright holder Donor Book vendor etc. It's really a way

[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 --- Comment #19 from Caroline Cyr La Rose --- Nick also mentioned other classifications in the bug description > Some libraries have many vendors, and they serve different purposes e.g. > booksellers vs donors vs electronic

[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 --- Comment #18 from Caroline Cyr La Rose --- (In reply to Katrin Fischer from comment #17) > (In reply to Jonathan Druart from comment #16) > > What would be real-life values? > > I thought this was related to the ERM work tbh :)

[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 --- Comment #17 from Katrin Fischer --- (In reply to Jonathan Druart from comment #16) > What would be real-life values? I thought this was related to the ERM work tbh :) Examples could be: Consortium, Library, Platform, Vendor

[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 --- Comment #16 from Jonathan Druart --- What would be real-life values? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 --- Comment #15 from Nick Clemens --- (In reply to Jonathan Druart from comment #14) > I mean, why is the DB column named "vendor_type"? We are not supposed to > repeat the table's name in the column's name (aqbooksellers must be

[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 --- Comment #14 from Jonathan Druart --- I mean, why is the DB column named "vendor_type"? We are not supposed to repeat the table's name in the column's name (aqbooksellers must be named vendor). Yes, 'type' is a terrible naming,

[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 Caroline Cyr La Rose changed: What|Removed |Added Text to go in the||This enhancement

[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 Katrin Fischer changed: What|Removed |Added Attachment #136444|0 |1 is obsolete|

[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 ByWater Sandboxes changed: What|Removed |Added Attachment #136443|0 |1 is obsolete|

[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 --- Comment #11 from ByWater Sandboxes --- Created attachment 138117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138117=edit Bug 31017: DO NOT PUSH - Schema updates Signed-off-by: KIT Library Germany -- You

[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 ByWater Sandboxes changed: What|Removed |Added Attachment #137134|0 |1 is obsolete|

[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 Victor Grousset/tuxayo changed: What|Removed |Added Patch complexity|--- |Small patch --

[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 MichaelaSieber changed: What|Removed |Added CC||michaela.sie...@kit.edu

[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 Caroline Cyr La Rose changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You

[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 ByWater Sandboxes changed: What|Removed |Added Attachment #136903|0 |1 is obsolete|

[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 Nick Clemens changed: What|Removed |Added Attachment #136445|0 |1 is obsolete|

[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 Rachael changed: What|Removed |Added CC||rachael.lar...@inlibro.com ---

[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 --- Comment #6 from David Nind --- (In reply to Caroline Cyr La Rose from comment #5) > To answer David' second comment, I think it is ok to have either free text > or authorised value. It is the same about everywhere in Koha:

[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 Caroline Cyr La Rose changed: What|Removed |Added Status|Needs Signoff |Failed QA

[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 David Nind changed: What|Removed |Added CC||da...@davidnind.com ---

[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 Nick Clemens changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de

[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 --- Comment #3 from Nick Clemens --- Created attachment 136445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136445=edit Bug 31017: Add new vendor_type field to edit screena dn display This patch adds a new

[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 --- Comment #2 from Nick Clemens --- Created attachment 136444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136444=edit Bug 31017: DO NOT PUSH - Schema updates -- You are receiving this mail because: You are

[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 --- Comment #1 from Nick Clemens --- Created attachment 136443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136443=edit Bug 31017: DB Updates -- You are receiving this mail because: You are watching all bug

[Koha-bugs] [Bug 31017] Add type field for vendors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are