[Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #30 from Johanna Räisä --- (In reply to Nick Clemens from comment #29) > (In reply to Johanna Räisä from comment #28) > > This is already pushed to stable but I think the > > AllowRenewalIfOtherItemsAvailable syspref is

[Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #29 from Nick Clemens --- (In reply to Johanna Räisä from comment #28) > This is already pushed to stable but I think the > AllowRenewalIfOtherItemsAvailable syspref is misleading, there is nowhere > information that

[Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 Johanna Räisä changed: What|Removed |Added CC||johanna.ra...@koha-suomi.fi

[Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 Nick Clemens changed: What|Removed |Added Blocks||32878 Referenced Bugs:

[Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 Arthur Suzuki changed: What|Removed |Added CC||arthur.suz...@biblibre.com

[Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com

[Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #25 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master

[Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #24 from Kyle M Hall --- Created attachment 139735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139735=edit Bug 31112: (QA follow-up) Reduce database queries Signed-off-by: Kyle M Hall -- You are

[Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #23 from Kyle M Hall --- Created attachment 139734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139734=edit Bug 31112: (follow-up) Don't return "on_reserve" when there are 0 possible holds It's

[Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #22 from Kyle M Hall --- Created attachment 139733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139733=edit Bug 31112: (follow-up) Bring back the check for non-priority holds Before the changes from

[Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #21 from Kyle M Hall --- Created attachment 139732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139732=edit Bug 31112: (QA follow-up) Fetch patrons with reserves Previously we fetched all in a

[Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #20 from Kyle M Hall --- Created attachment 139731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139731=edit Bug 31112: (QA follow-up) Restore check to avoid extra processing We now count all holds

[Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #19 from Kyle M Hall --- Created attachment 139730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139730=edit Bug 31112: CanBookBeRenewed: take into account patrons with more than 1 hold to a biblio

[Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 Kyle M Hall changed: What|Removed |Added Attachment #139492|0 |1 is obsolete|

[Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #17 from Joonas Kylmälä --- Thanks Kyle for spotting the failing test. I fixed the issue by restoring the previous check that I had accidentally removed (btw, the check looks somewhat buggy actually but that's for

[Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #16 from Joonas Kylmälä --- Created attachment 139623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139623=edit Bug 31112: (follow-up) Don't return "on_reserve" when there are 0 possible holds It's

[Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #15 from Joonas Kylmälä --- Created attachment 139622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139622=edit Bug 31112: (follow-up) Bring back the check for non-priority holds Before the changes

[Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #14 from Kyle M Hall --- prove t/db_dependent/Holds.t t/db_dependent/Holds.t .. 69/75 # Failed test 'Can renew' # at t/db_dependent/Holds.t line 1528. # Failed test 'Item is on non priority hold' #

[Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 Kyle M Hall changed: What|Removed |Added Blocks||31436 Referenced Bugs:

[Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #13 from Joonas Kylmälä --- Thanks for the review Nick! :) (In reply to Nick Clemens from comment #12) > I reinstated the test for early exit - this is still a valid performance > boost - we can't fill all holds if we

[Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #12 from Nick Clemens --- I reinstated the test for early exit - this is still a valid performance boost - we can't fill all holds if we don't have enough items Also added a prefetch to avoid single calls for each

[Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #11 from Nick Clemens --- Created attachment 139495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139495=edit Bug 31112: (QA follow-up) Fetch patrons with reserves Previously we fetched all in a

[Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #10 from Nick Clemens --- Created attachment 139494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139494=edit Bug 31112: (QA follow-up) Restore check to avoid extra processing We now count all holds

[Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #9 from Nick Clemens --- Created attachment 139493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139493=edit Bug 31112: CanBookBeRenewed: take into account patrons with more than 1 hold to a biblio

[Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 Nick Clemens changed: What|Removed |Added Attachment #137856|0 |1 is obsolete|

[Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 Kyle M Hall changed: What|Removed |Added QA Contact|k...@bywatersolutions.com |n...@bywatersolutions.com --

[Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com

[Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 Sally changed: What|Removed |Added Status|Needs Signoff |Signed Off CC|

[Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 sandbo...@biblibre.com changed: What|Removed |Added Attachment #137828|0 |1 is

[Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 sandbo...@biblibre.com changed: What|Removed |Added Attachment #137827|0 |1 is

[Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 sandbo...@biblibre.com changed: What|Removed |Added Attachment #137826|0 |1 is

[Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 Joonas Kylmälä changed: What|Removed |Added Patch complexity|--- |Small patch Text to go

[Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #3 from Joonas Kylmälä --- Created attachment 137828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137828=edit Bug 31112: CanBookBeRenewed: take into account patrons with more than 1 hold to a biblio

[Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #2 from Joonas Kylmälä --- Created attachment 137827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137827=edit Bug 31112: Remove unit test that forces specific internal implementation To test: 1)

[Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #1 from Joonas Kylmälä --- Created attachment 137826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137826=edit Bug 31112: Remove unnecessary if-clause To test: 1) Please check manually that the

[Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 Joonas Kylmälä changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are

[Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 Joonas Kylmälä changed: What|Removed |Added Status|NEW |ASSIGNED