https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
Martin Renvoize changed:
What|Removed |Added
Depends on||30360
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
Martin Renvoize changed:
What|Removed |Added
Depends on||30889
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
Martin Renvoize changed:
What|Removed |Added
CC||martin.renvoize@ptfs-europ
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
Tomás Cohen Arazi changed:
What|Removed |Added
Blocks||32370
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
Marcel de Rooy changed:
What|Removed |Added
Blocks||32242
Referenced Bugs:
h
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
Jonathan Druart changed:
What|Removed |Added
CC||ha...@orex.es
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
Arthur Suzuki changed:
What|Removed |Added
CC||arthur.suz...@biblibre.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
Lucas Gass changed:
What|Removed |Added
Keywords|rel_22_05_candidate |
--
You are receiving this ma
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
Lucas Gass changed:
What|Removed |Added
Status|Pushed to master|Pushed to stable
Versi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
Tomás Cohen Arazi changed:
What|Removed |Added
Keywords||rel_22_05_candidate
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
Katrin Fischer changed:
What|Removed |Added
CC||lu...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
--- Comment #36 from Marcel de Rooy ---
(In reply to Tomás Cohen Arazi from comment #34)
> Ok, I'll take a look again. I loved the added tests the most.
Thanks, Tomas.
--
You are receiving this mail because:
You are watching all b
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
--- Comment #35 from Tomás Cohen Arazi ---
Pushed to master for 22.11.
Nice work everyone, thanks!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
Tomás Cohen Arazi changed:
What|Removed |Added
Version(s)||22.11.00
release
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
Tomás Cohen Arazi changed:
What|Removed |Added
Blocks||30943
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Failed QA |Passed QA
--- Comment #
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
--- Comment #33 from Marcel de Rooy ---
(In reply to Tomás Cohen Arazi from comment #32)
> FTR: the JSON::encode_json and JSON::decode_json methods deal with UTF-8 [1]
> and I'm not sure why there's a ->utf8(0) being set.
>
> Overal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
--- Comment #32 from Tomás Cohen Arazi ---
FTR: the JSON::encode_json and JSON::decode_json methods deal with UTF-8 [1]
and I'm not sure why there's a ->utf8(0) being set.
Overall, I think we should go the bug 30943 path. Take Updat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Passed QA |Failed QA
--- Comment #
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
Marcel de Rooy changed:
What|Removed |Added
Attachment #140312|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
Marcel de Rooy changed:
What|Removed |Added
Attachment #140313|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
--- Comment #29 from Marcel de Rooy ---
Created attachment 140314
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140314&action=edit
Bug 31351: (QA follow-up) Adjust tests accordingly
Test plan:
Run t/db_dependent/
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
--- Comment #28 from Marcel de Rooy ---
Oops wrong bug number. Hold on
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
--- Comment #27 from Marcel de Rooy ---
Note for Jonathan: Left a TODO in background_jobs_worker.pl where we read data
from the message broker.
--
You are receiving this mail because:
You are watching all bug changes.
_
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
Marcel de Rooy changed:
What|Removed |Added
CC||jonathan.druart+koha@gmail.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
Marcel de Rooy changed:
What|Removed |Added
CC||tomasco...@gmail.com
--
Y
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
--- Comment #26 from Marcel de Rooy ---
Hmm. This was a bit heavier than expected. We could squash when backporting.
Happy to assist RMaints if needed. Should not be that hard, new code. Not sure
how far we come with backports btw.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
--- Comment #25 from Marcel de Rooy ---
Created attachment 140313
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140313&action=edit
Bug 31351: (QA follow-up) Extend the encode/decode test
Adding some Unicode stuff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
--- Comment #24 from Marcel de Rooy ---
Created attachment 140312
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140312&action=edit
Bug 13351: (QA follow-up) Adjust tests accordingly
Test plan:
Run t/db_dependent/
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
--- Comment #23 from Marcel de Rooy ---
Created attachment 140311
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140311&action=edit
Bug 31351: (QA follow-up) Use $self->json in Background modules
Making the disabl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
Marcel de Rooy changed:
What|Removed |Added
Attachment #140262|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
Marcel de Rooy changed:
What|Removed |Added
Status|BLOCKED |Passed QA
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
--- Comment #21 from Marcel de Rooy ---
And misc/background_jobs_worker.pl itself needed attention,,
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
--- Comment #20 from Marcel de Rooy ---
Still extending the encode/decode subtest now a bit
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
--- Comment #19 from Marcel de Rooy ---
This is a pity, but we'll manage:
Koha/BackgroundJob/BatchCancelHold.pm | 7 +++--- NO TESTS
Koha/BackgroundJob/BatchDeleteAuthority.pm| 7 +++--- NO TESTS
Koha/BackgroundJob/Ba
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
--- Comment #18 from Marcel de Rooy ---
Koha/BackgroundJobs/BatchUpdateBiblio.t:use JSON qw( encode_json decode_json );
Koha/BackgroundJobs/BatchUpdateBiblio.t:my $data = decode_json
$job->get_from_storage->data;
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
--- Comment #17 from Marcel de Rooy ---
Out of scope but possible candidates for inspection too ;)
root@master:/usr/share/koha# git grep decode_json
C4/Search/History.pm:use JSON qw( decode_json encode_json );
C4/Search/History.pm:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
--- Comment #16 from Marcel de Rooy ---
And this module
package t::lib::Koha::BackgroundJob::BatchTest;
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
--- Comment #15 from Marcel de Rooy ---
We need to adjust the test too btw
t/db_dependent/Koha/BackgroundJob.t
Contains a rather simple test set:
subtest 'decoded_data() and set_encoded_data() tests' => sub {
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
--- Comment #14 from Marcel de Rooy ---
When using the functional interface of the JSON module we should have used
to_json and from_json instead of decode/encode. This would require less code
changes here, but the author actually rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
--- Comment #13 from Marcel de Rooy ---
For starters, we could have added a test. Maybe I will..
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs ma
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |BLOCKED
--- Comment #12 fr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
Marcel de Rooy changed:
What|Removed |Added
Component|Searching |Architecture, internals,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
Marcel de Rooy changed:
What|Removed |Added
Patch complexity|Trivial patch |Small patch
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
Marcel de Rooy changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
Katrin Fischer changed:
What|Removed |Added
Attachment #140222|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
Katrin Fischer changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
--
Y
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
--- Comment #9 from Joonas Kylmälä ---
(In reply to Joonas Kylmälä from comment #4)
> I'm wondering whether the fix is correct, and whether the other encode_utf8
> calls in the same file are the right way to deal with encoding. Shoul
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
--- Comment #8 from Joonas Kylmälä ---
Created attachment 140236
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140236&action=edit
Bug 31351: ALTERNATIVE Koha::BackgroundJob: Let database connection object
handle u
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
Joonas Kylmälä changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #7 f
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
--- Comment #6 from Marcel de Rooy ---
I love these encoding problems :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lis
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
Peter Vashchuk changed:
What|Removed |Added
Attachment #139438|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
Victor Grousset/tuxayo changed:
What|Removed |Added
Patch complexity|--- |Trivial patch
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
Joonas Kylmälä changed:
What|Removed |Added
CC||joonas.kylm...@iki.fi
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
Fridolin Somers changed:
What|Removed |Added
CC||fridolin.som...@biblibre.c
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
David Nind changed:
What|Removed |Added
Attachment #139058|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
--- Comment #1 from Peter Vashchuk ---
Created attachment 139058
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139058&action=edit
Bug 31351: encode bytes to unicode in JSON for background tasks context
"malformed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
Peter Vashchuk changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You are
62 matches
Mail list logo