https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
--- Comment #57 from Thomas Klausner ---
Finally created a pull-req for KTD to add my "fix" to the KTD docs:
https://gitlab.com/koha-community/koha-testing-docker/-/merge_requests/492
I still see no easy way to add this to KTD
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
--- Comment #56 from Victor Grousset/tuxayo ---
(In reply to Thomas Klausner from comment #51)
> I think we should NOT apply any of these patches:
>
> Hot reload is only needed during dev, and it's much easier to (manually)
> start
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
--- Comment #55 from Victor Grousset/tuxayo ---
(In reply to Olivier Hubert from comment #50)
> > plackup -R doesn't with --daemonize, could that be a problem?
>
> It's certainly going to be a problem for us, as that is how we run
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
--- Comment #54 from Thomas Klausner ---
Here's what I'm using to start a hot-reload server in koha-testing-docker:
ktd --shell
kohadev-koha@kohadevbox:koha$ koha-plack --stop kohadev
Stopping Plack daemon for kohadev:.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
--- Comment #53 from Katrin Fischer ---
(In reply to Katrin Fischer from comment #52)
> (In reply to Thomas Klausner from comment #51)
> > I think we should NOT apply any of these patches:
> >
> > Hot reload is only needed during
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
--- Comment #52 from Katrin Fischer ---
(In reply to Thomas Klausner from comment #51)
> I think we should NOT apply any of these patches:
>
> Hot reload is only needed during dev, and it's much easier to (manually)
> start
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
--- Comment #51 from Thomas Klausner ---
I think we should NOT apply any of these patches:
Hot reload is only needed during dev, and it's much easier to (manually) start
koha-plack in a non-demaonized way with hot-reload in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
--- Comment #50 from Olivier Hubert ---
> plackup -R doesn't with --daemonize, could that be a problem?
It's certainly going to be a problem for us, as that is how we run Plack.
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
Victor Grousset/tuxayo changed:
What|Removed |Added
CC||vic...@tuxayo.net
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
Thomas Klausner changed:
What|Removed |Added
Status|Failed QA |In Discussion
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
--- Comment #47 from Thomas Klausner ---
Maybe it would be easiest to NOT change anything in the koha-plack shell script
(which is mostly used for prod, where we don't want the hot reload anyway). But
to provided either
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
--- Comment #46 from David Cook ---
(In reply to Jonathan Druart from comment #45)
> I think we should:
> 1. test DEV_INSTALL instead of KOHA_INSTANCE, and watch KOHA_HOME instead of
> /kohadevbox/koha
> 2. Rename hot_reload with
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
Jonathan Druart changed:
What|Removed |Added
Attachment #154542|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
Jonathan Druart changed:
What|Removed |Added
Assignee|m...@kohaaloha.com |d...@plix.at
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
David Cook changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--- Comment #44
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
David Cook changed:
What|Removed |Added
Attachment #154676|Bug 31729: enable plackup |Bug 31729: [Alternate]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
--- Comment #43 from David Cook ---
Created attachment 154677
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154677=edit
Bug 31729: [Alternate][follow-up] watch whole codebase
Signed-off-by: David Cook
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
David Cook changed:
What|Removed |Added
Attachment #154605|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
--- Comment #41 from David Cook ---
Comment on attachment 154605
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154605
Bug 31729: enable plackup hot restart in ktd [Alternate]
Review of attachment 154605:
-->
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
--- Comment #40 from David Cook ---
Ohhh, Thomas that sounds very interesting!
Plack::Loader::Restarter is still using inotify under the hood, but it's much
easier to implement and maintain this way.
I'm going to come back to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
Thomas Klausner changed:
What|Removed |Added
Attachment #154601|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
--- Comment #38 from Thomas Klausner ---
Created attachment 154601
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154601=edit
Bug 31729: enable plackup hot restart in ktd [Alternate]
This patch implements a more
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
Thomas Klausner changed:
What|Removed |Added
Status|Signed Off |Needs Signoff
Patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
--- Comment #37 from David Cook ---
(In reply to Mason James from comment #36)
> i think that plack needs to be restarted if template files (.inc and .tt)
> are modified
Generally it shouldn't need to be restarted if templates are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
--- Comment #36 from Mason James ---
(In reply to Thomas Klausner from comment #33)
> FYI, I have another approach nearly finished, where instead of creating a
> new daemon and using inotify we start the Plack app via plackup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
--- Comment #35 from David Cook ---
Just reiterating that it would be great to have this be "optional", since I
wouldn't want to use it. Definitely not in prod, and not even in
koha-testing-docker.
I prefer to manually restart my
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
--- Comment #34 from David Cook ---
(In reply to Thomas Klausner from comment #33)
> FYI, I have another approach nearly finished, where instead of creating a
> new daemon and using inotify we start the Plack app via plackup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
--- Comment #33 from Thomas Klausner ---
FYI, I have another approach nearly finished, where instead of creating a new
daemon and using inotify we start the Plack app via plackup (instead of just
usnig starman) and use the -R flag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
Pascal Uphaus changed:
What|Removed |Added
Attachment #148720|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
Pascal Uphaus changed:
What|Removed |Added
Patch complexity|--- |Small patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
Thomas Klausner changed:
What|Removed |Added
CC||d...@plix.at
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
Pedro Amorim changed:
What|Removed |Added
CC||pedro.amo...@ptfs-europe.co
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
David Cook changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
--- Comment #31 from Katrin Fischer ---
This sounds like it would be great time saver!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
Mason James changed:
What|Removed |Added
Attachment #148600|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
--- Comment #29 from Mason James ---
(In reply to Jonathan Druart from comment #26)
> Why are you logging in plack-error.log?
oops! i've changed log file to plack-watcher.log
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
Mason James changed:
What|Removed |Added
Attachment #148612|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
--- Comment #27 from Mason James ---
Created attachment 148612
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148612=edit
Bug 31729: renamed log file to plack-watcher.log
to test...
- modify some perl files in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
--- Comment #26 from Jonathan Druart ---
Why are you logging in plack-error.log?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
--- Comment #25 from Mason James ---
Created attachment 148606
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148606=edit
Bug 31729: move $tmpfile to /tmp dir, and add {}
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
Mason James changed:
What|Removed |Added
Attachment #148602|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
--- Comment #23 from Mason James ---
Created attachment 148602
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148602=edit
Bug 31729: fix quoting and set sh
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
--- Comment #22 from Mason James ---
(In reply to Olivier Hubert from comment #20)
> I tried out the latest test plan but cannot continue past Step 3. It seems
> the test plan is only appropriate for koha installations made with the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
Mason James changed:
What|Removed |Added
Attachment #141714|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
Olivier Hubert changed:
What|Removed |Added
CC||olivier.hub...@inlibro.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
pierre.ge...@biblibre.com changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
--- Comment #19 from Mason James ---
(In reply to Jonathan Druart from comment #15)
> Shouldn't we watch for perl files only?
>
> What about git checkout branch? Is it going to send 1 signal per file
> modified?
hiya, i've added 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
Mason James changed:
What|Removed |Added
Attachment #142044|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
Mason James changed:
What|Removed |Added
Attachment #141716|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
--- Comment #16 from Mason James ---
Created attachment 142043
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142043=edit
Bug 31729: watch only perl files
--
You are receiving this mail because:
You are watching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
Jonathan Druart changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
--- Comment #14 from Mason James ---
> 5/ modify file in watched dir
> echo `date` > /usr/share/koha/xxx1
> echo `date` > /usr/share/koha/xxx2
if testing in KTD, try...
# echo `date` > /kohadevbox/koha/xxx2
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
--- Comment #13 from Mason James ---
Created attachment 141716
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141716=edit
Bug 31729 - Enable automatic filesystem refresh in Plack (3)
fix 'elif' typo
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
--- Comment #12 from Mason James ---
Created attachment 141715
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141715=edit
Bug 31729: Enable automatic filesystem refresh in Plack (2)
fix typo
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
Mason James changed:
What|Removed |Added
Attachment #141596|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
Mason James changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
--- Comment #10 from Martin Renvoize ---
Oop, I tested first thing this morning without refreshing to see the comments.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
Martin Renvoize changed:
What|Removed |Added
Status|Signed Off |ASSIGNED
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
Martin Renvoize changed:
What|Removed |Added
Status|ASSIGNED|Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
--- Comment #9 from Martin Renvoize ---
Created attachment 141598
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141598=edit
Bug 31729: Add missing brace (and tidy)
This adds a missing closing bracket and runs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
Martin Renvoize changed:
What|Removed |Added
Attachment #141578|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
Martin Renvoize changed:
What|Removed |Added
Attachment #141577|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
--- Comment #5 from Mason James ---
(In reply to David Cook from comment #4)
> (In reply to Mason James from comment #1)
> > to test:
> >
> > 1/ start ktd
> > 2/ add warn to about.pl file, load page, observe no output in log :(
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
Mason James changed:
What|Removed |Added
Status|Needs Signoff |ASSIGNED
--- Comment #3 from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
Mason James changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun |m...@kohaaloha.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
Mason James changed:
What|Removed |Added
CC||martin.renvoize@ptfs-europe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
--- Comment #2 from Mason James ---
Created attachment 141578
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141578=edit
Bug 31729: Enable automatic filesystem refresh in Plack (2)
updating mojo psgi file too,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
--- Comment #1 from Mason James ---
Created attachment 141577
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141577=edit
Bug 31729: Enable automatic filesystem refresh in Plack
patch uses the following module...
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729
Mason James changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
You are
71 matches
Mail list logo
