https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060
--- Comment #26 from Matt Blenkinsop ---
Nice work everyone!
Pushed to oldstable for 22.11.x
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs maili
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060
Matt Blenkinsop changed:
What|Removed |Added
Version(s)|23.11.00,23.05.01 |23.11.00,23.05.01,22.11.07
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060
Matt Blenkinsop changed:
What|Removed |Added
CC||matt.blenkinsop@ptfs-europ
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060
Martin Renvoize changed:
What|Removed |Added
Severity|enhancement |minor
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060
Martin Renvoize changed:
What|Removed |Added
CC||martin.renvoize@ptfs-europ
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060
--- Comment #24 from Tomás Cohen Arazi ---
Pushed to master for 23.11.
Nice work everyone, thanks!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060
Tomás Cohen Arazi changed:
What|Removed |Added
Version(s)||23.11.00
release
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060
Marcel de Rooy changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060
Marcel de Rooy changed:
What|Removed |Added
Attachment #151292|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060
Marcel de Rooy changed:
What|Removed |Added
Attachment #151291|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060
Jonathan Druart changed:
What|Removed |Added
Blocks||33746
Depends on|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060
Mason James changed:
What|Removed |Added
CC||m...@kohaaloha.com
--
You ar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060
Jonathan Druart changed:
What|Removed |Added
Depends on||33746
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060
Jonathan Druart changed:
What|Removed |Added
CC||n...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060
--- Comment #19 from Jonathan Druart ---
Created attachment 151292
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151292&action=edit
Bug 32060: Use selectrow_array
Trivial ergonomic patch, use selectrow_array, no
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060
Jonathan Druart changed:
What|Removed |Added
Attachment #151133|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060
Jonathan Druart changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060
David Gustafsson changed:
What|Removed |Added
See Also||https://bugs.koha-communi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060
--- Comment #17 from David Gustafsson ---
Added caching for GetFrameworkCode and now using that instead. Also saw that
strings_map had the same issues as columns_to_str since they share some code,
so applied the same changes there. R
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060
David Gustafsson changed:
What|Removed |Added
Attachment #151132|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060
David Gustafsson changed:
What|Removed |Added
Attachment #151131|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060
David Gustafsson changed:
What|Removed |Added
Attachment #150866|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060
--- Comment #13 from David Gustafsson ---
And about 3. above, it was poorly formulated, I meant that using $self->$column
results in the page taking 40% longer to generate, not that $self->$column is
%40 more expensive than get_colum
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060
--- Comment #12 from David Gustafsson ---
Accidentally omitted
goto &{$AUTOLOAD};
which should be on the last line.
--
You are receiving this mail because:
You are watching all bug changes.
_
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060
--- Comment #11 from David Gustafsson ---
This actually speeds speeds up so that calling the property method directly is
as fast as$self->_result()->get_column($column)
if ( grep { $_ eq $method } @columns ) {
#if ( @
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060
--- Comment #10 from David Gustafsson ---
No, the loop is not it, I think AUTOLOAD in itself is slow, perhaps parsing of
method name etc. I think there are techniques to speed this up by lazily
defining actual setter/getter methods o
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060
--- Comment #9 from David Gustafsson ---
(In reply to Jonathan Druart from comment #8)
> 1. Then I would C4::Biblio::GetFrameworkCode and cache there.
>
> 2. -my $tagslib = C4::Biblio::GetMarcStructure(1, $frameworkcode);
> +
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060
--- Comment #8 from Jonathan Druart ---
1. Then I would C4::Biblio::GetFrameworkCode and cache there.
2. -my $tagslib = C4::Biblio::GetMarcStructure(1, $frameworkcode);
+my $tagslib = C4::Biblio::GetMarcStructure( 1, $framew
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060
--- Comment #7 from David Gustafsson ---
Since caching of GetAuthorisedValueDesc is now in master, the performance gain
will not be as large, but still substantial.
--
You are receiving this mail because:
You are watching all bug c
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060
David Gustafsson changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--- Commen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060
David Gustafsson changed:
What|Removed |Added
Attachment #144348|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.druart+koha@gmail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060
Fridolin Somers changed:
What|Removed |Added
CC||fridolin.som...@biblibre.c
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060
Fridolin Somers changed:
What|Removed |Added
See Also||https://bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060
David Gustafsson changed:
What|Removed |Added
Attachment #142894|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060
David Gustafsson changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
You ar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060
--- Comment #1 from David Gustafsson ---
Created attachment 142894
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142894&action=edit
Bug 32060: Improve performance of columns_to_str
To test:
1) Ensure tests in t/d
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060
David Gustafsson changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun |glask...@gmail.com
40 matches
Mail list logo
