https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Jonathan Druart changed:
What|Removed |Added
Depends on||32394
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Jonathan Druart changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
--- Comment #1 from Jonathan Druart ---
Created attachment 144401
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144401&action=edit
Bug 32393: Prevent invalid job to block the job queue
I have faced a problem when
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Jonathan Druart changed:
What|Removed |Added
CC||dc...@prosentient.com.au,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Jonathan Druart changed:
What|Removed |Added
See Also||https://bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Jonathan Druart changed:
What|Removed |Added
Blocks||32395
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
--- Comment #2 from Tomás Cohen Arazi ---
Comment on attachment 144401
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144401
Bug 32393: Prevent invalid job to block the job queue
Review of attachment 144401:
-->
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--
You are r
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Jonathan Druart changed:
What|Removed |Added
Attachment #144401|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Jonathan Druart changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #7
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Jonathan Druart changed:
What|Removed |Added
See Also||https://bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
--- Comment #8 from Jonathan Druart ---
Created attachment 145064
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145064&action=edit
Bug 32393: Remove fork
--
You are receiving this mail because:
You are watching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Kyle M Hall changed:
What|Removed |Added
CC||k...@bywatersolutions.com
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
--- Comment #10 from Martin Renvoize ---
I agree that removing the fork is a bad idea.. it was implimented for the
reasoning Kyle suggests I believe.. to keep the memory footprint from
balooning.
--
You are receiving this mail beca
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Martin Renvoize changed:
What|Removed |Added
See Also||https://bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
--- Comment #11 from Jonathan Druart ---
I left the patch here yesterday after my day work.
I was working on bug 32481, and thought that this first patch was a good base
to work on.
So far I am only trying to make things work correct
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
--- Comment #12 from Martin Renvoize ---
There's scope creep here.. the try encompasses the process_job which means it's
also catching all sorts of other possible failures from each and every
processor that's written.
I think we sho
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
--- Comment #13 from Martin Renvoize ---
Also.. if we do want to only acknowledge on process completion, should we not
do it within the forked worker?
--
You are receiving this mail because:
You are watching all bug changes.
__
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
--- Comment #14 from Jonathan Druart ---
(In reply to Martin Renvoize from comment #12)
> I think we should limit the scope of this bug to only catch bad JSON
> encoding and leave error handling for individual tasks to the tasks
> th
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
--- Comment #15 from David Cook ---
We need to keep the fork, and catching all exceptions makes sense to me. You
could say that the background job worker is really a background job server and
servers really shouldn't go down. They sh
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
--- Comment #16 from Marcel de Rooy ---
Just a simple observation:
+my $job_id;
You are not using this variable (after all).
--
You are receiving this mail because:
You are watching all bug changes.
__
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
--- Comment #17 from Marcel de Rooy ---
} finally {
$job->status('failed')->store if $job && @_;
Looks like a typo. Did you mean $@ ? And would testing that be enough or even
appropriate in a finally block ?
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
--- Comment #18 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #17)
> } finally {
> $job->status('failed')->store if $job && @_;
>
> Looks like a typo. Did you mean $@ ? And would testing that b
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
--- Comment #19 from Marcel de Rooy ---
(In reply to Kyle M Hall from comment #9)
> Just a thought; removing that fork will cause the workers memory footprint
> to balloon as soon as the plugins require is evaluated which obviates th
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Jonathan Druart changed:
What|Removed |Added
Attachment #145064|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
--- Comment #20 from Jonathan Druart ---
(In reply to Marcel de Rooy from comment #19)
> (In reply to Kyle M Hall from comment #9)
> > Just a thought; removing that fork will cause the workers memory footprint
> > to balloon as soon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Jonathan Druart changed:
What|Removed |Added
Blocks||32594
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
--- Comment #21 from David Cook ---
(In reply to Martin Renvoize from comment #12)
> There's scope creep here.. the try encompasses the process_job which means
> it's also catching all sorts of other possible failures from each and e
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
David Cook changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #22 from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
--- Comment #23 from Jonathan Druart ---
Created attachment 145207
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145207&action=edit
Bug 32393: Split into 2 try catch blocks
--
You are receiving this mail because
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Nick Clemens changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are recei
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Nick Clemens changed:
What|Removed |Added
Attachment #144569|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Nick Clemens changed:
What|Removed |Added
Attachment #145207|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Nick Clemens changed:
What|Removed |Added
CC||n...@bywatersolutions.com
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Jonathan Druart changed:
What|Removed |Added
Blocks||32612
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
--- Comment #28 from David Cook ---
(In reply to Jonathan Druart from comment #24)
> I don't understand what you are asking for guys. I've written a follow-up
> patch that I think does what you want, but I don't see how it is better.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Jonathan Druart changed:
What|Removed |Added
Severity|normal |critical
--- Comment #29
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
--- Comment #30 from Marcel de Rooy ---
For me this statement is also in the scope of this report (but not touched
yet):
while ( my $job = $jobs->next ) {
my $args = $job->json->decode($job->data);
--
You are r
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Failed QA
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Marcel de Rooy changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
--- Comment #31 from Marcel de Rooy ---
Note that I agree with acking earlier. We do this implicitly here. This would
obsolete the separate report (32573).
--
You are receiving this mail because:
You are watching all bug changes.
_
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Jonathan Druart changed:
What|Removed |Added
Depends on||32573
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Jonathan Druart changed:
What|Removed |Added
Attachment #145216|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
--- Comment #33 from Jonathan Druart ---
Created attachment 145597
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145597&action=edit
Bug 32393: Split into 2 try catch blocks
Signed-off-by: Nick Clemens
--
You a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
--- Comment #34 from Jonathan Druart ---
Created attachment 145598
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145598&action=edit
Bug 32393: Deal with the DB fallback part
--
You are receiving this mail becaus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
--- Comment #35 from Jonathan Druart ---
(In reply to Marcel de Rooy from comment #31)
> Note that I agree with acking earlier. We do this implicitly here. This
> would obsolete the separate report (32573).
Added the dependency.
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
--- Comment #36 from Jonathan Druart ---
(In reply to Marcel de Rooy from comment #30)
> For me this statement is also in the scope of this report (but not touched
> yet):
>
> while ( my $job = $jobs->next ) {
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Jonathan Druart changed:
What|Removed |Added
See Also||https://bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Jonathan Druart changed:
What|Removed |Added
Blocks||32709
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Marcel de Rooy changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Patch doesn't apply
--- Co
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Jonathan Druart changed:
What|Removed |Added
Attachment #145596|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Jonathan Druart changed:
What|Removed |Added
Attachment #145597|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Jonathan Druart changed:
What|Removed |Added
Attachment #145598|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Jonathan Druart changed:
What|Removed |Added
Status|Patch doesn't apply |Signed Off
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |BLOCKED
--- Comment #41 fr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Marcel de Rooy changed:
What|Removed |Added
Patch complexity|--- |Small patch
St
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Marcel de Rooy changed:
What|Removed |Added
Attachment #145609|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Marcel de Rooy changed:
What|Removed |Added
Attachment #145610|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Marcel de Rooy changed:
What|Removed |Added
Attachment #145611|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
--- Comment #45 from Marcel de Rooy ---
Created attachment 145616
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145616&action=edit
Bug 32393: (QA follow-up) Add explicit undef response in two catch blocks
Do not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
--- Comment #46 from Marcel de Rooy ---
And now we still need the job list to not crash on bad job data ;) I thought
that there was a report too?
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
--- Comment #47 from Jonathan Druart ---
(In reply to Marcel de Rooy from comment #46)
> And now we still need the job list to not crash on bad job data ;) I thought
> that there was a report too?
See bug 32709.
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Tomás Cohen Arazi changed:
What|Removed |Added
Version(s)||23.05.00
release
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
--- Comment #48 from Tomás Cohen Arazi ---
Pushed to master for 23.05.
Nice work everyone, thanks!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Matt Blenkinsop changed:
What|Removed |Added
Version(s)|23.05.00|23.05.00,22.11.03
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
--- Comment #49 from Matt Blenkinsop ---
Nice work everyone!
Pushed to stable for 22.11.x
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Lucas Gass changed:
What|Removed |Added
CC||lu...@bywatersolutions.com
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Lucas Gass changed:
What|Removed |Added
Version(s)|23.05.00,22.11.03 |23.05.00,22.11.03,22.05.10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Bug 32393 depends on bug 32394, which changed state.
Bug 32394 Summary: Long tasks queue is never used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394
What|Removed |Added
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Arthur Suzuki changed:
What|Removed |Added
Status|Pushed to oldstable |RESOLVED
CC
77 matches
Mail list logo
