[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added CC|

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-02-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 Arthur Suzuki changed: What|Removed |Added Version(s)|23.05.00,22.11.03,22.05.10 |23.05.00,22.11.03,22.05.10,

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 Lucas Gass changed: What|Removed |Added Version(s)|23.05.00,22.11.03 |23.05.00,22.11.03,22.05.10

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-01-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 --- Comment #33 from Matt Blenkinsop --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-01-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 Matt Blenkinsop changed: What|Removed |Added Version(s)|23.05.00|23.05.00,22.11.03

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-01-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 --- Comment #32 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-01-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.05.00

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 --- Comment #31 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #29) > Had an issue with the commit message being truncated. I only kept the > summary now, the arguments from O'Reilly etc. are on this report.

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 Jonathan Druart changed: What|Removed |Added Attachment #145608|0 |1 is obsolete|

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 --- Comment #29 from Marcel de Rooy --- Had an issue with the commit message being truncated. I only kept the summary now, the arguments from O'Reilly etc. are on this report. -- You are receiving this mail because: You are

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 Marcel de Rooy changed: What|Removed |Added Attachment #145595|0 |1 is obsolete|

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Passed QA Patch

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED --- Comment #27

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 Jonathan Druart changed: What|Removed |Added Attachment #145594|0 |1 is obsolete|

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 Jonathan Druart changed: What|Removed |Added Attachment #145066|0 |1 is obsolete|

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 Jonathan Druart changed: What|Removed |Added Status|In Discussion |Signed Off -- You are

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 Jonathan Druart changed: What|Removed |Added Blocks||32393 Referenced Bugs:

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 --- Comment #24 from Marcel de Rooy --- See also 32393. It also moves the ack before processing the job. -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 Marcel de Rooy changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-01-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 --- Comment #23 from David Cook --- (In reply to Kyle M Hall from comment #21) > I'd say we need to make the decision on where to ACK and the rest > of the plan will follow from that. Jonathan has put in the early ACK into bug

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-01-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 --- Comment #22 from David Cook --- (In reply to Kyle M Hall from comment #20) > Nick asked me to post this > > https://stomp.github.io/stomp-specification-1.2.html#ACK > --- > ACK is used to acknowledge consumption of a message

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-01-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 --- Comment #21 from Kyle M Hall --- (In reply to David Cook from comment #19) > (In reply to David Cook from comment #18) > > > I've been pondering having separate workers for polling and rabbit > > > respectively. It would

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-01-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 --- Comment #20 from Kyle M Hall --- Nick asked me to post this https://stomp.github.io/stomp-specification-1.2.html#ACK --- ACK is used to acknowledge consumption of a message from a subscription using client or client-individual

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-01-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 --- Comment #19 from David Cook --- (In reply to David Cook from comment #18) > > I've been pondering having separate workers for polling and rabbit > > respectively. It would simplify things a lot. > > That does sound interesting.

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-01-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 --- Comment #18 from David Cook --- (In reply to Tomás Cohen Arazi from comment #17) > Regarding the ack discussion, it feels to me that many of our problems are > related to the 'ack last' behavior. As you said, we have our own way

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-01-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 --- Comment #17 from Tomás Cohen Arazi --- (In reply to Tomás Cohen Arazi from comment #11) > (In reply to David Cook from comment #8) > > > > RabbitMQ isn't the wrong tool for the job > > The question is: are we better with just

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-01-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 --- Comment #16 from David Cook --- Another thought... What about imposing limits on the size of batches? It's common to see this on major commercial systems. Some social media sites will only allow you to choose 50 items for an

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-01-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 --- Comment #15 from David Cook --- I'm curious what Kyle thinks about it. Whether he wants to update his patches, or if folk want me to provide alternative patches. -- You are receiving this mail because: You are watching all bug

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-01-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 David Cook changed: What|Removed |Added Status|Needs Signoff |In Discussion --- Comment #14

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-01-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 --- Comment #13 from David Cook --- I was looking back at the origin of the database failover, and I think Julian makes an interesting point at https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417#c249 Maybe we could

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-01-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 --- Comment #12 from David Cook --- (In reply to Tomás Cohen Arazi from comment #11) > (In reply to David Cook from comment #8) > > > > RabbitMQ isn't the wrong tool for the job > > The question is: are we better with just

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-01-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-01-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-01-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 --- Comment #10 from David Cook --- But... as I note at https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783#c64 my libraries are not heavy users of background tasks at this point. It sounds like Bywater are having the

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-01-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 --- Comment #9 from David Cook --- (In reply to Nick Clemens from comment #7) > I think for Koha we should ack as soon as we receive the job from RabbitMQ > > We maintain our own DB table for background jobs, and this is our source

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-01-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 --- Comment #8 from David Cook --- (In reply to Kyle M Hall from comment #5) > Considering batch record modifications are not atomic, I don't think that's > necessarily a compelling argument. I think that shows that batch

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-01-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-01-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 --- Comment #6 from Kyle M Hall --- > I can't see any scenario where either: > A) We should ack before processing. We are stymying Koha's ability to do > background processing by running extrememly long processes in serial with no >

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-01-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 --- Comment #5 from Kyle M Hall --- (In reply to David Cook from comment #4) > If you were doing a big batch record modification and you suffered a power > outage on the machine where the background job worker is running, then that

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-01-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 --- Comment #4 from David Cook --- If you were doing a big batch record modification and you suffered a power outage on the machine where the background job worker is running, then that task can't be re-started since the RabbitMQ

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-01-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au ---

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-01-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 --- Comment #2 from Jonathan Druart --- I've tried this when working on bug 32481 but it didn't help. -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 Kyle M Hall changed: What|Removed |Added CC||jonathan.druart+koha@gmail.

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 Emily Lamancusa changed: What|Removed |Added CC|

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 --- Comment #1 from Kyle M Hall --- Created attachment 145066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145066=edit Bug 32573: Send ACK message to RabbitMQ before handling the job Splitting off this

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 Kyle M Hall changed: What|Removed |Added Blocks||32558 Referenced Bugs:

[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job

2023-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 Kyle M Hall changed: What|Removed |Added See Also||https://bugs.koha-community