[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 David Nind changed: What|Removed |Added CC||da...@davidnind.com

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 Tomás Cohen Arazi changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You a

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 Tomás Cohen Arazi changed: What|Removed |Added Attachment #155682|0 |1 is obsolete|

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 --- Comment #36 from Tomás Cohen Arazi --- Created attachment 157757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157757&action=edit Bug 32607: Add Koha::RecordSource(s) classes This patch introduces classes for

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 --- Comment #37 from Tomás Cohen Arazi --- Created attachment 157758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157758&action=edit Bug 32607: DBIC schema [DO NOT PUSH] Signed-off-by: Tomas Cohen Arazi -- Yo

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 --- Comment #38 from Tomás Cohen Arazi --- Created attachment 157759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157759&action=edit Bug 32607: Add /record_sources endpoints This patch introduces endpoints for m

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 --- Comment #39 from Tomás Cohen Arazi --- Created attachment 157760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157760&action=edit Bug 32607: Add record sources admin page This patch introduces a Vue.js based

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 Tomás Cohen Arazi changed: What|Removed |Added Attachment #157760|0 |1 is obsolete|

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 --- Comment #41 from Tomás Cohen Arazi --- (In reply to David Nind from comment #34) > Patches no longer applies 8-(... > > Applying: Bug 32607: DBIC schema [DO NOT PUSH] Thanks for trying! That [DO NOT PUSH] patch is usually source

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 --- Comment #42 from Tomás Cohen Arazi --- Created attachment 157762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157762&action=edit Bug 32607: Add cypress tests -- You are receiving this mail because: You are

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 --- Comment #43 from David Nind --- (In reply to Tomás Cohen Arazi from comment #41) > (In reply to David Nind from comment #34) > > Patches no longer applies 8-(... > > > > Applying: Bug 32607: DBIC schema [DO NOT PUSH] > > Thanks

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 --- Comment #44 from Tomás Cohen Arazi --- (In reply to David Nind from comment #43) > (In reply to Tomás Cohen Arazi from comment #41) > > (In reply to David Nind from comment #34) > > > Patches no longer applies 8-(... > > > > > >

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 --- Comment #45 from David Nind --- (In reply to Tomás Cohen Arazi from comment #44) > > You need to reset_all. Because some apache files need to be updated. That's > why you get the 404 Thanks Tomás - that worked! -- You are rec

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 --- Comment #46 from David Nind --- Some comments from testing: 1. I'm not sure that I understand what this does, but I assume that it sets the foundation for being able to limit the editing of bibliographic records from specific so

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 --- Comment #47 from Tomás Cohen Arazi --- (In reply to David Nind from comment #46) > Some comments from testing: > > 1. I'm not sure that I understand what this does, but I assume that it sets > the foundation for being able to li

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 Agustín Moyano changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 Agustín Moyano changed: What|Removed |Added Attachment #149827|0 |1 is obsolete|

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 --- Comment #16 from Agustín Moyano --- Created attachment 154007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154007&action=edit Bug 32607: [DO NOT PUSH] Koha schemas -- You are receiving this mail because: Yo

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 --- Comment #17 from Agustín Moyano --- Created attachment 154008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154008&action=edit Bug 32607: Add CRUD for import sources This patch adds vue components to create,

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 --- Comment #18 from Agustín Moyano --- Created attachment 154009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154009&action=edit Bug 32607: [DO NOT PUSH] Koha schemas -- You are receiving this mail because: Yo

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 --- Comment #19 from Agustín Moyano --- Created attachment 154010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154010&action=edit Bug 32607: (follow-up) Apply changes suggested -- You are receiving this mail be

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #20

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 Agustín Moyano changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 --- Comment #21 from Agustín Moyano --- Created attachment 154438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154438&action=edit Bug 32607: (follow-up) Apply new suggestions -- You are receiving this mail beca

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 Laura Escamilla changed: What|Removed |Added CC||Laura.escamilla@bywatersol

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiv

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|Small patch |Medium patch

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 Tomás Cohen Arazi changed: What|Removed |Added Attachment #154006|0 |1 is obsolete|

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 --- Comment #24 from Tomás Cohen Arazi --- Created attachment 155683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155683&action=edit Bug 32607: Add Koha::RecordSource(s) classes This patch introduces classes for

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 --- Comment #25 from Tomás Cohen Arazi --- Created attachment 155684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155684&action=edit Bug 32607: DBIC schema [DO NOT PUSH] Signed-off-by: Tomas Cohen Arazi -- Yo

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 --- Comment #26 from Tomás Cohen Arazi --- Created attachment 155685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155685&action=edit Bug 32607: Add /record_sources endpoints This patch introduces endpoints for m

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 --- Comment #27 from Tomás Cohen Arazi --- Created attachment 155686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155686&action=edit Bug 32607: Add record sources admin page This patch introduces a Vue.js based

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 --- Comment #28 from Tomás Cohen Arazi --- Hi, I've just submitted a reworked version of the original patchset from Agustín. I tried to cover Jonathan's concerns even though I'm not (yet) versed on Vue.js. I aligned everything with

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #29

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 --- Comment #30 from Jonathan Druart --- There is a 500 in the Koha logs [WARN] OpenAPI >>> GET api/v1/record_sources [{"message":"Properties not allowed: patron.","path":"\/body\/0"}] -- You are receiving this mail because: You a

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 --- Comment #31 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #30) > There is a 500 in the Koha logs > > [WARN] OpenAPI >>> GET api/v1/record_sources [{"message":"Properties not > allowed: patron.","path":"\/b

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You a

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 Tomás Cohen Arazi changed: What|Removed |Added Attachment #155685|0 |1 is obsolete|

[Koha-bugs] [Bug 32607] Add import sources crud

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 Agustín Moyano changed: What|Removed |Added CC||tomasco...@gmail.com

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 Tomás Cohen Arazi changed: What|Removed |Added CC||k...@bywatersolutions.co

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 Agustín Moyano changed: What|Removed |Added Depends on||32806 Referenced Bugs: h

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 --- Comment #1 from Agustín Moyano --- Created attachment 146410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146410&action=edit Bug 32607: Add table and permissions Adds a new table called import_sources and a

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 --- Comment #2 from Agustín Moyano --- Created attachment 146411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146411&action=edit Bug 32607: [DO NOT PUSH] Koha schemas -- You are receiving this mail because: You

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 --- Comment #3 from Agustín Moyano --- Created attachment 146412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146412&action=edit Bug 32607: Add CRUD for import sources This patch adds vue components to create, r

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 Jonathan Druart changed: What|Removed |Added Depends on|32806 | Referenced Bugs: https

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 Jonathan Druart changed: What|Removed |Added Depends on||32925 Referenced Bugs:

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-communit

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 Agustín Moyano changed: What|Removed |Added Depends on||33066 Referenced Bugs: h

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- Y

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europ

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 Bug 32607 depends on bug 32925, which changed state. Bug 32925 Summary: Display loading info when a form is submitted https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32925 What|Removed |Ad

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 Agustín Moyano changed: What|Removed |Added Depends on||33169 Referenced Bugs: h

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 Jan Kissig changed: What|Removed |Added CC||bibliot...@th-wildau.de -- Yo

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 Agustín Moyano changed: What|Removed |Added Patch complexity|--- |Small patch St

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 Agustín Moyano changed: What|Removed |Added Attachment #146412|0 |1 is obsolete|

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 --- Comment #6 from Jonathan Druart --- Quick code review: 1. There are several wrong indentations (2 vs 4 spaces) or mismatch indentation (Koha::REST::V1::ImportSources->get for instance). You should run perltidy on new perl files 2

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 Agustín Moyano changed: What|Removed |Added Attachment #146410|0 |1 is obsolete|

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 --- Comment #8 from Agustín Moyano --- Created attachment 149828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149828&action=edit Bug 32607: [DO NOT PUSH] Koha schemas -- You are receiving this mail because: You

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 --- Comment #9 from Agustín Moyano --- Created attachment 149829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149829&action=edit Bug 32607: Add CRUD for import sources This patch adds vue components to create, r

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-communit

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 Matt Blenkinsop changed: What|Removed |Added CC||matt.blenkinsop@ptfs-europ

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 --- Comment #11 from Tomás Cohen Arazi --- Agustin: we agreed on renaming this 'Record sources' as it will be reused with the overlay rules eventually, and we need to leave room for an API-driven cataloguing module, which is not, to

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #12

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 --- Comment #13 from Agustín Moyano --- (In reply to Jonathan Druart from comment #6) > Quick code review: > 1. There are several wrong indentations (2 vs 4 spaces) or mismatch > indentation (Koha::REST::V1::ImportSources->get for in

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 --- Comment #14 from Jonathan Druart --- (In reply to Agustín Moyano from comment #13) A global response would be (and sorry if I am rambling here) that we enforce consistency. We must not have 2 ways to do the same thing. If you wa

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 Bug 32607 depends on bug 33066, which changed state. Bug 33066 Summary: We need a KohaTable Vue component https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 What|Removed |Added

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 Bug 32607 depends on bug 33066, which changed state. Bug 33066 Summary: We need a KohaTable Vue component https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 What|Removed |Added

[Koha-bugs] [Bug 32607] Add import sources CRUD

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 Bug 32607 depends on bug 33066, which changed state. Bug 33066 Summary: We need a KohaTable Vue component https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 What|Removed |Added