[Koha-bugs] [Bug 32702] Item statuses that block holds should be checked in CanItemBeReserved

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32702 --- Comment #17 from Julian Maurice --- (In reply to Nick Clemens from comment #16) > Would you be willing to accept a smaller change in those scripts for now? > $can_holds_be_placed = IsAvailableForItemLevelRequest($item, $patron,

[Koha-bugs] [Bug 32702] Item statuses that block holds should be checked in CanItemBeReserved

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32702 --- Comment #16 from Nick Clemens --- (In reply to Julian Maurice from comment #15) > There is at least 3 places where IsAvailableForItemLevelRequest is called > and CanItemBeReserved is not: > > * opac/opac-ISBDdetail.pl > *

[Koha-bugs] [Bug 32702] Item statuses that block holds should be checked in CanItemBeReserved

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32702 Julian Maurice changed: What|Removed |Added CC|

[Koha-bugs] [Bug 32702] Item statuses that block holds should be checked in CanItemBeReserved

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32702 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --

[Koha-bugs] [Bug 32702] Item statuses that block holds should be checked in CanItemBeReserved

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32702 Victor Grousset/tuxayo changed: What|Removed |Added Status|Signed Off |Failed QA

[Koha-bugs] [Bug 32702] Item statuses that block holds should be checked in CanItemBeReserved

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32702 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #157134|0 |1 is

[Koha-bugs] [Bug 32702] Item statuses that block holds should be checked in CanItemBeReserved

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32702 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #157133|0 |1 is

[Koha-bugs] [Bug 32702] Item statuses that block holds should be checked in CanItemBeReserved

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32702 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You

[Koha-bugs] [Bug 32702] Item statuses that block holds should be checked in CanItemBeReserved

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32702 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com

[Koha-bugs] [Bug 32702] Item statuses that block holds should be checked in CanItemBeReserved

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32702 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community

[Koha-bugs] [Bug 32702] Item statuses that block holds should be checked in CanItemBeReserved

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32702 --- Comment #9 from Nick Clemens --- Created attachment 157134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157134=edit Bug 32702: Unit tests -- You are receiving this mail because: You are watching all bug

[Koha-bugs] [Bug 32702] Item statuses that block holds should be checked in CanItemBeReserved

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32702 Nick Clemens changed: What|Removed |Added Attachment #149762|0 |1 is obsolete|

[Koha-bugs] [Bug 32702] Item statuses that block holds should be checked in CanItemBeReserved

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32702 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 32702] Item statuses that block holds should be checked in CanItemBeReserved

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32702 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community

[Koha-bugs] [Bug 32702] Item statuses that block holds should be checked in CanItemBeReserved

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32702 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Failed QA

[Koha-bugs] [Bug 32702] Item statuses that block holds should be checked in CanItemBeReserved

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32702 --- Comment #6 from Nick Clemens --- (In reply to Katrin Fischer from comment #3) > I haven't had time to look at the methods at a whole, but do we really want > to remove the checks from IsAvailableForItemLevelRequest? Holdability

[Koha-bugs] [Bug 32702] Item statuses that block holds should be checked in CanItemBeReserved

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32702 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com

[Koha-bugs] [Bug 32702] Item statuses that block holds should be checked in CanItemBeReserved

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32702 --- Comment #5 from Nick Clemens --- Created attachment 149763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149763=edit Bug 32702: Unit tests -- You are receiving this mail because: You are the assignee for

[Koha-bugs] [Bug 32702] Item statuses that block holds should be checked in CanItemBeReserved

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32702 Nick Clemens changed: What|Removed |Added Attachment #145590|0 |1 is obsolete|

[Koha-bugs] [Bug 32702] Item statuses that block holds should be checked in CanItemBeReserved

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32702 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are

[Koha-bugs] [Bug 32702] Item statuses that block holds should be checked in CanItemBeReserved

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32702 --- Comment #3 from Katrin Fischer --- In general I think we should stick with the well tested behavior from opac/intranet requests and make sure that the APIs use the same logic. So if we already had the stricter behavior in GUI, I

[Koha-bugs] [Bug 32702] Item statuses that block holds should be checked in CanItemBeReserved

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32702 Nick Clemens changed: What|Removed |Added Blocks||30845 Referenced Bugs:

[Koha-bugs] [Bug 32702] Item statuses that block holds should be checked in CanItemBeReserved

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32702 Nick Clemens changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr

[Koha-bugs] [Bug 32702] Item statuses that block holds should be checked in CanItemBeReserved

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32702 --- Comment #2 from Nick Clemens --- This needs unit tests, and maybe a more thorough plan - posting for opinions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

[Koha-bugs] [Bug 32702] Item statuses that block holds should be checked in CanItemBeReserved

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32702 --- Comment #1 from Nick Clemens --- Created attachment 145590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145590=edit Bug 32702: Move item status checks to CanItemBeReserved This patch moves item status