[Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Fridolin Somers changed: What|Removed |Added CC|

[Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 --- Comment #34 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master

[Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 --- Comment #33 from Tomás Cohen Arazi --- Created attachment 158211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158211=edit Bug 32730: Add tests for Koha::Patron->get_lists_with_patron Signed-off-by: Tomas

[Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 --- Comment #32 from Tomás Cohen Arazi --- Created attachment 158210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158210=edit Bug 32730: Add FIXME in POD to highlight return value Signed-off-by: Tomas Cohen

[Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Tomás Cohen Arazi changed: What|Removed |Added Attachment #157992|0 |1 is obsolete|

[Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 --- Comment #30 from Tomás Cohen Arazi --- Please tidy your patches. Specially when you introduce entirely new files. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Kyle M Hall changed: What|Removed |Added Attachment #155575|0 |1 is obsolete|

[Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com

[Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 --- Comment #28 from ByWater Sandboxes --- Created attachment 155589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155589=edit Bug 32730: Add Patron Lists tab to patron details and circulation pages Test Plan:

[Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Lisette Scheer changed: What|Removed |Added CC|

[Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Lisette Scheer changed: What|Removed |Added Attachment #154672|0 |1 is obsolete|

[Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Lisette Scheer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Stina Hallin changed: What|Removed |Added CC||stina.hal...@ub.lu.se ---

[Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Katie Bliss changed: What|Removed |Added CC||kebl...@dmpl.org -- You are

[Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Michael Hafen changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are

[Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Michael Hafen changed: What|Removed |Added Attachment #149477|0 |1 is obsolete|

[Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Eric Bégin changed: What|Removed |Added Status|Signed Off |Patch doesn't apply

[Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Marcel de Rooy changed: What|Removed |Added Status|Failed QA |Signed Off

[Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Katrin Fischer changed: What|Removed |Added CC||oleon...@myacpl.org --

[Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 --- Comment #21 from Michael Hafen --- Comment 8 on this bug mentioned the method name, but only that it needed to be snake case, which it now is. Same comment also mentioned the get_lists_with_patron() method and suggested putting

[Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA -- You are

[Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 --- Comment #20 from Marcel de Rooy --- Asked for a second perspective, tcohen replied on IRC: [16:40] I don't like those method names [16:40] well, name [16:41] or plain DBIC [16:41] it needs more work [16:41] FQA [16:41] it

[Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Signed Off --- Comment

[Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 --- Comment #18 from Marcel de Rooy --- $paton->get_lists_with_patron Looking at package Koha::List::Patron, it feels to me that it better should live there. No absolute blocker. That package is no Koha::Object btw. Explaining

[Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Michael Hafen changed: What|Removed |Added Attachment #146039|0 |1 is obsolete|

[Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Michael Hafen changed: What|Removed |Added Blocks||32105 Referenced Bugs:

[Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Laura Escamilla changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 ByWater Sandboxes changed: What|Removed |Added Attachment #147981|0 |1 is obsolete|

[Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 --- Comment #14 from ByWater Sandboxes --- Created attachment 147981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147981=edit Bug 32730: Add Patron Lists tab to patron details and circulation pages Test Plan:

[Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 --- Comment #13 from Michael Hafen --- Odd, I was able to follow the test plan all the way through on an up-to-date branch of master. I'm surprised that both the tab load and the list count on the tab aren't working. I expected

[Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Laura Escamilla changed: What|Removed |Added CC|

[Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Michael Hafen changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are

[Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Michael Hafen changed: What|Removed |Added Attachment #145977|0 |1 is obsolete|

[Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You

[Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Michael Hafen changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Michael Hafen changed: What|Removed |Added Attachment #145768|0 |1 is obsolete|

[Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 --- Comment #9 from Michael Hafen --- I will prepare another patch. I'll fix the name of the new method and move it to Koha/Patron.pm, I will fix the "Patron Lists" capitalization on the tab, I'll rephrase the list table headers as

[Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Katrin Fischer changed: What|Removed |Added Summary|Add Patron lists tab to |Add patron lists tab to

[Koha-bugs] [Bug 32730] Add Patron lists tab to patron details and circulation pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA

[Koha-bugs] [Bug 32730] Add Patron lists tab to patron details and circulation pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de

[Koha-bugs] [Bug 32730] Add Patron Lists tab to patron details and circulation pages.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Michael Hafen changed: What|Removed |Added Attachment #145744|0 |1 is obsolete|

[Koha-bugs] [Bug 32730] Add Patron Lists tab to patron details and circulation pages.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 --- Comment #6 from Michael Hafen --- Sorry, I found another bug with this patch. In the GetListsWithPatron() the early return causes problems with how the function is used, and is unnecessary. New patch forthcoming. -- You are

[Koha-bugs] [Bug 32730] Add Patron Lists tab to patron details and circulation pages.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 --- Comment #5 from Owen Leonard --- Created attachment 145745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145745=edit Bug 32730: (follow-up) Minor corrections This patch corrects an instance of an incorrect

[Koha-bugs] [Bug 32730] Add Patron Lists tab to patron details and circulation pages.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Owen Leonard changed: What|Removed |Added Attachment #145710|0 |1 is obsolete|

[Koha-bugs] [Bug 32730] Add Patron Lists tab to patron details and circulation pages.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch

[Koha-bugs] [Bug 32730] Add Patron Lists tab to patron details and circulation pages.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Michael Hafen changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 32730] Add Patron Lists tab to patron details and circulation pages.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Michael Hafen changed: What|Removed |Added Attachment #145668|0 |1 is obsolete|

[Koha-bugs] [Bug 32730] Add Patron Lists tab to patron details and circulation pages.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #2

[Koha-bugs] [Bug 32730] Add Patron Lists tab to patron details and circulation pages.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Michael Hafen changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |michael.ha...@washk12.org