[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #49 from Jonathan Druart --- Stop backporting this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 Pedro Amorim changed: What|Removed |Added Blocks||34609 Referenced Bugs:

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 Lucas Gass changed: What|Removed |Added Blocks||34603 Referenced Bugs:

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #48 from Matt Blenkinsop --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 Matt Blenkinsop changed: What|Removed |Added Version(s)|23.11.00,23.05.02

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #47 from Martin Renvoize --- Thanks for all the hard work! Pushed to 23.05.x for the next release -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 Martin Renvoize changed: What|Removed |Added Version(s)|23.11.00|23.11.00,23.05.02

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #46 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #44 from Jonathan Druart --- Created attachment 152093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152093=edit Bug 32894: Make ->sharee looks like others Signed-off-by: Nick Clemens -- You are

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #45 from Jonathan Druart --- Created attachment 152094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152094=edit Bug 32894: (QA follow-up) Fix tests Signed-off-by: Nick Clemens -- You are

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #43 from Jonathan Druart --- Created attachment 152092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152092=edit Bug 32894: (follow-up) Koha::Item->last_returned_by Signed-off-by: Nick Clemens --

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #42 from Jonathan Druart --- Created attachment 152091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152091=edit Bug 32894: (QA follow-up) Fix typo Signed-off-by: Martin Renvoize Signed-off-by: Nick

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #41 from Jonathan Druart --- Created attachment 152090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152090=edit Bug 32894: Remove incorrect caching from bundle_items Signed-off-by: Martin Renvoize

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #40 from Jonathan Druart --- Created attachment 152089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152089=edit Bug 32894: Fix test Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens --

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #39 from Jonathan Druart --- Created attachment 152088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152088=edit Bug 32894: Koha::Biblio->biblioitem Can we do better here? Signed-off-by: Martin

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #38 from Jonathan Druart --- Created attachment 152087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152087=edit Bug 32894: Koha::Item->last_returned_by Signed-off-by: Martin Renvoize Signed-off-by:

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 Jonathan Druart changed: What|Removed |Added Attachment #150847|0 |1 is obsolete|

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Passed QA -- You are

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Patch doesn't apply

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #35 from Kyle M Hall --- reset_all && multitime -n 10 prove t/db_dependent/Koha Just Master: 1: prove t/db_dependent/Koha MeanStd.Dev.Min Median Max real129.754 3.631

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 Tomás Cohen Arazi changed: What|Removed |Added Keywords||rel_23_11_candidate

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #33 from Jonathan Druart --- (In reply to Kyle M Hall from comment #32) > I do not think this is a great idea long term. This is moving backwards when > it comes to efficiency and will introduce far more database calls.

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #31 from Nick Clemens --- Looks good, t/db_dependent all pass now -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #30 from Nick Clemens --- Created attachment 150855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150855=edit Bug 32894: (QA follow-up) Fix tests Signed-off-by: Nick Clemens -- You are receiving

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #29 from Nick Clemens --- Created attachment 150854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150854=edit Bug 32894: Make ->sharee looks like others Signed-off-by: Nick Clemens -- You are

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #28 from Nick Clemens --- Created attachment 150853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150853=edit Bug 32894: (follow-up) Koha::Item->last_returned_by Signed-off-by: Nick Clemens -- You

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #27 from Nick Clemens --- Created attachment 150852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150852=edit Bug 32894: (QA follow-up) Fix typo Signed-off-by: Martin Renvoize Signed-off-by: Nick

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #26 from Nick Clemens --- Created attachment 150851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150851=edit Bug 32894: Remove incorrect caching from bundle_items Signed-off-by: Martin Renvoize

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #25 from Nick Clemens --- Created attachment 150850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150850=edit Bug 32894: Fix test Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #24 from Nick Clemens --- Created attachment 150849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150849=edit Bug 32894: Koha::Biblio->biblioitem Can we do better here? Signed-off-by: Martin

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #23 from Nick Clemens --- Created attachment 150848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150848=edit Bug 32894: Koha::Item->last_returned_by Signed-off-by: Martin Renvoize Signed-off-by:

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 Nick Clemens changed: What|Removed |Added Attachment #150016|0 |1 is obsolete|

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Signed Off

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #20 from Jonathan Druart --- Created attachment 150828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150828=edit Bug 32894: Make ->sharee looks like others -- You are receiving this mail because:

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #19 from Jonathan Druart --- Created attachment 150827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150827=edit Bug 32894: (follow-up) Koha::Item->last_returned_by -- You are receiving this mail

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 Jonathan Druart changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #17 from Martin Renvoize --- Added a tiny typo fix and also a patch for item_bundles. I agree.. lets to Koha::Objects as it's own bug. Signing off -- You are receiving this mail because: You are watching all bug

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 Martin Renvoize changed: What|Removed |Added Status|ASSIGNED|Signed Off -- You are

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #16 from Martin Renvoize --- Created attachment 150021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150021=edit Bug 32894: (QA follow-up) Fix typo Signed-off-by: Martin Renvoize -- You are

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #15 from Martin Renvoize --- Created attachment 150020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150020=edit Bug 32894: Remove incorrect caching from bundle_items Signed-off-by: Martin Renvoize

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 Martin Renvoize changed: What|Removed |Added Attachment #147503|0 |1 is obsolete|

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 Martin Renvoize changed: What|Removed |Added Attachment #147502|0 |1 is obsolete|

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 Martin Renvoize changed: What|Removed |Added Attachment #147500|0 |1 is obsolete|

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 Martin Renvoize changed: What|Removed |Added Attachment #147499|0 |1 is obsolete|

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 Jonathan Druart changed: What|Removed |Added Status|In Discussion |ASSIGNED

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #10 from Martin Renvoize --- Yes, sorry.. I've just not had a moment to breath yet.. This is certainly still near the top of my list. -- You are receiving this mail because: You are the assignee for the bug. You are

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #9 from Jonathan Druart --- Martin, could you have a look at Koha::Item::_bundle_items_cached? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #8 from Jonathan Druart --- Those patches deal with most of the cases. What about Koha::Item::_bundle_items_cached and Koha::Objects? I would not touch Koha::Objects behaviour here, maybe on a follow-up bug. -- You

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #7 from Jonathan Druart --- Created attachment 147503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147503=edit Bug 32894: Fix test -- You are receiving this mail because: You are watching all bug

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #6 from Jonathan Druart --- Created attachment 147502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147502=edit Bug 32894: Koha::Biblio->biblioitem Can we do better here? -- You are receiving this

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #5 from Jonathan Druart --- Created attachment 147500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147500=edit Bug 32894: Koha::Item->last_returned_by -- You are receiving this mail because: You

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #4 from Jonathan Druart --- Created attachment 147499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147499=edit Bug 32894: Remove wrong caching from Koha:: methods - simple In some of our Koha::

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #3 from Martin Renvoize --- I actually thought we'd alr Ady made he decision to not cache like this. I've not been actively removing such caches but I have generally tried to avoid adding new ones for a while. There are

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #2 from Jonathan Druart --- (In reply to Katrin Fischer from comment #1) > No Discussion here, is the status correct? :) Yes, it's still expecting feedback from other devs. -- You are receiving this mail because: You

[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #1 from Katrin Fischer --- No Discussion here, is the status correct? :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.