[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 Tomás Cohen Arazi changed: What|Removed |Added Blocks||36483 Referenced

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 Caroline Cyr La Rose changed: What|Removed |Added Status|Needs documenting |RESOLVED

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 Martin Renvoize changed: What|Removed |Added Component|REST API|Architecture, internals,

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 Martin Renvoize changed: What|Removed |Added Version(s)|23.05.00|23.05.00, 22.11.04

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 --- Comment #32 from Martin Renvoize --- Required by bug 32734 which was backported already.. backporting for 22.11.x will be in 22.11.04 -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 Matt Blenkinsop changed: What|Removed |Added CC|

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 --- Comment #30 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 --- Comment #29 from Kyle M Hall --- Created attachment 148073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148073=edit Bug 33080: Adapt other use-cases This patch adapts the other controllers that rely on

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 --- Comment #28 from Kyle M Hall --- Created attachment 148072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148072=edit Bug 33080: Allow pagination to be built from stashed values The way the old

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 Kyle M Hall changed: What|Removed |Added Attachment #148020|0 |1 is obsolete|

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 Kyle M Hall changed: What|Removed |Added QA Contact||k...@bywatersolutions.com --

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 Martin Renvoize changed: What|Removed |Added Attachment #147825|0 |1 is obsolete|

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 Martin Renvoize changed: What|Removed |Added Attachment #147824|0 |1 is obsolete|

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 Martin Renvoize changed: What|Removed |Added Attachment #147823|0 |1 is obsolete|

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 Tomás Cohen Arazi changed: What|Removed |Added URL|https://gitlab.com/thekesol |

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 Tomás Cohen Arazi changed: What|Removed |Added Assignee|agustinmoy...@theke.io |tomasco...@gmail.com

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 --- Comment #22 from Tomás Cohen Arazi --- Created attachment 147825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147825=edit Bug 33080: Adapt other use-cases This patch adapts the other controllers that rely

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 --- Comment #21 from Tomás Cohen Arazi --- Created attachment 147824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147824=edit Bug 33080: Allow pagination to be built from stashed values The way the old

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 --- Comment #20 from Tomás Cohen Arazi --- Created attachment 147823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147823=edit Bug 33080: Introduce objects.search_rs, objects.find_rs and objects.to_api This

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 Tomás Cohen Arazi changed: What|Removed |Added Attachment #147790|0 |1 is obsolete|

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 Tomás Cohen Arazi changed: What|Removed |Added Attachment #147789|0 |1 is obsolete|

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 Tomás Cohen Arazi changed: What|Removed |Added Attachment #147788|0 |1 is obsolete|

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 --- Comment #19 from Martin Renvoize --- Hmm.. well I liked where the branch was going.. but I wasn't aware of the additional calls we're already making to add_pagination_headers as yet so wasn't aware it was a bit of a faff.

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 Martin Renvoize changed: What|Removed |Added Attachment #147736|0 |1 is obsolete|

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 Martin Renvoize changed: What|Removed |Added Attachment #147735|0 |1 is obsolete|

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 Martin Renvoize changed: What|Removed |Added Attachment #147734|0 |1 is obsolete|

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 --- Comment #15 from Tomás Cohen Arazi --- Created attachment 147736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147736=edit Bug 33080: Add small warpper helper to call add_pagination_headers This patch

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 --- Comment #14 from Tomás Cohen Arazi --- Created attachment 147735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147735=edit Bug 33080: (follow-up) Minor cleanups Whilst reviewing I spotted a few calls to the

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 --- Comment #13 from Tomás Cohen Arazi --- Created attachment 147734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147734=edit Bug 33080: Introduce objects.search_rs, objects.find_rs and objects.to_api This

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 Tomás Cohen Arazi changed: What|Removed |Added Attachment #147663|0 |1 is obsolete|

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 Tomás Cohen Arazi changed: What|Removed |Added Attachment #147662|0 |1 is obsolete|

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 Tomás Cohen Arazi changed: What|Removed |Added Attachment #147720|0 |1 is obsolete|

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 --- Comment #12 from Tomás Cohen Arazi --- (In reply to Agustín Moyano from comment #11) > Hm... maybe you should leave add_pagination_headers as is, and create a new > helper called something like 'calc_pagination_numbers' that

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 --- Comment #11 from Agustín Moyano --- Hm... maybe you should leave add_pagination_headers as is, and create a new helper called something like 'calc_pagination_numbers' that creates total numbers and calls add_pagination_headers

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 --- Comment #10 from Tomás Cohen Arazi --- (In reply to Agustín Moyano from comment #9) > Sorry, made it in a hurry... And then Tomas told me he was actually working > on this with a different approach. So I'll just leave it to him

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 --- Comment #9 from Agustín Moyano --- Sorry, made it in a hurry... And then Tomas told me he was actually working on this with a different approach. So I'll just leave it to him to delete my patch. -- You are receiving this mail

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 --- Comment #7 from Agustín Moyano --- Created attachment 147720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147720=edit Bug 33080: (follow-up) Move pagination logic out of search_rs -- You are receiving this

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 --- Comment #6 from Agustín Moyano --- (In reply to Martin Renvoize from comment #4) > Comment on attachment 147662 [details] [review] > Bug 33080: Introduce objects.search_rs, objects.find_rs and objects.to_api > > Review of

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 Martin Renvoize changed: What|Removed |Added URL|

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 --- Comment #4 from Martin Renvoize --- Comment on attachment 147662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147662 Bug 33080: Introduce objects.search_rs, objects.find_rs and objects.to_api Review of

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 --- Comment #3 from Martin Renvoize --- Created attachment 147663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147663=edit Bug 33080: (follow-up) Minor cleanups Whilst reviewing I spotted a few calls to the

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 Martin Renvoize changed: What|Removed |Added Attachment #147469|0 |1 is obsolete|

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 Agustín Moyano changed: What|Removed |Added Blocks||32735 Referenced Bugs:

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 Agustín Moyano changed: What|Removed |Added Blocks||32734 Referenced Bugs:

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 Agustín Moyano changed: What|Removed |Added Patch complexity|--- |Trivial patch

[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 --- Comment #1 from Agustín Moyano --- Created attachment 147469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147469=edit Bug 33080: Introduce objects.search_rs, objects.find_rs and objects.to_api This patch