https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
Caroline Cyr La Rose changed:
What|Removed |Added
Documentation||Caroline Cyr La Rose
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
Fridolin Somers changed:
What|Removed |Added
Status|Pushed to main |Needs documenting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
Martin Renvoize changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
--- Comment #39 from Alex Buckley ---
(In reply to Katrin Fischer from comment #36)
> I am going to push this as is with a tiny follow up to explain that this
> only works for English 1-page. I think it would have been great to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
--- Comment #38 from Katrin Fischer ---
Pushed for 24.05!
Well done everyone, thank you!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
Katrin Fischer changed:
What|Removed |Added
Version(s)||24.05.00
released
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
--- Comment #37 from Katrin Fischer ---
I think we should also not set a text on update - this would be a surprising
change. Updated the database update accordingly.
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
--- Comment #36 from Katrin Fischer ---
I am going to push this as is with a tiny follow up to explain that this only
works for English 1-page. I think it would have been great to adapt all the
available notices as this won't be
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
--- Comment #35 from Alex Buckley ---
(In reply to Kyle M Hall from comment #34)
> While I tend to agree PDF generation isn't the greatest, this is a minor
> enhancement and it was far too onerous to ask to replace an entire
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
--- Comment #34 from Kyle M Hall ---
While I tend to agree PDF generation isn't the greatest, this is a minor
enhancement and it was far too onerous to ask to replace an entire subsystem to
add such a small enhancement. Let's get
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
Kyle M Hall changed:
What|Removed |Added
CC||k...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
--- Comment #33 from Kyle M Hall ---
Created attachment 163217
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163217=edit
Bug 33393: tidy layout1page.pm
Signed-off-by: Kyle M Hall
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
--- Comment #32 from Kyle M Hall ---
Created attachment 163216
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163216=edit
Bug 33393: Add note to system preference explaining text length
Sponsored-by: Pymble
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
--- Comment #31 from Kyle M Hall ---
Created attachment 163215
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163215=edit
Bug 33393: Enable libraries to configure their own text in the 1-Page order PDF
Test plan:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
Kyle M Hall changed:
What|Removed |Added
Attachment #150524|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
Kyle M Hall changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
--- Comment #29 from Alex Buckley ---
(In reply to Marcel de Rooy from comment #28)
> (In reply to Alex Buckley from comment #25)
> > Yes, Marcel if you wouldn't mind noting what you would want as
> > follow-ups/improvements here
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
--- Comment #28 from Marcel de Rooy ---
(In reply to Alex Buckley from comment #25)
> Yes, Marcel if you wouldn't mind noting what you would want as
> follow-ups/improvements here that would be helpful so we can raise them with
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
Marcel de Rooy changed:
What|Removed |Added
Status|In Discussion |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
--- Comment #26 from Marcel de Rooy ---
(In reply to Katrin Fischer from comment #24)
> (In reply to Marcel de Rooy from comment #23)
> > My current thought would be: I do not oppose this as a workaround with
> > commitment to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
--- Comment #25 from Alex Buckley ---
(In reply to Katrin Fischer from comment #24)
> (In reply to Marcel de Rooy from comment #23)
> > My current thought would be: I do not oppose this as a workaround with
> > commitment to follow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
--- Comment #24 from Katrin Fischer ---
(In reply to Marcel de Rooy from comment #23)
> My current thought would be: I do not oppose this as a workaround with
> commitment to follow up and improve.
Hi Marcel, what would you ask for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
--- Comment #23 from Marcel de Rooy ---
My current thought would be: I do not oppose this as a workaround with
commitment to follow up and improve.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
--- Comment #22 from Alex Buckley ---
Hi Marcel and Katrin,
Thanks both for your comments.
I have thought on both of them.
I agree that I am not a fan of enhancing the PDF files, especially since it is
possible for the user to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |In Discussion
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
--- Comment #20 from Katrin Fischer ---
Alex, maybe we (I...) should let you argue this one.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
Marcel de Rooy changed:
What|Removed |Added
Status|Failed QA |Signed Off
QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
--- Comment #18 from Katrin Fischer ---
(In reply to Marcel de Rooy from comment #17)
> (In reply to Katrin Fischer from comment #16)
> > (In reply to Marcel de Rooy from comment #15)
> > > +my $ordersentences =
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
--- Comment #17 from Marcel de Rooy ---
(In reply to Katrin Fischer from comment #16)
> (In reply to Marcel de Rooy from comment #15)
> > +my $ordersentences = C4::Context->preference("1PageOrderPDFText");
> >
> > Sorry, Alex.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
--- Comment #16 from Katrin Fischer ---
(In reply to Marcel de Rooy from comment #15)
> +my $ordersentences = C4::Context->preference("1PageOrderPDFText");
>
> Sorry, Alex. But we should not add text blocks into preferences. We
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
Marcel de Rooy changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
--- Comment #14 from Alex Buckley ---
(In reply to David Nind from comment #13)
> (In reply to Alex Buckley from comment #9)
> > Hi David,
> >
> > I have attached a patchset adding a note to the system preference
> > description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
--- Comment #13 from David Nind ---
(In reply to Alex Buckley from comment #9)
> Hi David,
>
> I have attached a patchset adding a note to the system preference
> description noting to keep the text length to 3 lines.
>
> Is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
David Nind changed:
What|Removed |Added
Attachment #150497|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
David Nind changed:
What|Removed |Added
Attachment #149106|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
David Nind changed:
What|Removed |Added
Attachment #149076|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
--- Comment #9 from Alex Buckley ---
Hi David,
I have attached a patchset adding a note to the system preference description
noting to keep the text length to 3 lines.
Is that what you had in mind?
Thanks,
Alex
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
--- Comment #8 from Alex Buckley ---
Created attachment 150497
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150497=edit
Bug 33393: Add note to system preference explaining text length
Sponsored-by: Pymble
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
--- Comment #7 from Alex Buckley ---
(In reply to David Nind from comment #6)
> Hi Alex.
>
> This works well.
>
> My only comment would be to add a hint or note to the 1PageOrderPDFText
> system preference about the length of the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
David Nind changed:
What|Removed |Added
CC||da...@davidnind.com
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
David Nind changed:
What|Removed |Added
Attachment #149078|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
--- Comment #4 from Alex Buckley ---
Created attachment 149079
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149079=edit
Custom text (highlighted yellow) that can be set in the 1PageOrderPDFText
syspref with bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
--- Comment #3 from Alex Buckley ---
Created attachment 149078
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149078=edit
Bug 33393: Enable libraries to configure their own text in the 1-Page order PDF
Test plan:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
Alex Buckley changed:
What|Removed |Added
Attachment #149077|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
Alex Buckley changed:
What|Removed |Added
Depends on||33340
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
Alex Buckley changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
--- Comment #2 from Alex Buckley ---
Created attachment 149077
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149077=edit
Bug 33393: Enable libraries to configure their own text in the 1-Page order PDF
Test plan:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
--- Comment #1 from Alex Buckley ---
Created attachment 149076
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149076=edit
Bug 33393: Add system preference
Sponsored-by: Pymble Ladies' College
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393
Alex Buckley changed:
What|Removed |Added
Change sponsored?|--- |Sponsored
51 matches
Mail list logo
