https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33668
Lucas Gass changed:
What|Removed |Added
Status|Signed Off |Patch doesn't apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33668
--- Comment #29 from Roman Dolny ---
Created attachment 169761
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169761&action=edit
Bug 33668: (follow-up) Ensure the clear button is added to the DOM only once
Every t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33668
--- Comment #28 from Roman Dolny ---
Created attachment 169760
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169760&action=edit
Bug 33668: (follow-up) Modify the JS logic behind the 'Clear search' button
When the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33668
--- Comment #27 from Roman Dolny ---
Created attachment 169759
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169759&action=edit
Bug 33668: (follow-up) Improve the appearance of the 'Clear search' button
Changed f
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33668
--- Comment #26 from Roman Dolny ---
Created attachment 169758
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169758&action=edit
Bug 33668: (follow-up) Adjust Font Awesome icon classes
Removed the fa-sharp class a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33668
--- Comment #25 from Roman Dolny ---
Created attachment 169757
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169757&action=edit
Bug 33668: (follow-up) Tidy up the code
Added spaces around the argument to translat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33668
--- Comment #24 from Roman Dolny ---
Created attachment 169756
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169756&action=edit
Bug 33668: Added clear button to global js
To test:
1. Apply the patch and perform a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33668
Roman Dolny changed:
What|Removed |Added
Attachment #169526|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33668
Roman Dolny changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are receiv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33668
--- Comment #22 from Andreas Roussos ---
The last follow-up patch has been amended and its Test plan
modified to account for the issue spotted by Roman.
I've also found out that in the initial patch the clear button
HTML code was be
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33668
--- Comment #21 from Andreas Roussos ---
Created attachment 169717
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169717&action=edit
Bug 33668: (follow-up) Ensure the clear button is added to the DOM only once
Eve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33668
Andreas Roussos changed:
What|Removed |Added
Attachment #169534|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33668
Andreas Roussos changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33668
Andreas Roussos changed:
What|Removed |Added
Status|Needs Signoff |ASSIGNED
--- Comment #19
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33668
Roman Dolny changed:
What|Removed |Added
CC||roman.do...@jezuici.pl
--- Co
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33668
Heather changed:
What|Removed |Added
CC||heather_hernan...@nps.gov
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33668
--- Comment #17 from Andreas Roussos ---
Created attachment 169534
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169534&action=edit
Bug 33668: (follow-up) Modify the JS logic behind the 'Clear search' button
In t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33668
--- Comment #16 from Andreas Roussos ---
Created attachment 169533
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169533&action=edit
Bug 33668: (follow-up) Improve the appearance of the 'Clear search' button
Chang
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33668
--- Comment #15 from Andreas Roussos ---
Created attachment 169532
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169532&action=edit
Bug 33668: (follow-up) Adjust Font Awesome icon classes
Removed the fa-sharp cla
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33668
--- Comment #14 from Andreas Roussos ---
Created attachment 169531
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169531&action=edit
Bug 33668: (follow-up) Tidy up the code
Added spaces around the argument to tran
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33668
Andreas Roussos changed:
What|Removed |Added
Patch complexity|--- |Small patch
S
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33668
--- Comment #13 from Andreas Roussos ---
Created attachment 169530
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169530&action=edit
Suggested improvements screenshot 3 (wide viewport)
Last screenshot in this seri
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33668
--- Comment #12 from Andreas Roussos ---
Created attachment 169529
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169529&action=edit
Suggested improvements screenshot 2 (mobile device)
Yet another screenshot, this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33668
--- Comment #11 from Andreas Roussos ---
Created attachment 169528
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169528&action=edit
Suggested improvements screenshot 1 (zoomed in)
This is a screenshot of the impr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33668
Andreas Roussos changed:
What|Removed |Added
Attachment #169525|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33668
--- Comment #9 from Andreas Roussos ---
Hmmm, I just noticed that after Roman's sign off your test plan
is missing from the commit message.
I'll try to re-attach my own sign off with the test plan included...
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33668
Andreas Roussos changed:
What|Removed |Added
Assignee|Laura.escamilla@bywatersolu |a.rous...@dataly.gr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33668
Andreas Roussos changed:
What|Removed |Added
Attachment #169446|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33668
Andreas Roussos changed:
What|Removed |Added
Attachment #169445|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33668
--- Comment #5 from Roman Dolny ---
Created attachment 169446
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169446&action=edit
Bug 33668: Add css for the clear button
Signed-off-by: Roman Dolny
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33668
Roman Dolny changed:
What|Removed |Added
Attachment #169443|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33668
Roman Dolny changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are receiv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33668
--- Comment #3 from Laura Escamilla ---
Created attachment 169444
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169444&action=edit
Bug 33668: Add css for the clear button
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33668
--- Comment #2 from Laura Escamilla ---
Created attachment 169443
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169443&action=edit
Bug 33668: Added clear button to global js
To test:
1. Apply the patch and perfor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33668
Laura Escamilla changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33668
Laura Escamilla changed:
What|Removed |Added
CC||Laura.escamilla@bywatersol
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33668
--- Comment #1 from Barbara Johnson ---
Created attachment 150602
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150602&action=edit
Search box with clear search feature
--
You are receiving this mail because:
You
37 matches
Mail list logo