[Koha-bugs] [Bug 34032] Holds expirationdate left blank if waiting status is reverted

2024-05-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34032 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.c

[Koha-bugs] [Bug 34032] Holds expirationdate left blank if waiting status is reverted

2024-04-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34032 --- Comment #26 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing l

[Koha-bugs] [Bug 34032] Holds expirationdate left blank if waiting status is reverted

2024-04-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34032 Katrin Fischer changed: What|Removed |Added Version(s)||24.05.00 released i

[Koha-bugs] [Bug 34032] Holds expirationdate left blank if waiting status is reverted

2024-04-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34032 --- Comment #25 from Katrin Fischer --- Kyle, you forgot to add your sign-off lines :) Also re-tidied Holds.t for the QA script - maybe different versions of Perltidy at work here? -- You are receiving this mail because: You are w

[Koha-bugs] [Bug 34032] Holds expirationdate left blank if waiting status is reverted

2024-04-12 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34032 --- Comment #24 from Kyle M Hall --- Created attachment 164825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164825&action=edit Bug 34032: (QA follow-up) Tidy code -- You are receiving this mail because: You are

[Koha-bugs] [Bug 34032] Holds expirationdate left blank if waiting status is reverted

2024-04-12 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34032 --- Comment #23 from Kyle M Hall --- Created attachment 164824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164824&action=edit Bug 34032: Use reserves.patron_expiration_date if set If reserves.patron_expiration_

[Koha-bugs] [Bug 34032] Holds expirationdate left blank if waiting status is reverted

2024-04-12 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34032 Kyle M Hall changed: What|Removed |Added Attachment #152535|0 |1 is obsolete|

[Koha-bugs] [Bug 34032] Holds expirationdate left blank if waiting status is reverted

2024-04-12 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34032 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receivi

[Koha-bugs] [Bug 34032] Holds expirationdate left blank if waiting status is reverted

2023-12-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34032 Esther Melander changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #2

[Koha-bugs] [Bug 34032] Holds expirationdate left blank if waiting status is reverted

2023-12-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34032 ByWater Sandboxes changed: What|Removed |Added Attachment #158516|0 |1 is obsolete|

[Koha-bugs] [Bug 34032] Holds expirationdate left blank if waiting status is reverted

2023-12-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34032 Esther Melander changed: What|Removed |Added CC||esther.melander@bywatersol

[Koha-bugs] [Bug 34032] Holds expirationdate left blank if waiting status is reverted

2023-11-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34032 Emmi Takkinen changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #

[Koha-bugs] [Bug 34032] Holds expirationdate left blank if waiting status is reverted

2023-11-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34032 --- Comment #17 from Emmi Takkinen --- (In reply to Katrin Fischer from comment #16) > Hi Emmi, I just came across bug 35306 that seems to be related and maybe > explains what we have been wondering about here. So it seems and expir

[Koha-bugs] [Bug 34032] Holds expirationdate left blank if waiting status is reverted

2023-11-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34032 --- Comment #16 from Katrin Fischer --- Hi Emmi, I just came across bug 35306 that seems to be related and maybe explains what we have been wondering about here. -- You are receiving this mail because: You are watching all bug chan

[Koha-bugs] [Bug 34032] Holds expirationdate left blank if waiting status is reverted

2023-11-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34032 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community

[Koha-bugs] [Bug 34032] Holds expirationdate left blank if waiting status is reverted

2023-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34032 --- Comment #15 from Emmi Takkinen --- (In reply to Katrin Fischer from comment #14) > (In reply to Emmi Takkinen from comment #13) > > We don't probably have to do anything to past dates, since they aren't > > displayed at all. If I

[Koha-bugs] [Bug 34032] Holds expirationdate left blank if waiting status is reverted

2023-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34032 --- Comment #14 from Katrin Fischer --- (In reply to Emmi Takkinen from comment #13) > We don't probably have to do anything to past dates, since they aren't > displayed at all. If I set reserves.expirationdate in past (or current da

[Koha-bugs] [Bug 34032] Holds expirationdate left blank if waiting status is reverted

2023-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34032 --- Comment #13 from Emmi Takkinen --- We don't probably have to do anything to past dates, since they aren't displayed at all. If I set reserves.expirationdate in past (or current date) through database, expiration date field is bla

[Koha-bugs] [Bug 34032] Holds expirationdate left blank if waiting status is reverted

2023-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34032 --- Comment #12 from Emmi Takkinen --- Created attachment 158516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158516&action=edit Bug 34032: Use reserves.patron_expiration_date if set If reserves.patron_expiratio

[Koha-bugs] [Bug 34032] Holds expirationdate left blank if waiting status is reverted

2023-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34032 --- Comment #11 from Katrin Fischer --- Sounds good to me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-commun

[Koha-bugs] [Bug 34032] Holds expirationdate left blank if waiting status is reverted

2023-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34032 --- Comment #10 from Emmi Takkinen --- (In reply to Katrin Fischer from comment #9) > (In reply to Emmi Takkinen from comment #8) > > (In reply to Marcel de Rooy from comment #5) > > > $hold->set( > > > { > > >

[Koha-bugs] [Bug 34032] Holds expirationdate left blank if waiting status is reverted

2023-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34032 --- Comment #9 from Katrin Fischer --- (In reply to Emmi Takkinen from comment #8) > (In reply to Marcel de Rooy from comment #5) > > $hold->set( > > { > > priority=> 1, > > found => unde

[Koha-bugs] [Bug 34032] Holds expirationdate left blank if waiting status is reverted

2023-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34032 --- Comment #8 from Emmi Takkinen --- (In reply to Marcel de Rooy from comment #5) > $hold->set( > { > priority=> 1, > found => undef, > waitingdate => undef, > ex

[Koha-bugs] [Bug 34032] Holds expirationdate left blank if waiting status is reverted

2023-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34032 --- Comment #7 from Emmi Takkinen --- (In reply to Marcel de Rooy from comment #4) > Did not finish this one completely now, but feel somehow that it needs more > attention still (qa intuition). Hmm. > > Reserves still contains: >

[Koha-bugs] [Bug 34032] Holds expirationdate left blank if waiting status is reverted

2023-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34032 --- Comment #6 from Emmi Takkinen --- Since it has been 4+ months since I worked on this, I'm utterly confused what I have been thinking while doing this. Looking into this again. -- You are receiving this mail because: You are wat

[Koha-bugs] [Bug 34032] Holds expirationdate left blank if waiting status is reverted

2023-09-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34032 --- Comment #5 from Marcel de Rooy --- $hold->set( { priority=> 1, found => undef, waitingdate => undef, expirationdate => $hold->patron_expiration_date,

[Koha-bugs] [Bug 34032] Holds expirationdate left blank if waiting status is reverted

2023-09-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34032 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #4 f

[Koha-bugs] [Bug 34032] Holds expirationdate left blank if waiting status is reverted

2023-09-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34032 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 34032] Holds expirationdate left blank if waiting status is reverted

2023-09-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34032 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -

[Koha-bugs] [Bug 34032] Holds expirationdate left blank if waiting status is reverted

2023-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34032 Sam Lau changed: What|Removed |Added Attachment #152516|0 |1 is obsolete|

[Koha-bugs] [Bug 34032] Holds expirationdate left blank if waiting status is reverted

2023-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34032 Sam Lau changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving

[Koha-bugs] [Bug 34032] Holds expirationdate left blank if waiting status is reverted

2023-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34032 Emmi Takkinen changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are r

[Koha-bugs] [Bug 34032] Holds expirationdate left blank if waiting status is reverted

2023-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34032 --- Comment #1 from Emmi Takkinen --- Created attachment 152516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152516&action=edit Bug 34032: Set new expirationdate if waiting status is reverted When one reverts ho

[Koha-bugs] [Bug 34032] Holds expirationdate left blank if waiting status is reverted

2023-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34032 Emmi Takkinen changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiv

[Koha-bugs] [Bug 34032] Holds expirationdate left blank if waiting status is reverted

2023-06-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34032 Emmi Takkinen changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |emmi.takki...@koha-suomi.fi