https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
--- Comment #50 from Pedro Amorim ---
Nice work everyone!
Pushed to 22.11.x for next release
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs maili
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
Pedro Amorim changed:
What|Removed |Added
Version(s)|23.11.00,23.05.06 |23.11.00,23.05.06,22.11.12
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
Fridolin Somers changed:
What|Removed |Added
Status|Pushed to master|Pushed to stable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
--- Comment #48 from Tomás Cohen Arazi ---
Pushed to master for 23.11.
Nice work everyone, thanks!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
Tomás Cohen Arazi changed:
What|Removed |Added
Version(s)||23.11.00
release
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
Martin Renvoize changed:
What|Removed |Added
Blocks||35285
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
Martin Renvoize changed:
What|Removed |Added
Blocks|30287 |
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
Martin Renvoize changed:
What|Removed |Added
Text to go in the||The patch removes the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
Martin Renvoize changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
Martin Renvoize changed:
What|Removed |Added
Attachment #158637|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
--- Comment #47 from Martin Renvoize ---
Created attachment 158643
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158643&action=edit
Bug 34704: Remove regex for adding additional line breaks to print templates
Thi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
Martin Renvoize changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
Martin Renvoize changed:
What|Removed |Added
Attachment #158602|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
Martin Renvoize changed:
What|Removed |Added
Attachment #158603|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
Martin Renvoize changed:
What|Removed |Added
Attachment #158604|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
--- Comment #46 from Martin Renvoize ---
(In reply to Katrin Fischer from comment #43)
> It comes from here:
>
> my $template =
> C4::Templates::gettemplate( 'batch/print-notices.tt', 'intranet',
> CGI->new );
>
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
--- Comment #45 from Katrin Fischer ---
I thought instead of the 3 that are going to be a little confusing, I'll throw
in an alternate - let me know what you think.
--
You are receiving this mail because:
You are watching all bug c
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
--- Comment #44 from Katrin Fischer ---
Created attachment 158637
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158637&action=edit
Bug 34704: [Alternate] Remove regex for adding additional line breaks to print
tem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
Katrin Fischer changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
--- Comment #43 from Katrin Fischer ---
It comes from here:
my $template =
C4::Templates::gettemplate( 'batch/print-notices.tt', 'intranet',
CGI->new );
And then the template takes care of it:
[% IF
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #42
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
--- Comment #41 from Katrin Fischer ---
Since we changed course here - should we squash and adapt the test plan in
first commit message?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
--- Comment #40 from Katrin Fischer ---
WARN misc/cronjobs/gather_print_notices.pl
WARN tidiness
The file is less tidy than before (bad/messy lines before: 92,
now: 93)
Fixed in amended last patch.
--
You a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
Martin Renvoize changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
--- Comment #39 from Martin Renvoize ---
Back to you Katrin.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-comm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
Martin Renvoize changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
--- Comment #37 from Martin Renvoize ---
Created attachment 158604
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158604&action=edit
Bug 34704: Replace regex with wrap for non-html based notices
If a notice is mar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
Martin Renvoize changed:
What|Removed |Added
Attachment #157303|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
Martin Renvoize changed:
What|Removed |Added
Attachment #156230|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
--- Comment #34 from Martin Renvoize ---
I just wrote bug 35279 to make this simpler to test ;).
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs ma
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
Martin Renvoize changed:
What|Removed |Added
See Also||https://bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
--- Comment #33 from Martin Renvoize ---
My point wasn't to add a database update here.. more that we perhaps need to
really clearly state that the processing for print notices has changed and that
any html notices used for print wil
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
--- Comment #32 from Katrin Fischer ---
(In reply to Martin Renvoize from comment #31)
> I also vaguely wonder about br Vs p in the template update context.. but
> that's just a random thought after the fact
I don't think there is a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
--- Comment #31 from Martin Renvoize ---
I also vaguely wonder about br Vs p in the template update context.. but that's
just a random thought after the fact
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
--- Comment #30 from Martin Renvoize ---
I've asked Matt to take a look and comment as he was a little closer to the
original request. I have a feeling we may need to further update the notices
that were causing our customers proble
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
--- Comment #29 from Katrin Fischer ---
Thx for the help on the bugs - what is our conclusion here? Do we remove the
regex?
--
You are receiving this mail because:
You are watching all bug changes.
_
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
Martin Renvoize changed:
What|Removed |Added
Blocks||35268
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
Martin Renvoize changed:
What|Removed |Added
See Also||https://bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
Martin Renvoize changed:
What|Removed |Added
See Also||https://bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
Martin Renvoize changed:
What|Removed |Added
See Also||https://bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
Martin Renvoize changed:
What|Removed |Added
Blocks||30287
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
--- Comment #28 from Katrin Fischer ---
I spent quite a bit of time on this one and on fixing our sample notices. It
would be nice to keep the conversation going.
--
You are receiving this mail because:
You are watching all bug cha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
--- Comment #27 from Katrin Fischer ---
I wanted to check the 'size' of this problem a bit more and did some testing.
And it's not as bad as one would think:
I tested the HTML notices especially and the results are interesting:
1)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
Katrin Fischer changed:
What|Removed |Added
Depends on||35187
Referenced Bugs:
h
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
Katrin Fischer changed:
What|Removed |Added
Depends on||35186
Referenced Bugs:
h
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
Katrin Fischer changed:
What|Removed |Added
Depends on||35185
Referenced Bugs:
h
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
--- Comment #26 from Martin Renvoize ---
In my perfect world you'd have WYSIWYG and Codemirror options.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
--- Comment #25 from Martin Renvoize ---
I think if we're going whole hog here, we likely would want to switch the
editor to allow the WYSIWYG option for html input to keep the simplicity option
at user disposal.
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
--- Comment #24 from Martin Renvoize ---
OK, I see you're points now.
This was meant to be "least invasive", but I do agree it would be nice to drop
it entirely and require proper HTML throughout for these notices.
The challenge wi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
--- Comment #23 from Lucas Gass ---
> For consistency: How do these templates behave when looked at in the notices
> tab or when sent per email?
Im my tests/examples I used overdue notices ( ODUE ), so what I see in notice
tab/email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
--- Comment #22 from Katrin Fischer ---
(In reply to Lucas Gass from comment #20)
> I have a question. When we tick the box to make a notice an HTML message (
> is_html=1 ) do we expect in the entire template to marked up? In Matt's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
--- Comment #21 from Lucas Gass ---
So I guess the question is whether or not we should allow for this mix of
html/non-html content.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
--- Comment #20 from Lucas Gass ---
I have a question. When we tick the box to make a notice an HTML message (
is_html=1 ) do we expect in the entire template to marked up? In Matt's example
that is the case.
I ask because we have a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
--- Comment #19 from Katrin Fischer ---
I thought I was clear: Can you explain why we are adding at all?
It feels like this is an unneded change.
We either have an HTML template, then we are good.
Or we have a plain text template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
--- Comment #18 from Martin Renvoize ---
We spent quite a bit of time working through this, and it's in production at
all our sites now.
I think you need to be clearer about what changes you're expecting, Katrin..
It's not at all cl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
Martin Renvoize changed:
What|Removed |Added
Depends on||34728
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
--- Comment #17 from Katrin Fischer ---
I am still a bit confused by this patch/script.
It looks like we always turn an empty line into a . It seems an improvement
from previous behavior, but I wonder if it's correct.
What I would
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
Katrin Fischer changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
Martin Renvoize changed:
What|Removed |Added
Patch complexity|--- |Trivial patch
S
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
--- Comment #16 from Matt Blenkinsop ---
Completely missed this - I've added the modifier, good spot
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
--- Comment #15 from Matt Blenkinsop ---
Created attachment 157303
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157303&action=edit
Bug 34704: (QA follow-up): Add multi-line modifier
This patch adds a multi line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
Matt Blenkinsop changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
Matt Blenkinsop changed:
What|Removed |Added
Attachment #156229|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
Matt Blenkinsop changed:
What|Removed |Added
Attachment #155503|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
--- Comment #12 from Matt Blenkinsop ---
Created attachment 156229
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156229&action=edit
Bug 34704: Stop tags being entered on every line in html letter
templates
This
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
Matt Blenkinsop changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
Matt Blenkinsop changed:
What|Removed |Added
See Also||https://bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
--- Comment #10 from Jonathan Druart ---
(In reply to Lucas Gass from comment #9)
> (In reply to Jonathan Druart from comment #6)
> > I don't think this is correct. You will still need to add br tags for non
> > HTML notice templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
--- Comment #9 from Lucas Gass ---
(In reply to Jonathan Druart from comment #6)
> I don't think this is correct. You will still need to add br tags for non
> HTML notice templates, or it will be on a single line :)
Isn't this only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
--- Comment #8 from Jonathan Druart ---
And please write a meaningful commit *title*.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
--- Comment #7 from Jonathan Druart ---
And please write a meaningful commit message.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
Martin Renvoize changed:
What|Removed |Added
CC||jonathan.druart+koha@gmail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
Matt Blenkinsop changed:
What|Removed |Added
Severity|enhancement |trivial
--
You are recei
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
--- Comment #5 from Martin Renvoize ---
Thanks Lucas.. I wasn't aware if the Collapse filter, but I think this is a
great fix to have and it makes me happy to know it wasn't just us running into
it.
--
You are receiving this mail b
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
--- Comment #4 from Lucas Gass ---
Simple, but very nice quality of life improvement. I have been wrapping all of
my HTML notices in [% filter COLLAPSE %] to avoid this.
--
You are receiving this mail because:
You are watching all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
Lucas Gass changed:
What|Removed |Added
Attachment #155196|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
Lucas Gass changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
Martin Renvoize changed:
What|Removed |Added
See Also||https://bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
Martin Renvoize changed:
What|Removed |Added
CC||katrin.fisc...@bsz-bw.de,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
Martin Renvoize changed:
What|Removed |Added
CC||martin.renvoize@ptfs-europ
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
Matt Blenkinsop changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
--- Comment #2 from Matt Blenkinsop ---
Text to test with:
<> <> <>
<>
<>
<>
<>
<>
Library:
<>
Telephone:
<>
Email:
<>
Dear <> <>
Membership number: <>
HOLD AVA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
--- Comment #1 from Matt Blenkinsop ---
Created attachment 155196
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155196&action=edit
Bug 34704: Fix regex
This patch amends a regex check to stop tags from being add
86 matches
Mail list logo
