https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
Martin Renvoize changed:
What|Removed |Added
CC|martin.renvoize@ptfs-europe |
|.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
Victor Grousset/tuxayo changed:
What|Removed |Added
Blocks||36708
Referenced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
Lucas Gass changed:
What|Removed |Added
Status|Pushed to stable|Pushed to oldstable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
Fridolin Somers changed:
What|Removed |Added
Status|Pushed to master|Pushed to stable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
--- Comment #46 from Katrin Fischer ---
Pushed for 24.05!
Well done everyone, thank you!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing l
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
Katrin Fischer changed:
What|Removed |Added
Status|Passed QA |Pushed to master
V
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
Martin Renvoize changed:
What|Removed |Added
Status|Signed Off |Passed QA
--- Comment #45
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
Martin Renvoize changed:
What|Removed |Added
Attachment #160896|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
Marcel de Rooy changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--- Comment #43
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
Marcel de Rooy changed:
What|Removed |Added
Attachment #160844|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
Marcel de Rooy changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
--- Comment #41 from Marcel de Rooy ---
Back to Assigned. Needs more attention still :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing lis
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
Marcel de Rooy changed:
What|Removed |Added
Status|Failed QA |ASSIGNED
--
You are recei
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
--- Comment #40 from Marcel de Rooy ---
Will rebuild my container completely.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
--- Comment #39 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #35)
> (In reply to Marcel de Rooy from comment #29)
> > I was not able to recreate a JS error in the console.
>
> With the sample data, click "Edit"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
--- Comment #38 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #34)
> (In reply to Marcel de Rooy from comment #33)
> > Wondering if we really need this btw, but it should not harm either:
>
> No we don't, I was t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
Marcel de Rooy changed:
What|Removed |Added
Attachment #160845|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
--- Comment #36 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #35)
> (In reply to Marcel de Rooy from comment #29)
> > (In reply to Jonathan Druart from comment #25)
> > > Marcel, I think I have fixed the problem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Failed QA
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
--- Comment #35 from Jonathan Druart ---
(In reply to Marcel de Rooy from comment #29)
> (In reply to Jonathan Druart from comment #25)
> > Marcel, I think I have fixed the problem you were facing. However I am
> > failing at hiding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
--- Comment #34 from Jonathan Druart ---
(In reply to Marcel de Rooy from comment #33)
> Wondering if we really need this btw, but it should not harm either:
>
> diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc
> b
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
--- Comment #33 from Marcel de Rooy ---
Wondering if we really need this btw, but it should not harm either:
diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc
b/koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
--- Comment #32 from Marcel de Rooy ---
Martin or Matt, could one of you have a final look? Three members of QA team
already did until now :)
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
--- Comment #31 from Marcel de Rooy ---
Created attachment 160845
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160845&action=edit
Bug 35341: Do not reinstantiate flatpickr
We do not need to reinstantiate flatpic
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
Marcel de Rooy changed:
What|Removed |Added
Attachment #159669|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
Marcel de Rooy changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
--- Comment #29 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #25)
> Marcel, I think I have fixed the problem you were facing. However I am
> failing at hiding the error (not a JS Error object, but something appea
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
--- Comment #28 from Marcel de Rooy ---
Adding the above change since item_text does contain more than a date in the
first case. It also includes the Before/On/After text part for the first date.
--
You are receiving this mail beca
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
--- Comment #27 from Marcel de Rooy ---
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
index e3edc701bc..f3c57ad25e 100644
--- a/koha-tmpl/intr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
--- Comment #26 from Marcel de Rooy ---
Ah great. I am looking further now. Thanks.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Ko
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
Jonathan Druart changed:
What|Removed |Added
CC||paul.dersch...@lmscloud.de
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
--- Comment #25 from Jonathan Druart ---
Marcel, I think I have fixed the problem you were facing. However I am failing
at hiding the error (not a JS Error object, but something appearing in the
console) raised by is_valid_date (actu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
--- Comment #24 from Jonathan Druart ---
Created attachment 160830
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160830&action=edit
Bug 35341: Do not reinstantiate flatpickr
We do not need to reinstantiate flatpi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
--- Comment #23 from Marcel de Rooy ---
As a separate function:
+function add_clear_button (input) {
+/* Append a "clear date" link */
+$(input).find('~input.flatpickr:first')
+/* Add a wrapper elemen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
--- Comment #22 from Marcel de Rooy ---
Hmm. This comes from flatpickr instantiation etc. Not my favorite waste of
time:
Calendar.inc contains:
onReady: function( selectedDates, dateStr, instance ){
/* When fla
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
--- Comment #21 from Marcel de Rooy ---
Looking here again
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-commun
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.druart+koha@gmail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
--- Comment #20 from Martin Renvoize ---
OK, maybe I'm confused.. looks like it shows the currently selected date prior
to change rather than the other pickers date. My mistake.
First issue about repeated X is still valid however.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
Martin Renvoize changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #19
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
--- Comment #18 from Marcel de Rooy ---
Note that this patch makes sure that the dates are not kept when saving or
clearing the rule in the edit row.
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
Marcel de Rooy changed:
What|Removed |Added
Assignee|matt.blenkinsop@ptfs-europe |m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
--- Comment #17 from Marcel de Rooy ---
(In reply to Matt Blenkinsop from comment #12)
> I've taken your test patch Marcel and made some changes so that it now only
> uses flatpickr rather than adding additional hidden inputs to hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
Marcel de Rooy changed:
What|Removed |Added
QA Contact|m.de.r...@rijksmuseum.nl|martin.renvoize@ptfs-europe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
Marcel de Rooy changed:
What|Removed |Added
Attachment #159077|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
Marcel de Rooy changed:
What|Removed |Added
Patch complexity|--- |Small patch
St
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
--- Comment #15 from Marcel de Rooy ---
Still some issues here:
Template process failed: undef error - The given date (0NaN-aN-aN) does not
match the date format (iso) at /usr/share/koha/Koha/DateUtils.pm line 205.
=> Try another da
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |BLOCKED
--- Comment #14 fr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
--- Comment #13 from Marcel de Rooy ---
(In reply to Matt Blenkinsop from comment #12)
> I've taken your test patch Marcel and made some changes so that it now only
> uses flatpickr rather than adding additional hidden inputs to hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
Matt Blenkinsop changed:
What|Removed |Added
Status|Failed QA |Signed Off
--- Comment #1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
Matt Blenkinsop changed:
What|Removed |Added
Attachment #159591|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
--- Comment #11 from Matt Blenkinsop ---
Created attachment 159592
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159592&action=edit
Bug 35341: Fix circulation rule dates being overwritten
This patch correctly set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
Matt Blenkinsop changed:
What|Removed |Added
Attachment #159005|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
Martin Renvoize changed:
What|Removed |Added
Severity|minor |major
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
Marcel de Rooy changed:
What|Removed |Added
Status|BLOCKED |Failed QA
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
--- Comment #9 from Marcel de Rooy ---
Created attachment 159077
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159077&action=edit
Bug 35341: Testing
--
You are receiving this mail because:
You are watching all b
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
--- Comment #8 from Marcel de Rooy ---
I think that we are not going in the right direction here with the hidden
backup inputs. We are trying to solve a flatpickr issue here. We should do that
differently.
Seeing several related bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
--- Comment #7 from Marcel de Rooy ---
This really is a rabbit hole ;)
This = smart rules..
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |BLOCKED
--- Comment #6 fro
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
--- Comment #5 from Katrin Fischer ---
(In reply to Matt Blenkinsop from comment #3)
> No it doesn't look like it - this is a separate issue spotted by one of our
> customers
>
> Bug 34826 is the most similar but I think that one re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
David Nind changed:
What|Removed |Added
Attachment #158980|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
--- Comment #3 from Matt Blenkinsop ---
No it doesn't look like it - this is a separate issue spotted by one of our
customers
Bug 34826 is the most similar but I think that one relates more to bug 34269
--
You are receiving this m
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
--- Comment #2 from Katrin Fischer ---
Hi Matt,
I noticed we have quite a lot of "bugs" related to circulation rules right now.
I didn't have time to dig deeper yet, but could this one relate to one of these
as well?
Bug 34151 - H
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
Matt Blenkinsop changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
--- Comment #1 from Matt Blenkinsop ---
Created attachment 158980
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158980&action=edit
Bug 35341: Fix ciruclation rule dates being overwritten
This patch correctly sets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
Matt Blenkinsop changed:
What|Removed |Added
Severity|enhancement |minor
Assignee|
67 matches
Mail list logo
