[Koha-bugs] [Bug 36374] Some of our JS files should stay tidy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize changed: What|Removed |Added Blocks|36120 | Referenced Bugs:

[Koha-bugs] [Bug 36374] Some of our JS files should stay tidy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Bug 36374 depends on bug 35616, which changed state. Bug 35616 Summary: Add a 'source' field to Koha::Tickets to denote the path taken to report the ticket https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35616

[Koha-bugs] [Bug 36374] Some of our JS files should stay tidy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Aude Charillon changed: What|Removed |Added Resolution|--- |FIXED

[Koha-bugs] [Bug 36374] Some of our JS files should stay tidy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Fridolin Somers changed: What|Removed |Added CC|

[Koha-bugs] [Bug 36374] Some of our JS files should stay tidy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize changed: What|Removed |Added Depends on||35616 Referenced Bugs:

[Koha-bugs] [Bug 36374] Some of our JS files should stay tidy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Katrin Fischer changed: What|Removed |Added Keywords|rel_24_05_candidate | -- You are receiving

[Koha-bugs] [Bug 36374] Some of our JS files should stay tidy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 --- Comment #41 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing

[Koha-bugs] [Bug 36374] Some of our JS files should stay tidy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to main

[Koha-bugs] [Bug 36374] Some of our JS files should stay tidy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize changed: What|Removed |Added Attachment #165737|0 |1 is obsolete|

[Koha-bugs] [Bug 36374] Some of our JS files should stay tidy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize changed: What|Removed |Added Attachment #165736|0 |1 is obsolete|

[Koha-bugs] [Bug 36374] Some of our JS files should stay tidy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize changed: What|Removed |Added Attachment #165735|0 |1 is obsolete|

[Koha-bugs] [Bug 36374] Some of our JS files should stay tidy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize changed: What|Removed |Added Attachment #165734|0 |1 is obsolete|

[Koha-bugs] [Bug 36374] Some of our JS files should stay tidy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize changed: What|Removed |Added Attachment #165733|0 |1 is obsolete|

[Koha-bugs] [Bug 36374] Some of our JS files should stay tidy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize changed: What|Removed |Added Attachment #165732|0 |1 is obsolete|

[Koha-bugs] [Bug 36374] Some of our JS files should stay tidy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize changed: What|Removed |Added Status|Patch doesn't apply |Passed QA -- You are

[Koha-bugs] [Bug 36374] Some of our JS files should stay tidy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize changed: What|Removed |Added Attachment #163596|0 |1 is obsolete|

[Koha-bugs] [Bug 36374] Some of our JS files should stay tidy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize changed: What|Removed |Added Attachment #163595|0 |1 is obsolete|

[Koha-bugs] [Bug 36374] Some of our JS files should stay tidy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize changed: What|Removed |Added Attachment #163594|0 |1 is obsolete|

[Koha-bugs] [Bug 36374] Some of our JS files should stay tidy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize changed: What|Removed |Added Attachment #163593|0 |1 is obsolete|

[Koha-bugs] [Bug 36374] Some of our JS files should stay tidy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize changed: What|Removed |Added Attachment #163592|0 |1 is obsolete|

[Koha-bugs] [Bug 36374] Some of our JS files should stay tidy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize changed: What|Removed |Added Attachment #163591|0 |1 is obsolete|

[Koha-bugs] [Bug 36374] Some of our JS files should stay tidy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Patch doesn't apply

[Koha-bugs] [Bug 36374] Some of our JS files should stay tidy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment

[Koha-bugs] [Bug 36374] Some of our JS files should stay tidy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 --- Comment #26 from Jonathan Druart --- Additionally having it on directory basis is less flexible. We can still have both, and so refine later if needed ;) -- You are receiving this mail because: You are watching all bug

[Koha-bugs] [Bug 36374] Some of our JS files should stay tidy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 --- Comment #25 from Jonathan Druart --- I would not block it now that we have the QA script and the git hook that have been published already. We need to start with something, we can improve later if needed. The more we wait the

[Koha-bugs] [Bug 36374] Some of our JS files should stay tidy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 --- Comment #24 from Pedro Amorim --- Hey, adding my opinion here. This should be 2 different bugs, one specifically as a bookings modal follow-up tidy and restructuring, and the other bug for the keep JS files tidy stuff. The

[Koha-bugs] [Bug 36374] Some of our JS files should stay tidy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 36374] Some of our JS files should stay tidy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Marcel de Rooy changed: What|Removed |Added Severity|minor |enhancement

[Koha-bugs] [Bug 36374] Some of our JS files should stay tidy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --

[Koha-bugs] [Bug 36374] Some of our JS files should stay tidy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 --- Comment #22 from Martin Renvoize --- Given Jonathans input here I've signed off his follow-ups and think we're OK to go for at least Signed off. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 36374] Some of our JS files should stay tidy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 36374] Some of our JS files should stay tidy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 --- Comment #21 from Martin Renvoize --- Created attachment 163596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163596=edit Bug 36374: Also tidy ticket and concern modals js This patch does the promised

[Koha-bugs] [Bug 36374] Some of our JS files should stay tidy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize changed: What|Removed |Added Attachment #163589|0 |1 is obsolete|

[Koha-bugs] [Bug 36374] Some of our JS files should stay tidy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize changed: What|Removed |Added Attachment #163588|0 |1 is obsolete|

[Koha-bugs] [Bug 36374] Some of our JS files should stay tidy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize changed: What|Removed |Added Attachment #163560|0 |1 is obsolete|

[Koha-bugs] [Bug 36374] Some of our JS files should stay tidy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize changed: What|Removed |Added Attachment #163559|0 |1 is obsolete|

[Koha-bugs] [Bug 36374] Some of our JS files should stay tidy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize changed: What|Removed |Added Attachment #163558|0 |1 is obsolete|

[Koha-bugs] [Bug 36374] Some of our JS files should stay tidy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 --- Comment #15 from Martin Renvoize --- I think this is a better first step than my initial attempt.. I was considering a centralised file to list files we should be keeping tidy, but that felt more messy and likely to fall out of

[Koha-bugs] [Bug 36374] Some of our JS files should stay tidy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 --- Comment #14 from Jonathan Druart --- See also: git hook changes: https://gitlab.com/koha-community/koha-testing-docker/-/issues/414 qa script changes: https://gitlab.com/koha-community/qa-test-tools/-/issues/81 -- You are

[Koha-bugs] [Bug 36374] Some of our JS files should stay tidy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 --- Comment #13 from Jonathan Druart --- It may be more convenient to add several paths (like here 'modals' and 'fetch'), but then we will need to adjust the 3 different paths, and this is something we should avoid I think. Not

[Koha-bugs] [Bug 36374] Some of our JS files should stay tidy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 --- Comment #12 from Jonathan Druart --- Created attachment 163589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163589=edit Bug 36374: Keep tidy files from 'fetch' directory And tidy them -- You are receiving

[Koha-bugs] [Bug 36374] Some of our JS files should stay tidy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Jonathan Druart changed: What|Removed |Added Summary|The bookings modal JS |Some of our JS files