[Koha-bugs] [Bug 36483] Calling $object->to_api directly should be avoided

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36483 Tomás Cohen Arazi changed: What|Removed |Added Depends on||33080 Referenced Bugs:

[Koha-bugs] [Bug 36483] Calling $object->to_api directly should be avoided

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36483 --- Comment #1 from Tomás Cohen Arazi --- I meant to say that when bug 33080 introduced this, we should've reviewed all controllers. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for

[Koha-bugs] [Bug 36483] Calling $object->to_api directly should be avoided

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36483 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com

[Koha-bugs] [Bug 36483] Calling $object->to_api directly should be avoided

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36483 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |ASSIGNED -- You are re

[Koha-bugs] [Bug 36483] Calling $object->to_api directly should be avoided

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36483 Tomás Cohen Arazi changed: What|Removed |Added See Also||https://bugs.koha-commun

[Koha-bugs] [Bug 36483] Calling $object->to_api directly should be avoided

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36483 Tomás Cohen Arazi changed: What|Removed |Added CC||jonathan.dru...@gmail.co

[Koha-bugs] [Bug 36483] Calling $object->to_api directly should be avoided

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36483 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|--- |Trivial patch

[Koha-bugs] [Bug 36483] Calling $object->to_api directly should be avoided

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36483 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 164264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164264&action=edit Bug 36483: Make API controllers use $c->objects->to_api Signed-off-by: Tomas Co

[Koha-bugs] [Bug 36483] Calling $object->to_api directly should be avoided

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36483 Tomás Cohen Arazi changed: What|Removed |Added Attachment #164264|0 |1 is obsolete|

[Koha-bugs] [Bug 36483] Calling $object->to_api directly should be avoided

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36483 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 164267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164267&action=edit Bug 36483: Patrons.pm use case This case brought my attention as there was a di

[Koha-bugs] [Bug 36483] Calling $object->to_api directly should be avoided

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36483 Tomás Cohen Arazi changed: What|Removed |Added Blocks||36495 Referenced Bugs:

[Koha-bugs] [Bug 36483] Calling $object->to_api directly should be avoided

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36483 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receivi

[Koha-bugs] [Bug 36483] Calling $object->to_api directly should be avoided

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36483 David Nind changed: What|Removed |Added Attachment #164266|0 |1 is obsolete|

[Koha-bugs] [Bug 36483] Calling $object->to_api directly should be avoided

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36483 David Nind changed: What|Removed |Added Attachment #164267|0 |1 is obsolete|

[Koha-bugs] [Bug 36483] Calling $object->to_api directly should be avoided

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36483 --- Comment #7 from Jonathan Druart --- > Created attachment 164294 [details] [review] > Bug 36483: Patrons.pm use case > > This case brought my attention as there was a different 'user' parameter > being passed. > It turns out we a

[Koha-bugs] [Bug 36483] Calling $object->to_api directly should be avoided

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36483 --- Comment #8 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #7) > > Created attachment 164294 [details] [review] [review] > > Bug 36483: Patrons.pm use case > > > > This case brought my attention as there was

[Koha-bugs] [Bug 36483] Calling $object->to_api directly should be avoided

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36483 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -

[Koha-bugs] [Bug 36483] Calling $object->to_api directly should be avoided

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36483 --- Comment #10 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #9) > Looks good to me. Do we actually have examples where passing this user makes > a difference in to_api ? Seems to do nothing in Koha::Patron??

[Koha-bugs] [Bug 36483] Calling $object->to_api directly should be avoided

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36483 --- Comment #11 from Martin Renvoize --- It's the redaction stuff. Though talking to Tomas at hackfest I think we both agreed it doesn't entirely make sense that one could edit, add a user with fields that aren't accessible to them..

[Koha-bugs] [Bug 36483] Calling $object->to_api directly should be avoided

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36483 Martin Renvoize changed: What|Removed |Added QA Contact||martin.renvoize@ptfs-europ

[Koha-bugs] [Bug 36483] Calling $object->to_api directly should be avoided

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36483 --- Comment #12 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #10) > (In reply to Marcel de Rooy from comment #9) > > Looks good to me. Do we actually have examples where passing this user makes > > a difference

[Koha-bugs] [Bug 36483] Calling $object->to_api directly should be avoided

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36483 Marcel de Rooy changed: What|Removed |Added QA Contact|martin.renvoize@ptfs-europe |m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 36483] Calling $object->to_api directly should be avoided

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36483 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are rece

[Koha-bugs] [Bug 36483] Calling $object->to_api directly should be avoided

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36483 Marcel de Rooy changed: What|Removed |Added Attachment #164293|0 |1 is obsolete|

[Koha-bugs] [Bug 36483] Calling $object->to_api directly should be avoided

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36483 Marcel de Rooy changed: What|Removed |Added Attachment #164294|0 |1 is obsolete|

[Koha-bugs] [Bug 36483] Calling $object->to_api directly should be avoided

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36483 Katrin Fischer changed: What|Removed |Added Version(s)||24.05.00 released i

[Koha-bugs] [Bug 36483] Calling $object->to_api directly should be avoided

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36483 --- Comment #15 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing l

[Koha-bugs] [Bug 36483] Calling $object->to_api directly should be avoided

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36483 Fridolin Somers changed: What|Removed |Added Version(s)|24.05.00|24.05.00,23.11.06

[Koha-bugs] [Bug 36483] Calling $object->to_api directly should be avoided

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36483 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com