https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
Raphael Straub changed:
What|Removed |Added
Change sponsored?|--- |Sponsored
Assign
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
--- Comment #1 from Raphael Straub ---
Created attachment 164379
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164379&action=edit
Bug 36503: Add a plugin hook after user authentication
This plugin hook allows to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
Raphael Straub changed:
What|Removed |Added
Status|NEW |Needs Signoff
Patch comp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
Michaela Sieber changed:
What|Removed |Added
See Also||https://bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
Mark Hofstetter changed:
What|Removed |Added
CC||k...@trust-box.at
--- Com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
Michael Skarupianski changed:
What|Removed |Added
CC||michael.skarupianski@
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
--- Comment #3 from Clemens Tubach ---
Hi Marc,
we have added a test plugin, see attached file.
This plugins write "Bug 36503: Hook test" into field "OPAC note" from the user
currently logging in.
To test:
1) Install and configure S
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
--- Comment #4 from Clemens Tubach ---
Created attachment 164628
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164628&action=edit
Plugin to test the hook
--
You are receiving this mail because:
You are watching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
--- Comment #5 from Clemens Tubach ---
Hi Marc,
if plugins are disabled and the if statement does not exist, we get following
error message:
"There was an error authenticating to external identity provider
Can't call method "GetPlu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
Thomas Klausner changed:
What|Removed |Added
CC||d...@plix.at
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
--- Comment #7 from Thomas Klausner ---
Created attachment 164893
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164893&action=edit
Screenshot showing that it worked!
Just a small screenshot showing that the test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
--- Comment #8 from Thomas Klausner ---
Also note that the unit test does not work after running the manual test plan
and installing the pluging, so run the unit test before the manual test!
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
Thomas Klausner changed:
What|Removed |Added
Attachment #164379|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
Thomas Klausner changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
Michaela Sieber changed:
What|Removed |Added
CC||dc...@prosentient.com.au,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
--- Comment #10 from David Cook ---
Hmm sounds interesting. There's all kinds of interesting/useful things you
could do with a plugin hook like this.
I'm not sure about the plugin method name. Despite this bug's title, I suppose
yo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
--- Comment #11 from David Cook ---
Hmm... wouldn't it make more sense to run this plugin just before returning?
That way you could also have access to the $domain, and you'd have access to
the default values coming from the domain
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
--- Comment #12 from Raphael Straub ---
(In reply to David Cook from comment #10)
> I'm not sure about the plugin method name. Despite this bug's title, I
> suppose you wouldn't be required to "modify" the user. This is just a method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
--- Comment #13 from Raphael Straub ---
(In reply to David Cook from comment #11)
> Hmm... wouldn't it make more sense to run this plugin just before returning?
Maybe, but I wanted to use the update on auth parameter of the domain,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
--- Comment #14 from Raphael Straub ---
Created attachment 165466
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165466&action=edit
Bug 36503: (follow-up) Move the plugin hook to include the domain
This allows the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
--- Comment #15 from Michaela Sieber ---
(In reply to David Cook from comment #11)
> Hmm... wouldn't it make more sense to run this plugin just before returning?
>
> That way you could also have access to the $domain, and you'd hav
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
--- Comment #16 from David Cook ---
(In reply to Raphael Straub from comment #13)
> In our use case having access to the domain is not necessary, but calling
> the hook before $patron->…->store with the domain as an additional argume
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
--- Comment #17 from Michaela Sieber ---
(In reply to David Cook from comment #16)
> (In reply to Raphael Straub from comment #13)
> > In our use case having access to the domain is not necessary, but calling
> > the hook before $pat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
Katrin Fischer changed:
What|Removed |Added
Keywords||rel_24_05_candidate
--
Yo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
Martin Renvoize changed:
What|Removed |Added
CC||martin.renvoize@ptfs-europ
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
--- Comment #19 from Raphael Straub ---
(In reply to Martin Renvoize from comment #18)
Hi Martin,
> It looks like you missed Marks comment about removing the 'enable_plugins'
> section...
no, as Clemens wrote in comment #5 the if s
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
--- Comment #20 from Raphael Straub ---
Created attachment 166050
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166050&action=edit
Bug 36503: (follow-up) Use the call method of Koha::Plugins
This removes the opti
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
--- Comment #21 from Martin Renvoize ---
Sorry Raphael, I was distracted by all the release activity happening right
now.
I'm going to take a pass through this now; I didn't mean to block it. Regards
the prioritising I hadn't spott
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
Martin Renvoize changed:
What|Removed |Added
See Also||https://bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
Martin Renvoize changed:
What|Removed |Added
Attachment #164894|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
Martin Renvoize changed:
What|Removed |Added
Attachment #165466|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
Martin Renvoize changed:
What|Removed |Added
Attachment #166050|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
--- Comment #25 from Martin Renvoize ---
Created attachment 166114
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166114&action=edit
Bug 36503: Fix unit tests
Signed-off-by: Martin Renvoize
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
--- Comment #26 from Martin Renvoize ---
Created attachment 166115
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166115&action=edit
Bug 36503: (follow-up) Simplify code by passing by reference
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
--- Comment #27 from Martin Renvoize ---
Created attachment 166116
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166116&action=edit
Bug 36503: Move and update unit test
--
You are receiving this mail because:
Yo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
Martin Renvoize changed:
What|Removed |Added
Status|Failed QA |Passed QA
QA Cont
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
--- Comment #29 from Martin Renvoize ---
For reference, we've been moving to:
->call( 'hook_name', { action => 'action_name', payload => { key => value, . .
. } });
See the 'before_x_action' and 'after_x_action' hooks added to Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
--- Comment #30 from Clemens Tubach ---
(In reply to Martin Renvoize from comment #26)
> Created attachment 166115 [details] [review]
> Bug 36503: (follow-up) Simplify code by passing by reference
Hi Martin,
thanks for your work and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
Katrin Fischer changed:
What|Removed |Added
Status|Passed QA |Failed QA
--- Comment #31
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
--- Comment #32 from Martin Renvoize ---
(In reply to Clemens Tubach from comment #30)
> (In reply to Martin Renvoize from comment #26)
> > Created attachment 166115 [details] [review] [review]
> > Bug 36503: (follow-up) Simplify cod
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
--- Comment #33 from Martin Renvoize ---
I'll add to the unit test for you
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@l
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
--- Comment #34 from Raphael Straub ---
(In reply to Martin Renvoize from comment #32)
> (In reply to Clemens Tubach from comment #30)
> > So, with your patch, $patron is still undefined after calling the hook.
>
> That should still
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
--- Comment #35 from Martin Renvoize ---
Not forgotten this.. just iterating on the unit test and restoring the
functionality you've highlighted regressed.
--
You are receiving this mail because:
You are watching all bug changes.
_
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
Martin Renvoize changed:
What|Removed |Added
Attachment #166111|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
Martin Renvoize changed:
What|Removed |Added
Attachment #166112|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
Martin Renvoize changed:
What|Removed |Added
Attachment #166113|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
Martin Renvoize changed:
What|Removed |Added
Attachment #166114|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
Martin Renvoize changed:
What|Removed |Added
Attachment #166116|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
Martin Renvoize changed:
What|Removed |Added
Attachment #166115|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
Martin Renvoize changed:
What|Removed |Added
Status|Failed QA |Passed QA
--- Comment #41
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
--- Comment #42 from Katrin Fischer ---
Thank to everyone for their perseverance :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Ko
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
Katrin Fischer changed:
What|Removed |Added
Keywords||additional_work_needed
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #166462|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
--- Comment #45 from Tomás Cohen Arazi ---
Created attachment 166532
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166532&action=edit
Bug 36503: (follow-up) Fix tests count
Signed-off-by: Tomas Cohen Arazi
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
--- Comment #46 from Katrin Fischer ---
Thanks for the quick work, Tomas!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@li
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
Katrin Fischer changed:
What|Removed |Added
Status|Passed QA |Pushed to main
Ver
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
--- Comment #47 from Katrin Fischer ---
Pushed for 24.05!
Well done everyone, thank you!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing l
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
Katrin Fischer changed:
What|Removed |Added
Keywords|rel_24_05_candidate |release-notes-needed
--- C
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
Michaela Sieber changed:
What|Removed |Added
Keywords|release-notes-needed|
Text to go in the|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
--- Comment #49 from Michaela Sieber ---
Is it possible to backport this hook to 23.11?
I have updated the Wiki page and added a text for release notes
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
Fridolin Somers changed:
What|Removed |Added
CC||fridolin.som...@biblibre.c
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
Katrin Fischer changed:
What|Removed |Added
Keywords|additional_work_needed |
--- Comment #51 from Katr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
--- Comment #52 from Fridolin Somers ---
(In reply to Michaela Sieber from comment #49)
> Is it possible to backport this hook to 23.11?
>
> I have updated the Wiki page and added a text for release notes
Sure, but we are close to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
Fridolin Somers changed:
What|Removed |Added
Version(s)|24.05.00|24.05.00,23.11.07
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
--- Comment #54 from Michaela Sieber ---
(In reply to Fridolin Somers from comment #53)
> Pushed to 23.11.x for 23.11.07
Thank You!
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
Fridolin Somers changed:
What|Removed |Added
Depends on||35536
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
--- Comment #55 from Fridolin Somers ---
UT depends on Bug 35536
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
Martin Renvoize changed:
What|Removed |Added
CC|martin.renvoize@ptfs-europe |
|.com
68 matches
Mail list logo