https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546
--- Comment #24 from Tomás Cohen Arazi ---
Created attachment 165550
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165550&action=edit
[OPTIONAL] Bug 36546: Use JSON instead
Signed-off-by: Tomas Cohen Arazi
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546
Tomás Cohen Arazi changed:
What|Removed |Added
Status|In Discussion |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546
--- Comment #23 from Paul Derscheid ---
Would be interesting how JSON would perform compared to yaml as the spec is
much simpler. Maybe worth a try?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546
--- Comment #22 from Julian Maurice ---
(In reply to Tomás Cohen Arazi from comment #2)
> Didier and I made some testing and bundling the spec reduces the startup
> time significantly (5x).
I see an improvement but not that signific
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546
--- Comment #21 from Paul Derscheid ---
Still leaving this in discussion for additional opinions but the approach is
sane, the gain is measurable and all tests pass (which is to be expected, but
still..).
Would love for this to move
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546
Paul Derscheid changed:
What|Removed |Added
Attachment #165446|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546
Paul Derscheid changed:
What|Removed |Added
Attachment #165412|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546
--- Comment #18 from Julian Maurice ---
(In reply to David Cook from comment #16)
> I think perhaps we should use swagger.yml for development, and then we could
> build swagger_bundle.yml during the build.
I would say: use swagger_
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546
Paul Derscheid changed:
What|Removed |Added
CC||m...@paulderscheid.xyz
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546
--- Comment #16 from David Cook ---
I think perhaps we should use swagger.yml for development, and then we could
build swagger_bundle.yml during the build.
In koha-testing-docker, Koha is starting so fast I can't catch the Swagger
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546
--- Comment #15 from David Cook ---
Created attachment 165446
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165446&action=edit
Bug 36546: Fix js-yaml dependency in package.json
--
You are receiving this mail bec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546
David Cook changed:
What|Removed |Added
Status|Failed QA |In Discussion
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546
--- Comment #14 from David Cook ---
Comment on attachment 165412
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165412
Bug 36546: Add a bundled version of the API spec
Review of attachment 165412:
-->
(https://b
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546
--- Comment #13 from David Cook ---
(In reply to David Cook from comment #12)
> Btw, I think the problem is that "js-yaml" is in "resolutions" in our
> package.json.
>
> That's overriding the dependency for @redocly/openapi-core it
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546
--- Comment #12 from David Cook ---
Btw, I think the problem is that "js-yaml" is in "resolutions" in our
package.json.
That's overriding the dependency for @redocly/openapi-core it seems.
Looks like Owen did that back in 2019 for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546
--- Comment #11 from David Cook ---
(In reply to David Cook from comment #10)
> Now I can get redocly to run, but it looks like this isn't going to work out
> of the box...
kohadev-koha@kohadevbox:koha(bug36546)$ redocly bundle
api/
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546
David Cook changed:
What|Removed |Added
Status|In Discussion |Failed QA
--- Comment #10 from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546
--- Comment #9 from Tomás Cohen Arazi ---
(In reply to David Cook from comment #8)
> rm -rf node_modules/
> yarn install
>
> Still doesn't work.
>
> Trying to troubleshoot the issue, but it looks like it should be working
> when I
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546
--- Comment #8 from David Cook ---
rm -rf node_modules/
yarn install
Still doesn't work.
Trying to troubleshoot the issue, but it looks like it should be working when I
look through the JS files.
--
You are receiving this mail be
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546
--- Comment #7 from David Cook ---
If I take down Koha and try to start it up, it breaks koha-testing-docker as it
fails on the yarn api:bundle and exits.
--
You are receiving this mail because:
You are watching all bug changes.
__
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546
--- Comment #6 from David Cook ---
(In reply to Tomás Cohen Arazi from comment #4)
> Putting this here for review/discussion.
>
> Feedback is welcome!
Unfortunately, I couldn't get this patch to work.
I did a "yarn install" then "
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
--- C
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546
Tomás Cohen Arazi changed:
What|Removed |Added
Status|NEW |In Discussion
--- Comme
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546
--- Comment #3 from Tomás Cohen Arazi ---
Created attachment 165412
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165412&action=edit
Bug 36546: Add a bundled version of the API spec
This patch makes the Koha::RES
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546
Tomás Cohen Arazi changed:
What|Removed |Added
CC||k...@bywatersolutions.co
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546
--- Comment #2 from Tomás Cohen Arazi ---
Didier and I made some testing and bundling the spec reduces the startup time
significantly (5x).
--
You are receiving this mail because:
You are watching all bug changes.
_
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546
Tomás Cohen Arazi changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546
Jonathan Druart changed:
What|Removed |Added
See Also||https://bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546
Jonathan Druart changed:
What|Removed |Added
CC||d...@plix.at,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546
Julian Maurice changed:
What|Removed |Added
CC||julian.maur...@biblibre.com
30 matches
Mail list logo
