[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Thibaud Guillot changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |thibaud.guil...@biblibre.c

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Thibaud Guillot changed: What|Removed |Added Depends on||29002 Referenced Bugs:

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Thibaud Guillot changed: What|Removed |Added Change sponsored?|--- |Sponsored See A

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Thibaud Guillot changed: What|Removed |Added Status|NEW |Needs Signoff -- You are

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 --- Comment #1 from Thibaud Guillot --- Created attachment 167010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167010&action=edit Bug 36915: Send email notification when a booking is cancelled When a booking is

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@gmail.com

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Thibaud Guillot changed: What|Removed |Added Attachment #167010|0 |1 is obsolete|

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 --- Comment #4 from Thibaud Guillot --- (In reply to Jonathan Druart from comment #2) > Shouldn't this be in $booking->delete instead? Thanks for your feedback, you're right.. I was wrong :) -- You are receiving this mail because:

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #5

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Thibaud Guillot changed: What|Removed |Added Blocks||36789 Referenced Bugs:

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Thibaud Guillot changed: What|Removed |Added Blocks||37034 Referenced Bugs:

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europ

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europ

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Martin Renvoize changed: What|Removed |Added See Also|https://bugs.koha-community |https://bugs.koha-communit

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Martin Renvoize changed: What|Removed |Added Attachment #167013|0 |1 is obsolete|

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 --- Comment #8 from Martin Renvoize --- Created attachment 168150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168150&action=edit Bug 36915: (follow-up) Pass object to GetPreparedLetter This patch updates the lo

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 --- Comment #9 from Martin Renvoize --- I added the suggested follow-up to utilise the 'objects' option in GetPreparedLetter. Still needs unit tests.. I'll try to take a look at adding those when I can. I'm also working on a defaul

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 --- Comment #10 from Martin Renvoize --- Created attachment 168155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168155&action=edit Bug 36915: (follow-up) Basic sample notice -- You are receiving this mail becau

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Martin Renvoize changed: What|Removed |Added Blocks||3 Referenced Bugs:

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 David Nind changed: What|Removed |Added CC||da...@davidnind.com

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 --- Comment #12 from Martin Renvoize --- Speaking to ByWater and their partners using Bookings, they would indeed want to keep the booking around for reports down the line. I think we should add a 'status' field to bookings to track

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Martin Renvoize changed: What|Removed |Added CC|martin.renvoize@ptfs-europe | |.com

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Paul Derscheid changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 --- Comment #13 from Paul Derscheid --- Created attachment 170058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170058&action=edit Bug 36915: (follow-up) Make basic sample notice html and add breaks -- You are r

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Paul Derscheid changed: What|Removed |Added CC||paul.dersch...@lmscloud.de

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receivi

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 David Nind changed: What|Removed |Added Attachment #168149|0 |1 is obsolete|

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 David Nind changed: What|Removed |Added Attachment #168150|0 |1 is obsolete|

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 David Nind changed: What|Removed |Added Attachment #168155|0 |1 is obsolete|

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 David Nind changed: What|Removed |Added Attachment #170058|0 |1 is obsolete|

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 David Nind changed: What|Removed |Added Text to go in the||This enhancement sends a

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Nick Clemens (kidclamp) changed: What|Removed |Added Status|Signed Off |Failed QA

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Paul Derscheid changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 --- Comment #20 from Paul Derscheid --- Created attachment 170099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170099&action=edit Bug 36915: (follow-up) Include branchname in sample notice -- You are receiving

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 --- Comment #21 from Paul Derscheid --- That last patch adds the missing branchname of the pickup library to the notice. Other sample notices include a lot of fields of the library object, not sure whether we should do this here as

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Nick Clemens (kidclamp) changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Paul Derscheid changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 --- Comment #22 from Paul Derscheid --- Created attachment 170155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170155&action=edit Bug 36915: (follow-up) Add tests -- You are receiving this mail because: You are

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 --- Comment #23 from Paul Derscheid --- Questions: > Should this notice always be sent? Hold cancellations have a 'reason' and > nothing is sent when the reason is skipped. I think we should have something > similar here - suppose

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexit

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Owen Leonard changed: What|Removed |Added Attachment #170077|0 |1 is obsolete|

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 --- Comment #25 from Owen Leonard --- Created attachment 170204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170204&action=edit Bug 36915: (follow-up) Pass object to GetPreparedLetter This patch updates the logi

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 --- Comment #26 from Owen Leonard --- Created attachment 170205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170205&action=edit Bug 36915: (follow-up) Basic sample notice Signed-off-by: David Nind Signed-off-by

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 --- Comment #27 from Owen Leonard --- Created attachment 170206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170206&action=edit Bug 36915: (follow-up) Make basic sample notice html and add breaks Signed-off-by:

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 --- Comment #28 from Owen Leonard --- Created attachment 170207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170207&action=edit Bug 36915: (follow-up) Include branchname in sample notice Signed-off-by: Owen Leon

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 --- Comment #29 from Owen Leonard --- Created attachment 170208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170208&action=edit Bug 36915: (follow-up) Add tests Signed-off-by: Owen Leonard -- You are receivin

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Martin Renvoize changed: What|Removed |Added Attachment #170203|0 |1 is obsolete|

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Martin Renvoize changed: What|Removed |Added Attachment #170204|0 |1 is obsolete|

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Martin Renvoize changed: What|Removed |Added Attachment #170205|0 |1 is obsolete|

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Martin Renvoize changed: What|Removed |Added Attachment #170206|0 |1 is obsolete|

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Martin Renvoize changed: What|Removed |Added Attachment #170207|0 |1 is obsolete|

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Martin Renvoize changed: What|Removed |Added Attachment #170208|0 |1 is obsolete|

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 --- Comment #36 from Martin Renvoize --- Created attachment 170391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170391&action=edit Bug 36915: (QA follow-up) Passing less to encourage traversal I generally push f

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #37

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Martin Renvoize changed: What|Removed |Added Blocks||37202 Referenced Bugs:

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Martin Renvoize changed: What|Removed |Added Blocks||37203 Referenced Bugs:

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Martin Renvoize changed: What|Removed |Added Blocks||37204 Referenced Bugs:

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Martin Renvoize changed: What|Removed |Added Circulation||bookings functi

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Katrin Fischer changed: What|Removed |Added Keywords||additional_work_needed ---

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 --- Comment #39 from Paul Derscheid --- Yes, there are plans, but we wanted to move the control aspect into follow-up bugs. -- You are receiving this mail because: You are watching all bug changes. _

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 --- Comment #40 from Katrin Fischer --- (In reply to Paul Derscheid from comment #39) > Yes, there are plans, but we wanted to move the control aspect into > follow-up bugs. Is it an option to have it for this release? I think than

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Katrin Fischer changed: What|Removed |Added Version(s)||24.11.00 released i

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 --- Comment #41 from Katrin Fischer --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing l