https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
Katrin Fischer changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
Victor Grousset/tuxayo changed:
What|Removed |Added
Status|Pushed to oldstable |RESOLVED
Re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
Andrew Fuerste-Henry changed:
What|Removed |Added
Status|Pushed to stable|Pushed to oldstable
-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
Andrew Fuerste-Henry changed:
What|Removed |Added
Status|Pushed to master|Pushed to stable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
Jonathan Druart changed:
What|Removed |Added
Keywords|rel_20_11_target|
--
You are receiving thi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
--- Comment #53 from Jonathan Druart
---
Pushed to master for 20.11, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
Jonathan Druart changed:
What|Removed |Added
Version(s)||20.11.00
released i
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
Martin Renvoize changed:
What|Removed |Added
CC||martin.renvoize@ptfs-europe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
Martin Renvoize changed:
What|Removed |Added
Attachment #113781|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
Martin Renvoize changed:
What|Removed |Added
Attachment #113692|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
Martin Renvoize changed:
What|Removed |Added
Attachment #113691|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
Jonathan Druart changed:
What|Removed |Added
Keywords|RM_priority |rel_20_11_target
--
You a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
--- Comment #48 from Jonathan Druart
---
(In reply to Nick Clemens from comment #45)
> Created attachment 113781 [details] [review] [review]
> On the OPAC when you click the back button the fields are not enabled - on
> the staff sid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
--- Comment #47 from Jonathan Druart
---
(In reply to Nick Clemens from comment #45)
> Created attachment 113781 [details] [review]
> On the OPAC when you click the back button the fields are not enabled - on
> the staff side they ar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
--- Comment #46 from David Cook ---
(In reply to Jonathan Druart from comment #44)
Thanks for clarifying, Jonathan! Makes sense.
(In reply to Nick Clemens from comment #45)
> On the OPAC when you click the back button the fields are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
--- Comment #45 from Nick Clemens ---
Created attachment 113781
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113781&action=edit
Bug 7607: (follow-up) Address OPAC and limits
This patch adds the same function to t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
Nick Clemens changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are receiv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
--- Comment #44 from Jonathan Druart
---
(In reply to David Cook from comment #43)
> (In reply to Jonathan Druart from comment #42)
> > 1. Those patches don't affect the OPAC
>
> That's a good point but I don't know that it's worth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
--- Comment #43 from David Cook ---
(In reply to Jonathan Druart from comment #42)
> 1. Those patches don't affect the OPAC
That's a good point but I don't know that it's worth failing it?
> 2. Same problem exists with the "limit" p
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Failed QA
--- Comment #42
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
Josef Moravec changed:
What|Removed |Added
CC||josef.mora...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
Josef Moravec changed:
What|Removed |Added
Attachment #113683|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
Josef Moravec changed:
What|Removed |Added
Attachment #113682|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
Victor Grousset/tuxayo changed:
What|Removed |Added
CC||vic...@tuxayo.net
-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #113134|0 |1
is obsolet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #113133|0 |1
is obsolet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
Jonathan Druart changed:
What|Removed |Added
Keywords||RM_priority
QA Con
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
--- Comment #35 from David Cook ---
(In reply to Nick Clemens from comment #34)
> In chrome and firefox the field is enabled again when hitting back. visually
> it is probably less jarring to see the field disabled versus removed so I
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
--- Comment #34 from Nick Clemens ---
(In reply to David Cook from comment #33)
> (In reply to Nick Clemens from comment #31)
> > (In reply to Jonathan Druart from comment #28)
> > > To prevent the values to be sent maybe we could dis
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
Nick Clemens changed:
What|Removed |Added
Attachment #112964|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
--- Comment #33 from David Cook ---
(In reply to Nick Clemens from comment #31)
> (In reply to Jonathan Druart from comment #28)
> > To prevent the values to be sent maybe we could disable the elements instead
> > of removing them fro
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
--- Comment #32 from David Cook ---
(In reply to Nick Clemens from comment #29)
> Signed-off-by: David Nind
>
> Signed-off-by: David Cook
>
> https://bugs.koha-community.org/show_bug.cgi?id=7606
Ooops I think I introduced an extr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
--- Comment #31 from Nick Clemens ---
(In reply to Jonathan Druart from comment #28)
> To prevent the values to be sent maybe we could disable the elements instead
> of removing them from the DOM. What do you think?
It seems to work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
--- Comment #29 from Nick Clemens ---
Created attachment 113133
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113133&action=edit
Bug 7607: Remove empty inputs when submitting search form
This patch surrounds the o
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
--- Comment #30 from Nick Clemens ---
Created attachment 113134
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113134&action=edit
Bug 7607: (follow-up) Disable rather than remove inputs
--
You are receiving this m
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
--- Comment #28 from Jonathan Druart
---
To prevent the values to be sent maybe we could disable the elements instead of
removing them from the DOM. What do you think?
--
You are receiving this mail because:
You are watching all bu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
Jonathan Druart changed:
What|Removed |Added
Assignee|jonathan.dru...@bugs.koha-c |n...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
David Cook changed:
What|Removed |Added
Blocks||25548
Referenced Bugs:
https:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
David Cook changed:
What|Removed |Added
Attachment #111064|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
--- Comment #26 from David Cook ---
Ok this issue is really annoying me, so let's get it sorted...
Test plan:
0. No patch
1. Go to
http://localhost:8081/cgi-bin/koha/catalogue/search.pl?expanded_options=1
2. Change 2nd "Keyword" and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
--- Comment #24 from David Cook ---
Comment on attachment 112912
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112912
Bug 7607: [Alternate] Remove empty inputs when submitting search form
Review of attachment 1129
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
David Nind changed:
What|Removed |Added
Attachment #112912|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are receivin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
--- Comment #23 from Katrin Fischer ---
(In reply to Nick Clemens from comment #22)
> hopefully helping and not muddying, adding an alternate patch to remove the
> whole search (index, query, operator) if there is no value provided
T
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
Nick Clemens changed:
What|Removed |Added
CC||n...@bywatersolutions.com
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
--- Comment #21 from Nick Clemens ---
Created attachment 112912
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112912&action=edit
Bug 7607: [Alternate] Remove empty inputs when submitting search form
This patch sur
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
Nick Clemens changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
--- Comment #20 from David Cook ---
(In reply to David Cook from comment #17)
> Actually, we have a customization that does something like this patch, and
> it actually causes the problem to be worse.
>
> If you set the idx element v
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
--- Comment #19 from David Cook ---
(In reply to David Cook from comment #18)
> And if people are worried about ugly URLs, then I think they should open a
> new bug report to remove unused search boxes in advanced search from the DOM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
--- Comment #18 from David Cook ---
(In reply to Jonathan Druart from comment #16)
> If we have the change from bug 25548, this issue will get fixed.
I agree. Bug 25548 would resolve Bug 7607.
And if people are worried about ugly UR
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
--- Comment #16 from Jonathan Druart
---
If we have the change from bug 25548, this issue will get fixed.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koh
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
--- Comment #15 from Katrin Fischer ---
I believe major is justified as this is an issue we've run into multiple times
over the years and it affects the OPAC search and so is confusing to users.
I am not sure how it relates to bug 25
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |BLOCKED
--- Comment #14 fr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
--- Comment #13 from Jonathan Druart
---
(In reply to Marcel de Rooy from comment #12)
> Should this really be marked as Major btw ?
I fixed it because it was marked as major :)
--
You are receiving this mail because:
You are watc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
--- Comment #12 from Marcel de Rooy ---
Should this really be marked as Major btw ?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koh
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
Marcel de Rooy changed:
What|Removed |Added
QA Contact||m.de.r...@rijksmuseum.nl
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
--- Comment #11 from Marcel de Rooy ---
QA Comment: Works, but kind of tweaky ;)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-b
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
--- Comment #10 from Marcel de Rooy ---
Created attachment 111065
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111065&action=edit
Bug 7607: (QA follow-up) Add comment line to new submit action
The solution here i
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
Marcel de Rooy changed:
What|Removed |Added
Attachment #110849|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
Marcel de Rooy changed:
What|Removed |Added
Patch complexity|--- |Small patch
Sta
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
Fridolin SOMERS changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
David Nind changed:
What|Removed |Added
Attachment #110845|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are receivin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
Jonathan Druart changed:
What|Removed |Added
Attachment #107963|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
Jonathan Druart changed:
What|Removed |Added
Assignee|gmcha...@gmail.com |jonathan.dru...@bugs.koha-c
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
--- Comment #4 from Jonathan Druart
---
Created attachment 107963
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107963&action=edit
Bug 7607: Fix adv search when leaving fields empty
We have a rewrite rule in our
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
Jonathan Druart changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
Marjorie Barry-Vila changed:
What|Removed |Added
CC||marjorie.barry-vila@col
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
Jared Camins-Esakov changed:
What|Removed |Added
CC|jcam...@cpbibliography.com |
--
You are receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
Fridolin SOMERS changed:
What|Removed |Added
CC||fridolyn.som...@biblibre.co
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
mathieu saby changed:
What|Removed |Added
CC||mathieu.saby@univ-rennes2.f
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
Katrin Fischer changed:
What|Removed |Added
CC||jcam...@cpbibliography.com
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
Koha Team Lyon 3 changed:
What|Removed |Added
CC||k...@univ-lyon3.fr
--- Com
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
Jared Camins-Esakov changed:
What|Removed |Added
Blocks||9234
--
You are receiv
78 matches
Mail list logo