http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Janet McGowan changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
Blocks|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
Blocks|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
Blocks|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Julian Maurice julian.maur...@biblibre.com changed:
What|Removed |Added
Status|Pushed to Master
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
Blocks|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
Blocks|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
Blocks|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
See Also|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
Blocks|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
Blocks|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
See Also|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
Blocks|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
See Also|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
See Also|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
Blocks|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Galen Charlton gmcha...@gmail.com changed:
What|Removed |Added
Status|Passed QA |Pushed to
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Paul Poulain paul.poul...@biblibre.com changed:
What|Removed |Added
Blocks||3934
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Galen Charlton gmcha...@gmail.com changed:
What|Removed |Added
Keywords|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
--- Comment #109 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 19393
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19393action=edit
Bug 7688: Add unit tests for C4::Serials::GetNextSeq()
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
--- Comment #110 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 19395
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19395action=edit
Bug 7688: Rewrite 'for' loop in unit tests
--
You are
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
--- Comment #105 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 19368
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19368action=edit
Bug 7688: Add unit tests for C4::Serials::Frequency
--
You
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
--- Comment #106 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 19369
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19369action=edit
Bug 7688: Add unit tests for C4::Serials::Numberpattern
--
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
--- Comment #107 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 19370
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19370action=edit
Bug 7688: Add unit tests for C4::Serials::GetNextDate()
--
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
--- Comment #108 from Julian Maurice julian.maur...@biblibre.com ---
Here are some unit tests for the two added Perl modules, plus unit tests for
GetNextDate().
I'm currently working on unit tests for GetNextSeq().
--
You are
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Paul Poulain paul.poul...@biblibre.com changed:
What|Removed |Added
Status|Signed Off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
--- Comment #101 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
This is a huge patch. I am a bit worried of incorporating this without feedback
from a library using serials and subscriptions - especially worried about the
database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Galen Charlton gmcha...@gmail.com changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
--- Comment #104 from Galen Charlton gmcha...@gmail.com ---
(In reply to Paul Poulain from comment #102)
(In reply to Katrin Fischer from comment #101)
This is a huge patch. I am a bit worried of incorporating this without
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Julian Maurice julian.maur...@biblibre.com changed:
What|Removed |Added
Attachment #18298|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Julian Maurice julian.maur...@biblibre.com changed:
What|Removed |Added
Attachment #18299|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Julian Maurice julian.maur...@biblibre.com changed:
What|Removed |Added
Attachment #17855|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Julian Maurice julian.maur...@biblibre.com changed:
What|Removed |Added
Attachment #17856|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Julian Maurice julian.maur...@biblibre.com changed:
What|Removed |Added
Attachment #17857|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:
What|Removed |Added
Attachment #17283|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:
What|Removed |Added
Attachment #17284|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:
What|Removed |Added
Attachment #17285|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:
What|Removed |Added
Status|Needs Signoff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Julian Maurice julian.maur...@biblibre.com changed:
What|Removed |Added
Attachment #16679|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Julian Maurice julian.maur...@biblibre.com changed:
What|Removed |Added
Attachment #16744|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
--- Comment #90 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 17285
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17285action=edit
Bug 7688: Rewrite t/db_dependant/Serials.t
A lot of tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Julian Maurice julian.maur...@biblibre.com changed:
What|Removed |Added
Status|ASSIGNED
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
--- Comment #83 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 16744
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16744action=edit
Bug 7688: Set firstacquidate in updatedatabase if it's not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Julian Maurice julian.maur...@biblibre.com changed:
What|Removed |Added
Status|Failed QA
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
--- Comment #85 from Jared Camins-Esakov jcam...@cpbibliography.com ---
(In reply to comment #84)
this patch is for 1) and 2)
Thanks.
3) It is possible to create a new numbering pattern from the subscription
add/modify screen.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Jared Camins-Esakov jcam...@cpbibliography.com changed:
What|Removed |Added
Status|Passed QA
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Jared Camins-Esakov jcam...@cpbibliography.com changed:
What|Removed |Added
Status|Pushed to Master
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Paul Poulain paul.poul...@biblibre.com changed:
What|Removed |Added
Status|Signed Off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Paul Poulain paul.poul...@biblibre.com changed:
What|Removed |Added
Attachment #15536|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
--- Comment #77 from Paul Poulain paul.poul...@biblibre.com ---
Created attachment 16680
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16680action=edit
[PASSED QA] Bug 7688 follow-up: Small fixes for QA
- #
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
--- Comment #78 from Paul Poulain paul.poul...@biblibre.com ---
Created attachment 16681
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16681action=edit
[PASSED QA] Bug 7688 follow-up: Small fixes for QA #2
- return
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
--- Comment #79 from Paul Poulain paul.poul...@biblibre.com ---
Created attachment 16682
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16682action=edit
[PASSED QA] Bug 7688: Translate sample frequencies for french
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
--- Comment #80 from Paul Poulain paul.poul...@biblibre.com ---
Created attachment 16683
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16683action=edit
[PASSED QA] Bug 7688: Fix generating next serial when there is no
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
--- Comment #81 from Paul Poulain paul.poul...@biblibre.com ---
Created attachment 16684
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16684action=edit
[PASSED QA] Bug 7688: Followup FIX perldoc
Signed-off-by:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Jared Camins-Esakov jcam...@cpbibliography.com changed:
What|Removed |Added
Status|Passed QA
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
--- Comment #67 from Paul Poulain paul.poul...@biblibre.com ---
(In reply to comment #66)
For me it's very very good. I suppose that someone with more experience or
data in subscriptions could test more extensively.
Just FYI, this
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
--- Comment #68 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 15534
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15534action=edit
Bug 7688: Followup FIX perldoc
--
You are receiving this
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:
What|Removed |Added
Attachment #15492|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:
What|Removed |Added
Attachment #15493|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:
What|Removed |Added
Attachment #15494|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:
What|Removed |Added
Attachment #15495|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:
What|Removed |Added
Attachment #15496|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:
What|Removed |Added
Attachment #15534|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:
What|Removed |Added
Status|Needs Signoff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
Attachment #14122|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
--- Comment #57 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 15493
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15493action=edit
Bug 7688 follow-up: Small fixes for QA
- #
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
--- Comment #58 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 15494
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15494action=edit
Bug 7688 follow-up: Small fixes for QA #2
- return undef -
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
--- Comment #59 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 15495
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15495action=edit
Bug 7688: Translate sample frequencies for french
--
You
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
--- Comment #60 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 15496
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15496action=edit
Bug 7688: Fix generating next serial when there is no
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
Status|Patch doesn't apply
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
QA Contact|koha.sek...@gmail.com
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
Status|Signed Off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
--- Comment #63 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Testing now, a few notes:
1) applying patches gives a warning about added trailing whitespaces
warning: 3 lines applied after fixing whitespace errors.
2)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Chris Cormack ch...@bigballofwax.co.nz changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
--- Comment #65 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
(In reply to comment #64)
You are using this eh? That tidies the whitespace up so once its signed off
its all fixed :)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
--- Comment #66 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Well, as far as I can test, all is working.
I tried what was described in the original test plan, also did follow the
comments and successive tests and fixes.
I
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:
What|Removed |Added
Status|Needs Signoff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
--- Comment #54 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 14996
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14996action=edit
Bug 7688: Fix generating next serial when there is no
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Julian Maurice julian.maur...@biblibre.com changed:
What|Removed |Added
Attachment #13193|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Julian Maurice julian.maur...@biblibre.com changed:
What|Removed |Added
Attachment #13194|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Julian Maurice julian.maur...@biblibre.com changed:
What|Removed |Added
Attachment #13195|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Julian Maurice julian.maur...@biblibre.com changed:
What|Removed |Added
Attachment #13196|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
--- Comment #53 from Julian Maurice julian.maur...@biblibre.com ---
fix minor conflicts with Bug 8782
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Julian Maurice julian.maur...@biblibre.com changed:
What|Removed |Added
Attachment #11489|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Julian Maurice julian.maur...@biblibre.com changed:
What|Removed |Added
Attachment #11490|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Julian Maurice julian.maur...@biblibre.com changed:
What|Removed |Added
Attachment #12268|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Julian Maurice julian.maur...@biblibre.com changed:
What|Removed |Added
Attachment #12269|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
--- Comment #42 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 12268
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12268action=edit
Bug 7688 follow-up: Small fixes for QA #2
- return undef -
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
--- Comment #43 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 12269
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12269action=edit
Bug 7688: Translate sample frequencies for french
--
You
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Julian Maurice julian.maur...@biblibre.com changed:
What|Removed |Added
Status|Failed QA
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Julian Maurice julian.maur...@biblibre.com changed:
What|Removed |Added
Attachment #11489|Bug 7688: Change
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Julian Maurice julian.maur...@biblibre.com changed:
What|Removed |Added
Attachment #11490|Bug 7688 follow-up: Small
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Paul Poulain paul.poul...@biblibre.com changed:
What|Removed |Added
Status|Signed Off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Paul Poulain paul.poul...@biblibre.com changed:
What|Removed |Added
Status|Passed QA
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
--- Comment #39 from Jonathan Druart jonathan.dru...@biblibre.com ---
wrong bug for last QA note, sorry
--
You are receiving this mail because:
You are watching all bug changes.
___
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
--- Comment #38 from Jonathan Druart jonathan.dru...@biblibre.com ---
QA Comment:
It would be better that someone not from BibLibre make QA on this patch.
To pass QA, some points would be great:
- mandatory: perltidy on all new files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
--- Comment #36 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 11489
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11489action=edit
Bug 7688: Change subscription numbering pattern and frequencies
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
--- Comment #37 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 11490
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11490action=edit
Bug 7688 follow-up: Small fixes for QA
- #
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Attachment #11299|0 |1
1 - 100 of 141 matches
Mail list logo